From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EF0BC433E7 for ; Tue, 13 Oct 2020 10:32:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AB11821548 for ; Tue, 13 Oct 2020 10:32:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730670AbgJMKcy (ORCPT ); Tue, 13 Oct 2020 06:32:54 -0400 Received: from honk.sigxcpu.org ([24.134.29.49]:45920 "EHLO honk.sigxcpu.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729468AbgJMKcy (ORCPT ); Tue, 13 Oct 2020 06:32:54 -0400 Received: from localhost (localhost [127.0.0.1]) by honk.sigxcpu.org (Postfix) with ESMTP id A88C9FB06; Tue, 13 Oct 2020 12:32:50 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at honk.sigxcpu.org Received: from honk.sigxcpu.org ([127.0.0.1]) by localhost (honk.sigxcpu.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id l9H17qvFqi9u; Tue, 13 Oct 2020 12:32:49 +0200 (CEST) Received: by bogon.sigxcpu.org (Postfix, from userid 1000) id 86125402F3; Tue, 13 Oct 2020 12:32:48 +0200 (CEST) From: =?UTF-8?q?Guido=20G=C3=BCnther?= To: Thierry Reding , Sam Ravnborg , David Airlie , Daniel Vetter , Rob Herring , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 0/3] drm/panel: mantix panel reset fixes Date: Tue, 13 Oct 2020 12:32:45 +0200 Message-Id: X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The first patch in this series fixes dereferencing a NULL mode in the error path. The second one extends the resets to not only reset RESX but also TP_RSTN since otherwise the display will stay completely blank. I didn't spot that before initial submission since the reset line was bound to the touch controller and although that failed to probe it came far enough to deassert the reset line (at an arbitrary point in time during boot) and hence we got a picture. Since touch and panel are on the same IC they're not completely independent and i might have to turn the whole thing into an MFD at some point but this series gets the panel to a reliably working state on boot and on fb blank/unblank. Since the reset-gpios are active low we can deassert in prepare and assert in unprepare simplifying the code making sure lines are kept low when the panel is off. The binding were not part of a stable kernel so I hope it's okay to not worry about backward compatibility. Changes from v1: - As per review comments by Fabio Estevam https://lore.kernel.org/dri-devel/CAOMZO5B5ECcConvKej=RcaF8wvOxgq7nUzKJ-ad0aSAOzUqtbQ@mail.gmail.com/ - Fix typo in commit messages - As per review comments by Rob Herring https://lore.kernel.org/dri-devel/20200929174624.GA832332@bogus/ - Don't use an array of reset lines Guido Günther (3): drm/panel: mantix: Don't dereference NULL mode drm/panel: mantix: Fix panel reset dt-binding: display: Require two resets on mantix panel .../display/panel/mantix,mlaf057we51-x.yaml | 4 +++ .../gpu/drm/panel/panel-mantix-mlaf057we51.c | 25 +++++++++++++------ 2 files changed, 21 insertions(+), 8 deletions(-) -- 2.28.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49795C4363A for ; Tue, 13 Oct 2020 10:32:57 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 99E372222C for ; Tue, 13 Oct 2020 10:32:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 99E372222C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sigxcpu.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 597396E0FF; Tue, 13 Oct 2020 10:32:55 +0000 (UTC) Received: from honk.sigxcpu.org (honk.sigxcpu.org [24.134.29.49]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1495A6E0FF for ; Tue, 13 Oct 2020 10:32:54 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by honk.sigxcpu.org (Postfix) with ESMTP id A88C9FB06; Tue, 13 Oct 2020 12:32:50 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at honk.sigxcpu.org Received: from honk.sigxcpu.org ([127.0.0.1]) by localhost (honk.sigxcpu.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id l9H17qvFqi9u; Tue, 13 Oct 2020 12:32:49 +0200 (CEST) Received: by bogon.sigxcpu.org (Postfix, from userid 1000) id 86125402F3; Tue, 13 Oct 2020 12:32:48 +0200 (CEST) From: =?UTF-8?q?Guido=20G=C3=BCnther?= To: Thierry Reding , Sam Ravnborg , David Airlie , Daniel Vetter , Rob Herring , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 0/3] drm/panel: mantix panel reset fixes Date: Tue, 13 Oct 2020 12:32:45 +0200 Message-Id: X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" ClRoZSBmaXJzdCBwYXRjaCBpbiB0aGlzIHNlcmllcyBmaXhlcyBkZXJlZmVyZW5jaW5nIGEgTlVM TCBtb2RlIGluIHRoZSBlcnJvcgpwYXRoLiBUaGUgc2Vjb25kIG9uZSBleHRlbmRzIHRoZSByZXNl dHMgdG8gbm90IG9ubHkgcmVzZXQgUkVTWCBidXQgYWxzbyBUUF9SU1ROCnNpbmNlIG90aGVyd2lz ZSB0aGUgZGlzcGxheSB3aWxsIHN0YXkgY29tcGxldGVseSBibGFuay4gSSBkaWRuJ3Qgc3BvdCB0 aGF0CmJlZm9yZSBpbml0aWFsIHN1Ym1pc3Npb24gc2luY2UgdGhlIHJlc2V0IGxpbmUgd2FzIGJv dW5kIHRvIHRoZSB0b3VjaApjb250cm9sbGVyIGFuZCBhbHRob3VnaCB0aGF0IGZhaWxlZCB0byBw cm9iZSBpdCBjYW1lIGZhciBlbm91Z2ggdG8gZGVhc3NlcnQgdGhlCnJlc2V0IGxpbmUgKGF0IGFu IGFyYml0cmFyeSBwb2ludCBpbiB0aW1lIGR1cmluZyBib290KSBhbmQgaGVuY2Ugd2UgZ290IGEK cGljdHVyZS4gU2luY2UgdG91Y2ggYW5kIHBhbmVsIGFyZSBvbiB0aGUgc2FtZSBJQyB0aGV5J3Jl IG5vdCBjb21wbGV0ZWx5CmluZGVwZW5kZW50IGFuZCBpIG1pZ2h0IGhhdmUgdG8gdHVybiB0aGUg d2hvbGUgdGhpbmcgaW50byBhbiBNRkQgYXQgc29tZSBwb2ludApidXQgdGhpcyBzZXJpZXMgZ2V0 cyB0aGUgcGFuZWwgdG8gYSByZWxpYWJseSB3b3JraW5nIHN0YXRlIG9uIGJvb3QgYW5kIG9uIGZi CmJsYW5rL3VuYmxhbmsuCgpTaW5jZSB0aGUgcmVzZXQtZ3Bpb3MgYXJlIGFjdGl2ZSBsb3cgd2Ug Y2FuIGRlYXNzZXJ0IGluIHByZXBhcmUgYW5kIGFzc2VydCBpbgp1bnByZXBhcmUgc2ltcGxpZnlp bmcgdGhlIGNvZGUgbWFraW5nIHN1cmUgbGluZXMgYXJlIGtlcHQgbG93IHdoZW4gdGhlCnBhbmVs IGlzIG9mZi4KClRoZSBiaW5kaW5nIHdlcmUgbm90IHBhcnQgb2YgYSBzdGFibGUga2VybmVsIHNv IEkgaG9wZSBpdCdzIG9rYXkgdG8gbm90IHdvcnJ5CmFib3V0IGJhY2t3YXJkIGNvbXBhdGliaWxp dHkuCgpDaGFuZ2VzIGZyb20gdjE6CiAtIEFzIHBlciByZXZpZXcgY29tbWVudHMgYnkgRmFiaW8g RXN0ZXZhbQogICBodHRwczovL2xvcmUua2VybmVsLm9yZy9kcmktZGV2ZWwvQ0FPTVpPNUI1RUNj Q29udktlaj1SY2FGOHd2T3hncTduVXpLSi1hZDBhU0FPelVxdGJRQG1haWwuZ21haWwuY29tLwog ICAtIEZpeCB0eXBvIGluIGNvbW1pdCBtZXNzYWdlcwogLSBBcyBwZXIgcmV2aWV3IGNvbW1lbnRz IGJ5IFJvYiBIZXJyaW5nCiAgIGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL2RyaS1kZXZlbC8yMDIw MDkyOTE3NDYyNC5HQTgzMjMzMkBib2d1cy8KICAgLSBEb24ndCB1c2UgYW4gYXJyYXkgb2YgcmVz ZXQgbGluZXMKCkd1aWRvIEfDvG50aGVyICgzKToKICBkcm0vcGFuZWw6IG1hbnRpeDogRG9uJ3Qg ZGVyZWZlcmVuY2UgTlVMTCBtb2RlCiAgZHJtL3BhbmVsOiBtYW50aXg6IEZpeCBwYW5lbCByZXNl dAogIGR0LWJpbmRpbmc6IGRpc3BsYXk6IFJlcXVpcmUgdHdvIHJlc2V0cyBvbiBtYW50aXggcGFu ZWwKCiAuLi4vZGlzcGxheS9wYW5lbC9tYW50aXgsbWxhZjA1N3dlNTEteC55YW1sICAgfCAgNCAr KysKIC4uLi9ncHUvZHJtL3BhbmVsL3BhbmVsLW1hbnRpeC1tbGFmMDU3d2U1MS5jICB8IDI1ICsr KysrKysrKysrKystLS0tLS0KIDIgZmlsZXMgY2hhbmdlZCwgMjEgaW5zZXJ0aW9ucygrKSwgOCBk ZWxldGlvbnMoLSkKCi0tIAoyLjI4LjAKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2RyaS1kZXZlbAo=