From: Roman Kovalivskyi <roman.kovalivskyi@globallogic.com>
To: u-boot@lists.denx.de
Subject: [RESEND 0/7] Refactor generic fastboot_set_reboot_flag implementation
Date: Fri, 23 Oct 2020 11:52:18 +0300 [thread overview]
Message-ID: <cover.1603442753.git.roman.kovalivskyi@globallogic.com> (raw)
Current generic implementation of fastboot_set_reboot_flag is somewhat
messy and requires some additional configuration option to be enabled
besides CMD_BCB, so it reverts that implementtion in order to bring a
new cleaner one.
New function called bcb_set_reboot_reason should be exposed by BCB
commands, so that all of the details could be put there instead of
dealing with it in fastboot implementation directly. After that,
fastboot_set_reboot_flag could simply pass correct reboot reason
string to the BCB implementation. If CMD_BCB is disabled then the
whole operation would return error code, which is no different
behaviour than the current implementation.
Eugeniu Rosca (5):
cmd: bcb: Extract '__bcb_load' from 'do_bcb_load' for internal needs
cmd: bcb: Extract '__bcb_set' from 'do_bcb_set' for internal needs
cmd: bcb: Extract '__bcb_store' from 'do_bcb_store' for internal needs
cmd: bcb: Expose 'bcb_write_reboot_reason' to external callers
cmd: bcb: Add support for processing const string literals in
bcb_set()
Roman Kovalivskyi (2):
Revert "fastboot: Add default fastboot_set_reboot_flag implementation"
fastboot: Implement generic fastboot_set_reboot_flag
cmd/bcb.c | 88 +++++++++++++++++++++++++++-------
drivers/fastboot/Kconfig | 12 -----
drivers/fastboot/Makefile | 1 -
drivers/fastboot/fb_bcb_impl.c | 43 -----------------
drivers/fastboot/fb_common.c | 12 ++++-
include/bcb.h | 20 ++++++++
include/fastboot.h | 9 ----
7 files changed, 101 insertions(+), 84 deletions(-)
delete mode 100644 drivers/fastboot/fb_bcb_impl.c
create mode 100644 include/bcb.h
--
2.17.1
next reply other threads:[~2020-10-23 8:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-23 8:52 Roman Kovalivskyi [this message]
2020-10-23 8:52 ` [RESEND 1/7] cmd: bcb: Extract '__bcb_load' from 'do_bcb_load' for internal needs Roman Kovalivskyi
2020-10-23 8:52 ` [RESEND 2/7] cmd: bcb: Extract '__bcb_set' from 'do_bcb_set' " Roman Kovalivskyi
2020-10-23 8:52 ` [RESEND 3/7] cmd: bcb: Extract '__bcb_store' from 'do_bcb_store' " Roman Kovalivskyi
2020-10-23 8:52 ` [RESEND 4/7] cmd: bcb: Expose 'bcb_write_reboot_reason' to external callers Roman Kovalivskyi
2020-10-23 8:52 ` [RESEND 5/7] cmd: bcb: Add support for processing const string literals in bcb_set() Roman Kovalivskyi
2020-10-23 8:52 ` [RESEND 6/7] Revert "fastboot: Add default fastboot_set_reboot_flag implementation" Roman Kovalivskyi
2021-01-23 15:08 ` Lukasz Majewski
2021-01-25 17:16 ` Roman Kovalivskyi
2021-01-25 18:10 ` Tom Rini
2021-01-25 18:33 ` Marek Vasut
2020-10-23 8:52 ` [RESEND 7/7] fastboot: Implement generic fastboot_set_reboot_flag Roman Kovalivskyi
2021-01-23 15:11 ` Lukasz Majewski
2020-12-10 7:30 ` [RESEND 0/7] Refactor generic fastboot_set_reboot_flag implementation Eugeniu Rosca
2020-12-10 16:54 ` Tom Rini
2021-01-22 9:08 ` Eugeniu Rosca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1603442753.git.roman.kovalivskyi@globallogic.com \
--to=roman.kovalivskyi@globallogic.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.