From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1kbdG4-0004bk-1J for mharc-grub-devel@gnu.org; Sun, 08 Nov 2020 00:28:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42808) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kbdG2-0004ZD-Dm for grub-devel@gnu.org; Sun, 08 Nov 2020 00:28:54 -0500 Received: from mail-ej1-x641.google.com ([2a00:1450:4864:20::641]:37511) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kbdG0-0005hp-6P for grub-devel@gnu.org; Sun, 08 Nov 2020 00:28:54 -0500 Received: by mail-ej1-x641.google.com with SMTP id gn41so7605240ejc.4 for ; Sat, 07 Nov 2020 21:28:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficientek-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KblziST6Cp2fUaMmHJEuP+wReLGDlPGov4nhYBiNCUs=; b=ftQ9M1fCP3Anj7ZGnCBfjErrmSYVVDiBZecDWu8Qp48jJDbQJ4Zsx/jNHpxc8+s0yN 8aMKPzdRaS09zHDc0dR3ZHH1jpktVDYXDfNmR0/Y/JJFqtOhcCkLpHvg0isndXfWBoII yuYVl+uyhBB1NnRH55didPcfK09xbmxXro8QCTAYOcqSW8mHNhAeSuYrlndGwx5dRpCL NKhpKJ5yKy2bIqtTMuliP/6PsoXcA7KvUFAwF6LCfqMjfYhJ7iSfDNKHKK6ERru7vZi9 ufGvvWUhuZIszuR+cw/rhcqbES/A+yBt5klWfW1CoKstl0ASIHg3WHaHReFhHf2ZLo9g du8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KblziST6Cp2fUaMmHJEuP+wReLGDlPGov4nhYBiNCUs=; b=g5s3QhFoDMyVMAYKbCGSjLfgYHepiL/NQScv6p1RzVNar/ZE5ueVxkeR8iCIZnwx4d gCDG/Ew2E5pMnFqJhJE3t0XLQ3HYKjZ0w/bVFlTRFPqF5FSdRzyzhT17h7L6NARGxrGV XrtSWzXyeM/E4ARdUoESecZVs/urYC2qGnKthNcCk4bHxhdA1isjcP+26A3uchmR3WM7 5fl6ckVDpAEWyCZlz002Np1zwIgDHIchCZOmBIyn/tljVJeXBkz6yc5en9uzBfCsf6C+ YECApGYIx8Q8ci6hzYMuEPr5PweUuqVHlB3GeGkpuF+4Qlqi578QVqblIaKwhJKiUsa9 GbjQ== X-Gm-Message-State: AOAM533wgOmxmvJafXDIYTnVjeVM8Yk1oD2h0uXvh+P3ZiAVwXsiF3uw PKsavpWBTzQ4N+9U10sE4w5eY44QCkHm8w== X-Google-Smtp-Source: ABdhPJyu2FkX5U4hqw+3tDjRERORoz/fLwTB2b6pffVvYQ5QnEYd0hJ5e8is/lWUCLtiDhWiYL1OIw== X-Received: by 2002:a17:906:6a15:: with SMTP id o21mr9154186ejr.305.1604813329374; Sat, 07 Nov 2020 21:28:49 -0800 (PST) Received: from localhost.localdomain ([136.49.44.103]) by smtp.gmail.com with ESMTPSA id b1sm4930526edw.27.2020.11.07.21.28.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Nov 2020 21:28:48 -0800 (PST) From: Glenn Washburn To: grub-devel@gnu.org Cc: Daniel Kiper , Glenn Washburn Subject: [PATCH v2 0/2] error: Do compile-time format string checking on grub_error. Date: Sat, 7 Nov 2020 23:26:17 -0600 Message-Id: X-Mailer: git-send-email 2.27.0 In-Reply-To: <20201005061739.640766-1-development@efficientek.com> References: <20201005061739.640766-1-development@efficientek.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::641; envelope-from=development@efficientek.com; helo=mail-ej1-x641.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Nov 2020 05:28:54 -0000 I've separated this into two patches from the previous one, but nothing else has changed (except the commit message). I think at least the first patch should be applied. Since I don't have a setup to test every architecture+platform build of grub, I can't gaurantee that the second patch won't cause a build error on some other architecture+platform combo. However, if it does, I'll bet it'll get fixed quickly. However, for that reason, I suggest the second patch be applied after the 2.06 release (might be moot at this point). This series has successfully built for me for i386-pc and x86_64-efi. Glenn Glenn Washburn (2): error: Fix issues mostly related to incorrect length modifiers in calls to grub_error(). error: Do compile-time format string checking on grub_error. grub-core/commands/pgp.c | 2 +- grub-core/disk/ata.c | 4 ++-- grub-core/disk/cryptodisk.c | 14 ++++++++------ grub-core/disk/dmraid_nvidia.c | 2 +- grub-core/disk/luks2.c | 6 +++--- grub-core/efiemu/i386/loadcore64.c | 3 ++- grub-core/fs/hfsplus.c | 3 ++- grub-core/fs/zfs/zfs.c | 2 +- grub-core/kern/efi/efi.c | 2 +- grub-core/kern/efi/mm.c | 2 +- grub-core/kern/x86_64/dl.c | 2 +- grub-core/loader/efi/chainloader.c | 4 ++-- grub-core/loader/i386/bsd.c | 3 ++- grub-core/loader/i386/pc/linux.c | 4 ++-- grub-core/net/tftp.c | 2 +- grub-core/parttool/msdospart.c | 4 ++-- grub-core/script/lexer.c | 2 +- grub-core/video/bochs.c | 4 ++-- include/grub/err.h | 3 ++- 19 files changed, 37 insertions(+), 31 deletions(-) -- 2.27.0