From: "Martin Ågren" <martin.agren@gmail.com>
To: git@vger.kernel.org
Cc: Alban Gruin <alban.gruin@gmail.com>, Derrick Stolee <stolee@gmail.com>
Subject: [PATCH 0/5] avoid peeking into `struct lock_file`
Date: Tue, 5 Jan 2021 20:23:45 +0100 [thread overview]
Message-ID: <cover.1609874026.git.martin.agren@gmail.com> (raw)
I made a comment in [1] about how we could avoid peeking into a `struct
lock_file` and instead use a helper function that we happen to have at
our disposal. I then grepped around a bit and found that we're pretty
good at avoiding such peeking at the moment, but that we could do
a bit better.
Here's a series to avoid such `lk.tempfile.foo` in favor of
`get_lock_file_foo(&lk)`.
[1] https://lore.kernel.org/git/CAN0heSrOKr--GenbowHP+iwkijbg5pCeJLq+wz6NXCXTsfcvGg@mail.gmail.com/
Martin Ågren (5):
builtin/gc: don't peek into `struct lock_file`
commit-graph: don't peek into `struct lock_file`
midx: don't peek into `struct lock_file`
refs/files-backend: don't peek into `struct lock_file`
read-cache: try not to peek into `struct {lock_,temp}file`
builtin/gc.c | 6 +++---
commit-graph.c | 6 +++---
midx.c | 2 +-
read-cache.c | 12 ++++++------
refs/files-backend.c | 4 ++--
5 files changed, 15 insertions(+), 15 deletions(-)
--
2.30.0
next reply other threads:[~2021-01-05 19:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-05 19:23 Martin Ågren [this message]
2021-01-05 19:23 ` [PATCH 1/5] builtin/gc: don't peek into `struct lock_file` Martin Ågren
2021-01-05 19:23 ` [PATCH 2/5] commit-graph: " Martin Ågren
2021-01-05 19:23 ` [PATCH 3/5] midx: " Martin Ågren
2021-01-05 19:23 ` [PATCH 4/5] refs/files-backend: " Martin Ågren
2021-01-05 19:23 ` [PATCH 5/5] read-cache: try not to peek into `struct {lock_,temp}file` Martin Ågren
2021-01-06 2:16 ` [PATCH 0/5] avoid peeking into `struct lock_file` Derrick Stolee
2021-01-06 11:55 ` Junio C Hamano
2021-01-06 22:36 ` Junio C Hamano
2021-01-07 2:08 ` Derrick Stolee
2021-01-07 7:55 ` Martin Ågren
2021-01-07 8:19 ` Junio C Hamano
2021-01-07 18:17 ` Martin Ågren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1609874026.git.martin.agren@gmail.com \
--to=martin.agren@gmail.com \
--cc=alban.gruin@gmail.com \
--cc=git@vger.kernel.org \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.