All of lore.kernel.org
 help / color / mirror / Atom feed
From: Geliang Tang <geliangtang at gmail.com>
To: mptcp at lists.01.org
Subject: [MPTCP] [MPTCP][PATCH v2 mptcp-next 0/3] remove id 0 address
Date: Tue, 23 Feb 2021 16:26:11 +0800	[thread overview]
Message-ID: <cover.1614068181.git.geliangtang@gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 2281 bytes --]

The RM_ADDR selftests will fail when the removing address id is 0:

copyfd_io_poll: poll timed out (events: POLLIN 1, POLLOUT 0)
copyfd_io_poll: poll timed out (events: POLLIN 1, POLLOUT 0)
 client exit code 2, server 2

netns ns1-0-7z6ol9 socket stat for 10009:
State                      Recv-Q                       Send-Q                                             Local Address:Port                                             Peer Address:Port                      Process                      

netns ns2-0-7z6ol9 socket stat for 10009:
State                       Recv-Q                   Send-Q                                      Local Address:Port                                        Peer Address:Port                    Process                                       
TIME-WAIT                   0                        0                                                10.0.2.2:33225                                           10.0.2.1:10009                    timer:(timewait,26sec,0)

TIME-WAIT                   0                        0                                                10.0.4.2:44309                                           10.0.4.1:10009                    timer:(timewait,26sec,0)

TIME-WAIT                   0                        0                                                10.0.3.2:53671                                           10.0.3.1:10009                    timer:(timewait,26sec,0)

10 flush addresses                      syn[ ok ] - synack[ ok ] - ack[ ok ]
                                        add[ ok ] - echo  [ ok ]
                                        rm [ ok ] - sf    [ ok ]

This patchset fixed this bug.

v2:
 - drop __mptcp_wr_shutdown in v1.

apply: export/20210222T184014
       move to next addr and testcases
       move to next addr when timeout

Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/140

Geliang Tang (3):
  mptcp: unify RM_ADDR and RM_SUBFLOW receiving
  mptcp: skip closing the initial subsocket
  DO-NOT-MERGE: mptcp: remove id 0 test

 net/mptcp/pm_netlink.c                        | 94 +++++++++----------
 .../testing/selftests/net/mptcp/mptcp_join.sh |  8 +-
 2 files changed, 47 insertions(+), 55 deletions(-)

-- 
2.29.2

                 reply	other threads:[~2021-02-23  8:26 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1614068181.git.geliangtang@gmail.com \
    --to=unknown@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.