From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1lHcoM-0006OV-Og for mharc-grub-devel@gnu.org; Wed, 03 Mar 2021 20:29:55 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35780) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHcoE-0006N5-MC for grub-devel@gnu.org; Wed, 03 Mar 2021 20:29:48 -0500 Received: from mail-pj1-x102e.google.com ([2607:f8b0:4864:20::102e]:34522) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lHcoC-0001eq-HF for grub-devel@gnu.org; Wed, 03 Mar 2021 20:29:46 -0500 Received: by mail-pj1-x102e.google.com with SMTP id d13-20020a17090abf8db02900c0590648b1so3724785pjs.1 for ; Wed, 03 Mar 2021 17:29:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficientek-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=myefJsJHlpjgXYNeFi/4vFMiNctsJBwO5LFJV3JzKgQ=; b=wXbYaqtAUD0XfteaD2djAdncdfTX1qrA4fpK13KbQD+/K81QZ/Wljc/Bte3B4ru7BV ONlszzoNu17lhWbXyXq8jaX3Kvvkn4VWzOI/zllbPcPER2/+odzDL3L0yKr7606AQZf+ kSW/S1R+Fp3UfIPWv+z/OSz0yS5FejganfEx/tJemmGhVyWjinHo+xcggoGf/mHMbj33 OwPo71uWi0JRQnXbOMc1uuZUCX9EmRQE2NRcV8qZ0VovoBcRaPzn4y1gFQv4WQ0nU5IE LtjJdHe/5/IEWDGJRfx/TZ2sAomj7K7Lv7Hw6nHVI0gVu7kOu/IaNORuRI4m5A1yhBPX h5Jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=myefJsJHlpjgXYNeFi/4vFMiNctsJBwO5LFJV3JzKgQ=; b=C/Tq1+DpJkX4ur2uOKZ/eLBisGvIVOBaOxpqBCBQ1fDMJzvUTou0dCVj724Ya51VHF 7A/mtTTFALstn5rBxVyPHR5NybOUmAH0nw0LWugNsrlnGBASKh6UatwoJ2U0WXyFG7Jr 6ugE+uy1GSHbCdXyZcFJomV1bL0SLgfpNo9HFySO32/E+eClbHtljj30kmZa6RE/Xqg2 5NiSfSnFWPxZ3U+PW/4CWv/Ubz9NMjcLcgHkUXArkD2jgB6QanPr5SXeNOIC2AaUFqnC lUqleo23loUFyjC7znbOTBKji9cDv+e3LvPBjX4F67t41ni5/MxyRJhrYzOscyaHDg0s WiSA== X-Gm-Message-State: AOAM530R7QF9xE6puBpPTF39HnEXu/AkSyehN5MLOCdwu7xQcM4fLWOf KO03+pxC6bp19DHIH72JI9hM1qfswkTTmg== X-Google-Smtp-Source: ABdhPJzrehtD0K0RbWabuIkZpbPHf1MVZBPMNrzWarIcTa9/xpIf7mUvNkBSRvGHzNygcjRtYkCWxw== X-Received: by 2002:a17:90b:253:: with SMTP id fz19mr1872075pjb.160.1614821382539; Wed, 03 Mar 2021 17:29:42 -0800 (PST) Received: from localhost.localdomain ([2605:a601:aac5:3700:a76b:9596:1e1a:28ee]) by smtp.gmail.com with ESMTPSA id c193sm318190pfc.180.2021.03.03.17.29.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Mar 2021 17:29:41 -0800 (PST) From: Glenn Washburn To: grub-devel@gnu.org, Daniel Kiper Cc: Glenn Washburn Subject: [PATCH v5 00/13] error: Do compile-time format string checking on grub_error Date: Wed, 3 Mar 2021 19:29:05 -0600 Message-Id: X-Mailer: git-send-email 2.27.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::102e; envelope-from=development@efficientek.com; helo=mail-pj1-x102e.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Mar 2021 01:29:49 -0000 This updates patches #8 and #10 per the review in v4. Patch #12 has not been updated because the changes, though better, would disqualify it from merging before the release due to it being more invasive. The goal is to get patch #13, which requires patch #12, in before the release so that patches based on the release will have to have passed format string checking for grub_error. Glenn Glenn Washburn (13): misc: Format string for grub_error should be a literal error: grub_error missing format string argument error: grub_error format string add missing format code dmraid_nvidia: Format string error in grub_error grub_error: Use format code PRIuGRUB_SIZE for variables of type grub_size_t pgp: Format code for grub_error is incorrect efi: Format string error in grub_error error: Use PRI* macros to get correct format string code across architectures error: Use format code PRIxGRUB_UINT64_T for 64-bit uint argument in grub_error error: Use format code PRIxGRUB_UINT64_T for 64-bit arg in grub_error error: Use format code PRIuGRUB_UINT64_T for 64-bit typed fileblock in grub_error error: Use format code llu for 64-bit uint bp->blk_prop in grub_error error: Do compile-time format string checking on grub_error grub-core/commands/pgp.c | 2 +- grub-core/disk/ata.c | 4 ++-- grub-core/disk/cryptodisk.c | 12 ++++++++---- grub-core/disk/dmraid_nvidia.c | 2 +- grub-core/efiemu/i386/loadcore64.c | 3 ++- grub-core/fs/hfsplus.c | 3 ++- grub-core/fs/zfs/zfs.c | 4 ++-- grub-core/kern/arm64/dl.c | 3 ++- grub-core/kern/efi/efi.c | 2 +- grub-core/kern/efi/mm.c | 5 +++-- grub-core/kern/ia64/dl.c | 3 ++- grub-core/kern/riscv/dl.c | 5 +++-- grub-core/kern/sparc64/dl.c | 3 ++- grub-core/kern/x86_64/dl.c | 3 ++- grub-core/loader/efi/chainloader.c | 4 ++-- grub-core/loader/i386/bsd.c | 3 ++- grub-core/loader/i386/pc/linux.c | 7 ++++--- grub-core/net/tftp.c | 2 +- grub-core/parttool/msdospart.c | 4 ++-- grub-core/script/lexer.c | 2 +- grub-core/video/bochs.c | 4 ++-- include/grub/err.h | 3 ++- 22 files changed, 49 insertions(+), 34 deletions(-) -- 2.27.0