All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fabio Aiuto <fabioaiuto83@gmail.com>
To: gregkh@linuxfoundation.org
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	Fabio Aiuto <fabioaiuto83@gmail.com>
Subject: [PATCH 00/15] staging: rtl8723bs: fix checkpatch errors on macros
Date: Fri, 26 Mar 2021 10:09:07 +0100	[thread overview]
Message-ID: <cover.1616748885.git.fabioaiuto83@gmail.com> (raw)

Fix all checkpatch errors on macros but the following:

ERROR: Macros with complex values should be enclosed in parentheses
#41: FILE: drivers/staging/rtl8723bs/include/hal_pwr_seq.h:41:
+#define RTL8723B_TRANS_CARDEMU_TO_ACT														\
--
ERROR: Macros with complex values should be enclosed in parentheses
#67: FILE: drivers/staging/rtl8723bs/include/hal_pwr_seq.h:67:
+#define RTL8723B_TRANS_ACT_TO_CARDEMU													\
--
ERROR: Macros with complex values should be enclosed in parentheses
#80: FILE: drivers/staging/rtl8723bs/include/hal_pwr_seq.h:80:
+#define RTL8723B_TRANS_CARDEMU_TO_SUS													\
--
ERROR: Macros with complex values should be enclosed in parentheses
#91: FILE: drivers/staging/rtl8723bs/include/hal_pwr_seq.h:91:
+#define RTL8723B_TRANS_SUS_TO_CARDEMU													\
--
ERROR: Macros with complex values should be enclosed in parentheses
#100: FILE: drivers/staging/rtl8723bs/include/hal_pwr_seq.h:100:
+#define RTL8723B_TRANS_CARDEMU_TO_CARDDIS													\
--
ERROR: Macros with complex values should be enclosed in parentheses
#111: FILE: drivers/staging/rtl8723bs/include/hal_pwr_seq.h:111:
+#define RTL8723B_TRANS_CARDDIS_TO_CARDEMU													\
--
ERROR: Macros with complex values should be enclosed in parentheses
#123: FILE: drivers/staging/rtl8723bs/include/hal_pwr_seq.h:123:
+#define RTL8723B_TRANS_CARDEMU_TO_PDN												\
--
ERROR: Macros with complex values should be enclosed in parentheses
#136: FILE: drivers/staging/rtl8723bs/include/hal_pwr_seq.h:136:
+#define RTL8723B_TRANS_ACT_TO_LPS														\
--
ERROR: Macros with complex values should be enclosed in parentheses
#154: FILE: drivers/staging/rtl8723bs/include/hal_pwr_seq.h:154:
+#define RTL8723B_TRANS_LPS_TO_ACT															\
--
ERROR: Macros with complex values should be enclosed in parentheses
#170: FILE: drivers/staging/rtl8723bs/include/hal_pwr_seq.h:170:
+ #define RTL8723B_TRANS_ACT_TO_SWLPS														\
--
ERROR: Macros with complex values should be enclosed in parentheses
#197: FILE: drivers/staging/rtl8723bs/include/hal_pwr_seq.h:197:
+#define RTL8723B_TRANS_SWLPS_TO_ACT															\
--

I counld't put braces for they are meant to be expanded inside an 
array definition

ERROR: Macros with complex values should be enclosed in parentheses
#108: FILE: drivers/staging/rtl8723bs/include/osdep_service_linux.h:108:
+#define FUNC_NDEV_ARG(ndev) __func__, ndev->name
--
ERROR: Macros with complex values should be enclosed in parentheses
#110: FILE: drivers/staging/rtl8723bs/include/osdep_service_linux.h:110:
+#define FUNC_ADPT_ARG(adapter) __func__, adapter->pnetdev->nam

All those macros are not used to generate expressions but arguments of
a functions.

If someone knows how to silence those errors as well,
please tell me.

Fabio Aiuto (15):
  staging: rtl8723bs: inlcude macros in a do..while loop in
    core/rtw_security.c
  staging: rtl8723bs: put parentheses on macros with complex values in
    hal/HalBtcOutSrc.h
  staging: rtl8723bs: put parentheses on macros with complex values in
    hal/odm_debug.h
  staging: rtl8723bs: put parentheses on macros with complex values in
    include/basic_types.h
  staging: rtl8723bs: put parentheses on macros with complex values in
    include/drv_types.h
  staging: rtl8723bs: put parentheses on macros with complex values in
    include/hal_com.h
  staging: rtl8723bs: put parentheses on macros with complex values in
    include/hal_com_reg.h
  staging: rtl8723bs: put parentheses on macros with complex values in
    include/hal_data.h
  staging: rtl8723bs: put parentheses on macros with complex values in
    include/hal_phy.h
  staging: rtl8723bs: put parentheses on macros with complex values in
    include/ieee80211.h
  staging: rtl8723bs: put parentheses on macros with complex values in
    include/rtw_debug.h
  staging: rtl8723bs: put parentheses on macros with complex values in
    include/rtw_pwrctrl.h
  staging: rtl8723bs: add spaces around operator in
    include/rtw_pwrctrl.h
  staging: rtl8723bs:  put parentheses on macros with complex values in
    include/sta_info.h
  staging: rtl8723bs:  put parentheses on macros with complex values in
    include/wifi.h

 drivers/staging/rtl8723bs/core/rtw_security.c | 94 +++++++++++--------
 drivers/staging/rtl8723bs/hal/HalBtcOutSrc.h  |  6 +-
 drivers/staging/rtl8723bs/hal/odm_debug.h     |  6 +-
 .../staging/rtl8723bs/include/basic_types.h   | 30 +++---
 drivers/staging/rtl8723bs/include/drv_types.h |  4 +-
 drivers/staging/rtl8723bs/include/hal_com.h   |  8 +-
 .../staging/rtl8723bs/include/hal_com_reg.h   | 14 +--
 drivers/staging/rtl8723bs/include/hal_data.h  |  6 +-
 drivers/staging/rtl8723bs/include/hal_phy.h   |  2 +-
 drivers/staging/rtl8723bs/include/ieee80211.h |  4 +-
 drivers/staging/rtl8723bs/include/rtw_debug.h | 28 +++---
 .../staging/rtl8723bs/include/rtw_pwrctrl.h   |  6 +-
 drivers/staging/rtl8723bs/include/sta_info.h  | 12 +--
 drivers/staging/rtl8723bs/include/wifi.h      | 38 ++++----
 14 files changed, 140 insertions(+), 118 deletions(-)

-- 
2.20.1


             reply	other threads:[~2021-03-26  9:09 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-26  9:09 Fabio Aiuto [this message]
2021-03-26  9:09 ` [PATCH 01/15] staging: rtl8723bs: inlcude macros in a do..while loop in core/rtw_security.c Fabio Aiuto
2021-03-26  9:52   ` Dan Carpenter
2021-03-26 11:04     ` Fabio Aiuto
2021-03-26  9:09 ` [PATCH 02/15] staging: rtl8723bs: put parentheses on macros with complex values in hal/HalBtcOutSrc.h Fabio Aiuto
2021-03-26  9:54   ` Dan Carpenter
2021-03-26 11:09     ` Fabio Aiuto
2021-03-26  9:09 ` [PATCH 03/15] staging: rtl8723bs: put parentheses on macros with complex values in hal/odm_debug.h Fabio Aiuto
2021-03-26  9:09 ` [PATCH 04/15] staging: rtl8723bs: put parentheses on macros with complex values in include/basic_types.h Fabio Aiuto
2021-03-26 10:04   ` Dan Carpenter
2021-03-26 11:12     ` Fabio Aiuto
2021-03-26 14:06       ` Greg KH
2021-03-26  9:09 ` [PATCH 05/15] staging: rtl8723bs: put parentheses on macros with complex values in include/drv_types.h Fabio Aiuto
2021-03-26 14:22   ` Dan Carpenter
2021-03-26 15:12     ` Fabio Aiuto
2021-03-26  9:09 ` [PATCH 06/15] staging: rtl8723bs: put parentheses on macros with complex values in include/hal_com.h Fabio Aiuto
2021-03-26  9:09 ` [PATCH 07/15] staging: rtl8723bs: put parentheses on macros with complex values in include/hal_com_reg.h Fabio Aiuto
2021-03-26  9:09 ` [PATCH 08/15] staging: rtl8723bs: put parentheses on macros with complex values in include/hal_data.h Fabio Aiuto
2021-03-26  9:09 ` [PATCH 09/15] staging: rtl8723bs: put parentheses on macros with complex values in include/hal_phy.h Fabio Aiuto
2021-03-26  9:09 ` [PATCH 10/15] staging: rtl8723bs: put parentheses on macros with complex values in include/ieee80211.h Fabio Aiuto
2021-03-26  9:09 ` [PATCH 11/15] staging: rtl8723bs: put parentheses on macros with complex values in include/rtw_debug.h Fabio Aiuto
2021-03-26  9:09 ` [PATCH 12/15] staging: rtl8723bs: put parentheses on macros with complex values in include/rtw_pwrctrl.h Fabio Aiuto
2021-03-26  9:09 ` [PATCH 13/15] staging: rtl8723bs: add spaces around operator " Fabio Aiuto
2021-03-26  9:09 ` [PATCH 14/15] staging: rtl8723bs: put parentheses on macros with complex values in include/sta_info.h Fabio Aiuto
2021-03-26 13:39   ` David Laight
2021-03-26 13:57     ` Fabio Aiuto
2021-03-26  9:09 ` [PATCH 15/15] staging: rtl8723bs: put parentheses on macros with complex values in include/wifi.h Fabio Aiuto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1616748885.git.fabioaiuto83@gmail.com \
    --to=fabioaiuto83@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.