All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni@redhat.com>
To: mptcp@lists.linux.dev
Cc: Geliang Tang <geliangtang@gmail.com>
Subject: [PATCH v3 mptcp-next 00/21] mptcp: data checksum support
Date: Wed, 21 Apr 2021 22:17:49 +0200	[thread overview]
Message-ID: <cover.1619035356.git.pabeni@redhat.com> (raw)

Changes from v2:
 - implement RFC behavior WRT csum failure and csum mismatch
 - cope with zero win probe and re-injection
 - fix csum computation for DSS with data_fin flag set

I kept the changes from the previous iteration in squash-to
patches to hopefully simplfy the review process.

There are at still least a couple of rough edges:
- csum computation in the rx path for DSS with data fin set
  is likely uncorrect
- the csum computation in the tx path is very suboptimal.

Anyhow, I propose to address the above with additional squash-to patches
to avoid complex/extra long review cycles.

Geliang Tang (14):
  mptcp: add csum_enabled in mptcp_sock
  mptcp: generate the data checksum
  mptcp: add csum_reqd in mptcp_out_options
  mptcp: send out checksum for MP_CAPABLE with data
  mptcp: send out checksum for DSS
  mptcp: add sk parameter for mptcp_parse_option
  mptcp: add csum_reqd in mptcp_options_received
  mptcp: receive checksum for MP_CAPABLE with data
  mptcp: receive checksum for DSS
  mptcp: validate the data checksum
  mptcp: add the mib for data checksum
  mptcp: add a new sysctl checksum_enabled
  selftests: mptcp: enable checksum in mptcp_connect.sh
  selftests: mptcp: enable checksum in mptcp_join.sh

Paolo Abeni (7):
  Squash-to: "mptcp: generate the data checksum"
  Squash-to: "mptcp: send out checksum for MP_CAPABLE with data"
  Squash-to "mptcp: send out checksum for DSS"
  Squash-to: "mptcp: receive checksum for MP_CAPABLE with data"
  Squash-to: "mptcp: receive checksum for DSS"
  Squash-to: mptcp: validate the data checksum
  mptcp: tune re-injections for csum enabled mode.

 Documentation/networking/mptcp-sysctl.rst     |   8 +
 include/net/mptcp.h                           |   7 +-
 include/uapi/linux/mptcp.h                    |   1 +
 net/mptcp/ctrl.c                              |  14 ++
 net/mptcp/mib.c                               |   1 +
 net/mptcp/mib.h                               |   1 +
 net/mptcp/mptcp_diag.c                        |   1 +
 net/mptcp/options.c                           | 147 +++++++++++++-----
 net/mptcp/protocol.c                          |  39 ++++-
 net/mptcp/protocol.h                          |  22 ++-
 net/mptcp/subflow.c                           | 136 +++++++++++++---
 .../selftests/net/mptcp/mptcp_connect.sh      |  13 +-
 .../testing/selftests/net/mptcp/mptcp_join.sh | 107 ++++++++++++-
 13 files changed, 420 insertions(+), 77 deletions(-)

-- 
2.26.2


             reply	other threads:[~2021-04-21 20:20 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-21 20:17 Paolo Abeni [this message]
2021-04-21 20:17 ` [PATCH v3 mptcp-next 01/21] mptcp: add csum_enabled in mptcp_sock Paolo Abeni
2021-04-21 20:17 ` [PATCH v3 mptcp-next 02/21] mptcp: generate the data checksum Paolo Abeni
2021-04-21 20:17 ` [PATCH v3 mptcp-next 03/21] Squash-to: "mptcp: generate the data checksum" Paolo Abeni
2021-04-21 20:17 ` [PATCH v3 mptcp-next 04/21] mptcp: add csum_reqd in mptcp_out_options Paolo Abeni
2021-04-21 20:17 ` [PATCH v3 mptcp-next 05/21] mptcp: send out checksum for MP_CAPABLE with data Paolo Abeni
2021-04-21 20:17 ` [PATCH v3 mptcp-next 06/21] Squash-to: "mptcp: send out checksum for MP_CAPABLE with data" Paolo Abeni
2021-04-21 20:17 ` [PATCH v3 mptcp-next 07/21] mptcp: send out checksum for DSS Paolo Abeni
2021-04-21 20:17 ` [PATCH v3 mptcp-next 08/21] Squash-to "mptcp: send out checksum for DSS" Paolo Abeni
2021-04-23  3:41   ` Geliang Tang
2021-04-23  8:56     ` Paolo Abeni
2021-04-21 20:17 ` [PATCH v3 mptcp-next 09/21] mptcp: add sk parameter for mptcp_parse_option Paolo Abeni
2021-04-21 20:17 ` [PATCH v3 mptcp-next 10/21] mptcp: add csum_reqd in mptcp_options_received Paolo Abeni
2021-04-21 20:18 ` [PATCH v3 mptcp-next 11/21] mptcp: receive checksum for MP_CAPABLE with data Paolo Abeni
2021-04-21 20:18 ` [PATCH v3 mptcp-next 12/21] Squash-to: "mptcp: receive checksum for MP_CAPABLE with data" Paolo Abeni
2021-04-23  3:17   ` Geliang Tang
2021-04-23  8:52     ` Paolo Abeni
2021-04-23  9:16       ` Geliang Tang
2021-04-23  9:33         ` Paolo Abeni
2021-04-21 20:18 ` [PATCH v3 mptcp-next 13/21] mptcp: receive checksum for DSS Paolo Abeni
2021-04-21 20:18 ` [PATCH v3 mptcp-next 14/21] Squash-to: "mptcp: receive checksum for DSS" Paolo Abeni
2021-04-21 20:18 ` [PATCH v3 mptcp-next 15/21] mptcp: validate the data checksum Paolo Abeni
2021-04-21 20:18 ` [PATCH v3 mptcp-next 16/21] Squash-to: " Paolo Abeni
2021-04-23  3:31   ` Geliang Tang
2021-04-23  8:58     ` Paolo Abeni
2021-04-21 20:18 ` [PATCH v3 mptcp-next 17/21] mptcp: tune re-injections for csum enabled mode Paolo Abeni
2021-04-21 20:18 ` [PATCH v3 mptcp-next 18/21] mptcp: add the mib for data checksum Paolo Abeni
2021-04-21 20:18 ` [PATCH v3 mptcp-next 19/21] mptcp: add a new sysctl checksum_enabled Paolo Abeni
2021-04-21 20:18 ` [PATCH v3 mptcp-next 20/21] selftests: mptcp: enable checksum in mptcp_connect.sh Paolo Abeni
2021-04-21 20:18 ` [PATCH v3 mptcp-next 21/21] selftests: mptcp: enable checksum in mptcp_join.sh Paolo Abeni
2021-04-22  6:57 ` [PATCH v3 mptcp-next 00/21] mptcp: data checksum support Geliang Tang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1619035356.git.pabeni@redhat.com \
    --to=pabeni@redhat.com \
    --cc=geliangtang@gmail.com \
    --cc=mptcp@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.