All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christian Schoenebeck <qemu_oss@crudebyte.com>
To: qemu-devel@nongnu.org
Cc: Greg Kurz <groug@kaod.org>
Subject: [PATCH 0/3] 9pfs: Twalk optimization
Date: Thu, 27 May 2021 19:13:12 +0200	[thread overview]
Message-ID: <cover.1622135592.git.qemu_oss@crudebyte.com> (raw)

First draft for reducing latency of Twalk handling by reducing the amount
of thread hops, similar to previous Treaddir optimization. The performance
gain is not as spectacular as on Treaddir, but there is definitely a
measurable difference.

With the benchmark of patch 1, the runtime of the Twalk test was cut in half.
In real world tests I measured a performance gain (i.e. running an entire
guest OS, and hence mixed with all othe kinds of 9p requests) of about 2%,
again measured in a mix, not concentrated on Treaddir at all.

Independent of the actual performance optimization (patch 3), there are some
things about Twalk handling in general which I am yet unsure about. So I'll
add some of my thoughts as reply to patch 3, and depending on that I might
still cleanup / reduce some of the code.

Christian Schoenebeck (3):
  9pfs: Twalk benchmark
  9pfs: capture root stat
  9pfs: reduce latency of Twalk

 hw/9pfs/9p.c                 | 128 +++++++++++++++++++++++------------
 hw/9pfs/9p.h                 |   2 +-
 tests/qtest/virtio-9p-test.c |  30 ++++++++
 3 files changed, 116 insertions(+), 44 deletions(-)

-- 
2.20.1



             reply	other threads:[~2021-05-27 18:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-27 17:13 Christian Schoenebeck [this message]
2021-05-27 17:03 ` [PATCH 1/3] 9pfs: Twalk benchmark Christian Schoenebeck
2021-05-27 17:04 ` [PATCH 2/3] 9pfs: capture root stat Christian Schoenebeck
2021-06-04 13:45   ` Christian Schoenebeck
2021-05-27 17:05 ` [PATCH 3/3] 9pfs: reduce latency of Twalk Christian Schoenebeck
2021-05-27 18:24   ` Christian Schoenebeck
2021-06-04 12:14     ` Christian Schoenebeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1622135592.git.qemu_oss@crudebyte.com \
    --to=qemu_oss@crudebyte.com \
    --cc=groug@kaod.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.