All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Privoznik <mprivozn@redhat.com>
To: qemu-devel@nongnu.org
Cc: marcandre.lureau@redhat.com
Subject: [PATCH 0/2] Two chardev with fdset fixes
Date: Tue, 17 Aug 2021 10:56:26 +0200	[thread overview]
Message-ID: <cover.1629190206.git.mprivozn@redhat.com> (raw)

I was working on libvirt, trying to make it pass a pre-opened FD for a
chardev's logfile. I've spent non-negligible amount of time trying to
figure out why I was getting EACCESS error when QEMU definitely was able
to access the FD. Well, found the problem and here is my attempt to save
future me from figuring it out again.

NB, I'm not fully convinced that EBADFD is the best value, but anything
is better than EACCESS.

Michal Privoznik (2):
  chardev: Propagate error from logfile opening
  monitor: Report EBADFD if fdset contains invalid FD

 chardev/char.c | 7 ++-----
 monitor/misc.c | 2 +-
 2 files changed, 3 insertions(+), 6 deletions(-)

-- 
2.31.1



             reply	other threads:[~2021-08-17  8:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-17  8:56 Michal Privoznik [this message]
2021-08-17  8:56 ` [PATCH 1/2] chardev: Propagate error from logfile opening Michal Privoznik
2021-08-17  9:12   ` Philippe Mathieu-Daudé
2021-08-17  9:54   ` Marc-André Lureau
2021-09-06 12:07     ` Michal Prívozník
2021-08-17  8:56 ` [PATCH 2/2] monitor: Report EBADFD if fdset contains invalid FD Michal Privoznik
2021-08-17  9:59   ` Marc-André Lureau
2021-08-17 11:46     ` Michal Prívozník
2021-08-18  8:39     ` Daniel P. Berrangé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1629190206.git.mprivozn@redhat.com \
    --to=mprivozn@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.