From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F970C433FE for ; Mon, 4 Oct 2021 13:53:23 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A863A61213 for ; Mon, 4 Oct 2021 13:53:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A863A61213 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linuxfoundation.org Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 6441661B7C; Mon, 4 Oct 2021 13:53:22 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TkC75qrohwei; Mon, 4 Oct 2021 13:53:21 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp3.osuosl.org (Postfix) with ESMTPS id 48D7261B6B; Mon, 4 Oct 2021 13:53:21 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 2E011C0011; Mon, 4 Oct 2021 13:53:21 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 34A89C000D for ; Mon, 4 Oct 2021 13:53:19 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 1B33A61B6B for ; Mon, 4 Oct 2021 13:53:19 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id f7DmSuz4aZdm for ; Mon, 4 Oct 2021 13:53:18 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by smtp3.osuosl.org (Postfix) with ESMTPS id 0E68260BD5 for ; Mon, 4 Oct 2021 13:53:17 +0000 (UTC) Received: by mail-pj1-x102d.google.com with SMTP id ls18so1486658pjb.3 for ; Mon, 04 Oct 2021 06:53:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=QehrCbnowDf1RKEEztwsvEnHuiWWf1+by9ueLaqBt5I=; b=HD1FAaEtufc7ayGdPFagvKFo4lY+o6I6/nQOa+nVkJHZWF4gn1Zd86f56QDiJmRERT cJ7/qKo40ISZ9l6pLFbm7BG+GvlqxekUCZucWtRLoGIZL0sAmMTGgGxEbo+89QGomMqk F06R/fZFslZqdzjDhsuFd6DM9UJxmwRmegojJHXlFwjzshrhgKufUcrnmWtk8oQOyKyV 48P036+d1eYmnHMqEMXCm084uNEGSg9txbxUXWiU69JjBsacmUsrPGih+ky85b/2QB3r lLSD1qhYF77rBR/NWuUVA4marCG9VaWVfBOoI9Rnw4dd1xAyB9uJHKQU04cUUSzm0j6p Zhuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=QehrCbnowDf1RKEEztwsvEnHuiWWf1+by9ueLaqBt5I=; b=58y4oXp7uX+zmoGJxEvpKjlzKzECf0b/rz9dshMUbOLcmAxEQgrLoMaQJg5gCna6Mx pDXEq+beJTChW0kX+/QGcOGkEEGbHf1KKdfBtK10oRNG3jSlLrq8quGRUtofRxHfNx73 gGnzNxb3eHgFUv6f6QZTTHLGm6S2vWqnKhQgc+BmdclMsKReu/YPfhbl4FO+ffNfntP/ YGX6DkkJm1Mz16L4NC32OFQvQLwFcAHFghbzBrlwmg+S+l66+U/jmg1FaNuvRiJpuyjd qAuAYGv6H425FVit22nmwMCrxPqgCUWt/qE14MZ3RMmO3YAqRM5s3jDY1+8soYEa2Ys4 bjdQ== X-Gm-Message-State: AOAM532NQ0ll4lnrdGMPlfO0brE9k5lvwhtDGAU+geKxIZLvFbrPcaic 2NiBpks761CD7ddjJpqpQeM= X-Google-Smtp-Source: ABdhPJyN7WK8TDIV07lY6Vw3BSCzWsRh8SxCdZyrqPzER9GZiXV7WlUHrJTVeRbnHqxrI3lD1Qshqw== X-Received: by 2002:a17:90a:1984:: with SMTP id 4mr31119195pji.241.1633355597382; Mon, 04 Oct 2021 06:53:17 -0700 (PDT) Received: from localhost.localdomain ([2406:7400:63:e8f0:c2a7:3579:5fe8:31d9]) by smtp.gmail.com with ESMTPSA id k17sm12209548pfu.82.2021.10.04.06.53.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Oct 2021 06:53:16 -0700 (PDT) From: Naveen Naidu To: bhelgaas@google.com, ruscur@russell.cc, oohall@gmail.com Subject: [PATCH 0/8] Fix long standing AER Error Handling Issues Date: Mon, 4 Oct 2021 19:22:35 +0530 Message-Id: X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel-mentees@lists.linuxfoundation.org, linux-kernel@vger.kernel.org X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" This patch series aims at fixing some of the AER error handling issues we have. Currently we have the following issues: - Confusing message in aer_print_error() - aer_err_info not being initialized completely in DPC path before we print the AER logs - A bug [1] in clearing of AER registers in the native AER path [1] https://lore.kernel.org/linux-pci/20151229155822.GA17321@localhost/ The primary aim of this patch series is to converge the APEI path and the native AER error handling paths. In our current code, we find that we have two different behaviours (especially when it comes to clearing of the AER registers) for the same functionality. This patch series, tries to bring the same semantics and hence more commonanlity between the APEI part of code and the native OS handling of AER errors. PATCH 1: - Fixes the first issue PATCH 2 - 4: - Fixes the second issue - "Patch 3/8" is dependent on "Patch 2/3" in the series PATCH 5 - 7 - Deals with converging the various paths and to bring more commonality between them - "Patch 6/8" depends on "Patch 1/8" PATCH 8: - Adds extra information in AER error logs. Thanks, Naveen Naidu Naveen Naidu (8): [PATCH 1/8] PCI/AER: Remove ID from aer_agent_string[] [PATCH 2/8] PCI: Cleanup struct aer_err_info [PATCH 3/8] PCI/DPC: Initialize info->id in dpc_process_error() [PATCH 4/8] PCI/DPC: Use pci_aer_clear_status() in dpc_process_error() [PATCH 5/8] PCI/DPC: Converge EDR and DPC Path of clearing AER registers [PATCH 6/8] PCI/AER: Clear error device AER registers in aer_irq() [PATCH 7/8] PCI/ERR: Remove redundant clearing of AER register in pcie_do_recovery() [PATCH 8/8] PCI/AER: Include DEVCTL in aer_print_error() drivers/pci/pci.h | 23 +++- drivers/pci/pcie/aer.c | 265 ++++++++++++++++++++++++++++------------- drivers/pci/pcie/dpc.c | 9 +- drivers/pci/pcie/err.c | 9 +- 4 files changed, 207 insertions(+), 99 deletions(-) -- 2.25.1 _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 243EDC433EF for ; Mon, 4 Oct 2021 14:08:16 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D005E611C1 for ; Mon, 4 Oct 2021 14:08:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D005E611C1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linuxfoundation.org Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id A157661B8C; Mon, 4 Oct 2021 14:08:15 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 42n75zokIg5T; Mon, 4 Oct 2021 14:08:14 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp3.osuosl.org (Postfix) with ESMTPS id BC0D361B8B; Mon, 4 Oct 2021 14:08:14 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id A0187C000F; Mon, 4 Oct 2021 14:08:14 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 8B164C000D for ; Mon, 4 Oct 2021 14:08:13 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 792B3405EA for ; Mon, 4 Oct 2021 14:08:13 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp2.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xIaL5FtsmwCO for ; Mon, 4 Oct 2021 14:08:12 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-pg1-x534.google.com (mail-pg1-x534.google.com [IPv6:2607:f8b0:4864:20::534]) by smtp2.osuosl.org (Postfix) with ESMTPS id 8802640134 for ; Mon, 4 Oct 2021 14:08:12 +0000 (UTC) Received: by mail-pg1-x534.google.com with SMTP id s75so5771759pgs.5 for ; Mon, 04 Oct 2021 07:08:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=90VZotrStGy8mgssJr/W9iFiKQDvcfNAnl0DsJhkfs0=; b=o/QK+MjgwS+aEQuPx4irPsbCaHMW6sfXp8BaqM12h1M93plmbNOTRFIEVh1NBvMkEB ZUI/rsaRIpecJgpTBkNdVhjXxkwcmFdasoMV5ExX4poVBKt+rT6b3AXqoH8YrS1V9Cma yTLd30q8/soHf0V8eO5srZz85E1ywxMMQjSiHSXBQmm4FwKQnXqmnLibeVWcAbhZsPoG g7rBm1DWVZe9gEnb4fnGCjTY7cLC1uB+fjbWcPtPfaxV99JFomRFEybhCoXr3oNyDkpZ +zue++onjHrY646/5Vrk8fAzNswt0qpQPvj0GEqZcPrHvgmnxDwplbLQUFeXbAVc1+Wk 8g0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=90VZotrStGy8mgssJr/W9iFiKQDvcfNAnl0DsJhkfs0=; b=kofZNT45ZD/VzsnkSP2H9yCmclFV/ljwL6sg0QwPhShaDVVs1mVEc9G+NgjV6VIHg+ LXMyd0Cw5cWkEYbdP3pLfJ8omx83kgU2mm8co/OaQdK2pSfPfmuuCAUM+or+P/KCR00A 0WhLhz7LbvST6B9hxmHiJ0sybZsWXbLNy5HmfTVmhUGd1hcGucUSZll7BVhbisGdcXVL zLShFNRXVPDS97VfYP1bo8casP5BRSBwlNHB9AsVvAxo6Cu+gy2Ge/GSPE2A1Spkp0gr IuSXfMDeUkZVPLnPVz/dZcKIw+2dCCNte5nrPDaHNnfb/QbRpJ8sudaD+V+XpDrm1HFF qp7Q== X-Gm-Message-State: AOAM533NBBIYnxxiJL/bwFL3HY73QosUNSSxxYy3bUevdnHxaLPmNFlC 7kzACXq4CDGGP9h6UWrIIU0= X-Google-Smtp-Source: ABdhPJxdmeh3wBzsACdJJKEbMJ6nFPRgGudEiYPsvM9XJ9KsMd2LE/efWBCTvow/NjbvzslzV8Q/lg== X-Received: by 2002:a63:63c5:: with SMTP id x188mr5138080pgb.391.1633356491815; Mon, 04 Oct 2021 07:08:11 -0700 (PDT) Received: from localhost.localdomain ([2406:7400:63:e8f0:c2a7:3579:5fe8:31d9]) by smtp.gmail.com with ESMTPSA id p2sm15274135pgd.84.2021.10.04.07.08.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Oct 2021 07:08:11 -0700 (PDT) From: Naveen Naidu To: bhelgaas@google.com, ruscur@russell.cc, oohall@gmail.com Subject: [PATCH v2 0/8] Fix long standing AER Error Handling Issues Date: Mon, 4 Oct 2021 19:36:26 +0530 Message-ID: X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel-mentees@lists.linuxfoundation.org X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" Message-ID: <20211004140626.ZkhdriP2tkVyoQ2nxiOmcwW-SsD_rLRlwI5ccpam-yA@z> This patch series aims at fixing some of the AER error handling issues we have. Currently we have the following issues: - Confusing message in aer_print_error() - aer_err_info not being initialized completely in DPC path before we print the AER logs - A bug [1] in clearing of AER registers in the native AER path [1] https://lore.kernel.org/linux-pci/20151229155822.GA17321@localhost/ The primary aim of this patch series is to converge the APEI path and the native AER error handling paths. In our current code, we find that we have two different behaviours (especially when it comes to clearing of the AER registers) for the same functionality. This patch series, tries to bring the same semantics and hence more commonanlity between the APEI part of code and the native OS handling of AER errors. PATCH 1: - Fixes the first issue PATCH 2 - 4: - Fixes the second issue - "Patch 3/8" is dependent on "Patch 2/3" in the series PATCH 5 - 7 - Deals with converging the various paths and to bring more commonality between them - "Patch 6/8" depends on "Patch 1/8" PATCH 8: - Adds extra information in AER error logs. Thanks, Naveen Naidu Changelog ========= v2: Apologies for the mistake, I forgot to cc the linux-pci mailing list. Resent the email with cc to linux-pci. Naveen Naidu (8): [PATCH v2 1/8] PCI/AER: Remove ID from aer_agent_string[] [PATCH v2 2/8] PCI: Cleanup struct aer_err_info [PATCH v2 3/8] PCI/DPC: Initialize info->id in dpc_process_error() [PATCH v2 4/8] PCI/DPC: Use pci_aer_clear_status() in dpc_process_error() [PATCH v2 5/8] PCI/DPC: Converge EDR and DPC Path of clearing AER registers [PATCH v2 6/8] PCI/AER: Clear error device AER registers in aer_irq() [PATCH v2 7/8] PCI/ERR: Remove redundant clearing of AER register in pcie_do_recovery() [PATCH v2 8/8] PCI/AER: Include DEVCTL in aer_print_error() drivers/pci/pci.h | 23 +++- drivers/pci/pcie/aer.c | 265 ++++++++++++++++++++++++++++------------- drivers/pci/pcie/dpc.c | 9 +- drivers/pci/pcie/err.c | 9 +- 4 files changed, 207 insertions(+), 99 deletions(-) -- 2.25.1 _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F5F9C433EF for ; Mon, 4 Oct 2021 14:08:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4FBDF611C1 for ; Mon, 4 Oct 2021 14:08:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233557AbhJDOKC (ORCPT ); Mon, 4 Oct 2021 10:10:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43686 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231613AbhJDOKB (ORCPT ); Mon, 4 Oct 2021 10:10:01 -0400 Received: from mail-pg1-x532.google.com (mail-pg1-x532.google.com [IPv6:2607:f8b0:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 95D35C061745; Mon, 4 Oct 2021 07:08:12 -0700 (PDT) Received: by mail-pg1-x532.google.com with SMTP id 133so16664130pgb.1; Mon, 04 Oct 2021 07:08:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=90VZotrStGy8mgssJr/W9iFiKQDvcfNAnl0DsJhkfs0=; b=o/QK+MjgwS+aEQuPx4irPsbCaHMW6sfXp8BaqM12h1M93plmbNOTRFIEVh1NBvMkEB ZUI/rsaRIpecJgpTBkNdVhjXxkwcmFdasoMV5ExX4poVBKt+rT6b3AXqoH8YrS1V9Cma yTLd30q8/soHf0V8eO5srZz85E1ywxMMQjSiHSXBQmm4FwKQnXqmnLibeVWcAbhZsPoG g7rBm1DWVZe9gEnb4fnGCjTY7cLC1uB+fjbWcPtPfaxV99JFomRFEybhCoXr3oNyDkpZ +zue++onjHrY646/5Vrk8fAzNswt0qpQPvj0GEqZcPrHvgmnxDwplbLQUFeXbAVc1+Wk 8g0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=90VZotrStGy8mgssJr/W9iFiKQDvcfNAnl0DsJhkfs0=; b=V0CbbIIoy7DHD3t1qapP9Cv+MPDzyzoP9m9AwYSCD+Ny6cc9AoaAXn+mbsRyh0z8Ry 5U0tEubGXfCAE2Gbp68wPCFnxNPz1OgNisOSl2rbeqJ0XpDocWRFAbzpeyKzwMGBFGAR j3Iq7aSm26GOc9i/fcw1o/RTy/00uM/CGBrweVEIbQpzQoChRBlBGSFVJ915lhN7Cx7v Gb5P6CFm5Rkhw4N4Nfmsp//LPhQjrkqlExb0S3RwmBWF4uJBnhySDVxeg/8KZo4qY/VG IRc1BCwM+1XWWMc3eYjEGKLVMt2IbFh6SNn3bthQhLamXFBnYDjZDPswEvhxuTrHODIA wP8A== X-Gm-Message-State: AOAM531jGsIW0Mcj+EalpIq0s8aXaKs+/LQIsYTYmf1WVnHarCSLean9 FjiFrDrm1rJ+mUmed6qxUP8= X-Google-Smtp-Source: ABdhPJxdmeh3wBzsACdJJKEbMJ6nFPRgGudEiYPsvM9XJ9KsMd2LE/efWBCTvow/NjbvzslzV8Q/lg== X-Received: by 2002:a63:63c5:: with SMTP id x188mr5138080pgb.391.1633356491815; Mon, 04 Oct 2021 07:08:11 -0700 (PDT) Received: from localhost.localdomain ([2406:7400:63:e8f0:c2a7:3579:5fe8:31d9]) by smtp.gmail.com with ESMTPSA id p2sm15274135pgd.84.2021.10.04.07.08.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Oct 2021 07:08:11 -0700 (PDT) From: Naveen Naidu To: bhelgaas@google.com, ruscur@russell.cc, oohall@gmail.com Cc: Naveen Naidu , linux-kernel-mentees@lists.linuxfoundation.org, skhan@linuxfoundation.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-pci@vger.kernel.org Subject: [PATCH v2 0/8] Fix long standing AER Error Handling Issues Date: Mon, 4 Oct 2021 19:36:26 +0530 Message-Id: X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org This patch series aims at fixing some of the AER error handling issues we have. Currently we have the following issues: - Confusing message in aer_print_error() - aer_err_info not being initialized completely in DPC path before we print the AER logs - A bug [1] in clearing of AER registers in the native AER path [1] https://lore.kernel.org/linux-pci/20151229155822.GA17321@localhost/ The primary aim of this patch series is to converge the APEI path and the native AER error handling paths. In our current code, we find that we have two different behaviours (especially when it comes to clearing of the AER registers) for the same functionality. This patch series, tries to bring the same semantics and hence more commonanlity between the APEI part of code and the native OS handling of AER errors. PATCH 1: - Fixes the first issue PATCH 2 - 4: - Fixes the second issue - "Patch 3/8" is dependent on "Patch 2/3" in the series PATCH 5 - 7 - Deals with converging the various paths and to bring more commonality between them - "Patch 6/8" depends on "Patch 1/8" PATCH 8: - Adds extra information in AER error logs. Thanks, Naveen Naidu Changelog ========= v2: Apologies for the mistake, I forgot to cc the linux-pci mailing list. Resent the email with cc to linux-pci. Naveen Naidu (8): [PATCH v2 1/8] PCI/AER: Remove ID from aer_agent_string[] [PATCH v2 2/8] PCI: Cleanup struct aer_err_info [PATCH v2 3/8] PCI/DPC: Initialize info->id in dpc_process_error() [PATCH v2 4/8] PCI/DPC: Use pci_aer_clear_status() in dpc_process_error() [PATCH v2 5/8] PCI/DPC: Converge EDR and DPC Path of clearing AER registers [PATCH v2 6/8] PCI/AER: Clear error device AER registers in aer_irq() [PATCH v2 7/8] PCI/ERR: Remove redundant clearing of AER register in pcie_do_recovery() [PATCH v2 8/8] PCI/AER: Include DEVCTL in aer_print_error() drivers/pci/pci.h | 23 +++- drivers/pci/pcie/aer.c | 265 ++++++++++++++++++++++++++++------------- drivers/pci/pcie/dpc.c | 9 +- drivers/pci/pcie/err.c | 9 +- 4 files changed, 207 insertions(+), 99 deletions(-) -- 2.25.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A9F3C433EF for ; Mon, 4 Oct 2021 22:18:38 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 70D2961159 for ; Mon, 4 Oct 2021 22:18:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 70D2961159 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4HNZqc181nz3cDk for ; Tue, 5 Oct 2021 09:18:36 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=HD1FAaEt; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::635; helo=mail-pl1-x635.google.com; envelope-from=naveennaidu479@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=HD1FAaEt; dkim-atps=neutral Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4HNMcg09sWz2xgN for ; Tue, 5 Oct 2021 00:53:20 +1100 (AEDT) Received: by mail-pl1-x635.google.com with SMTP id y1so11132629plk.10 for ; Mon, 04 Oct 2021 06:53:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=QehrCbnowDf1RKEEztwsvEnHuiWWf1+by9ueLaqBt5I=; b=HD1FAaEtufc7ayGdPFagvKFo4lY+o6I6/nQOa+nVkJHZWF4gn1Zd86f56QDiJmRERT cJ7/qKo40ISZ9l6pLFbm7BG+GvlqxekUCZucWtRLoGIZL0sAmMTGgGxEbo+89QGomMqk F06R/fZFslZqdzjDhsuFd6DM9UJxmwRmegojJHXlFwjzshrhgKufUcrnmWtk8oQOyKyV 48P036+d1eYmnHMqEMXCm084uNEGSg9txbxUXWiU69JjBsacmUsrPGih+ky85b/2QB3r lLSD1qhYF77rBR/NWuUVA4marCG9VaWVfBOoI9Rnw4dd1xAyB9uJHKQU04cUUSzm0j6p Zhuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=QehrCbnowDf1RKEEztwsvEnHuiWWf1+by9ueLaqBt5I=; b=KkI/VjIkHWY/WThZw2IPuNNGXaVX32nzFdcnF56OVi1h3DEeP80Tnx+2/qWp7vSZAd NZSJNsaI/QrT3GmfskXgJNQemyWAOYjRRZx7GcOFF2kKXq0vDelgkigS1oelEgasOiWH gzn8iT2hoBIUqbCLbTZCaO3FNo6A0cZtYczQAZ4ZtbZtKlppSSRlhMQHOGy46JCGOWfn dJ5EA7u3Q9xMvUU/v65ClNyGYbO+vXWYU9pkFfO0L6nQ6hCq21EZnbKWkZWN/66JqvTu BuR/XsfmC8krgpqpLOtYn1b6cC3SV5DHQddJWRSuJUyKqA2apRt/ljacqWFzNrsdbXR7 QayQ== X-Gm-Message-State: AOAM532og62c6S3eSi80mVADi57prY+WmF/tS757deLXdlg0niNG1BSH JjtqUSqw+NbDXYysZBXD3FM= X-Google-Smtp-Source: ABdhPJyN7WK8TDIV07lY6Vw3BSCzWsRh8SxCdZyrqPzER9GZiXV7WlUHrJTVeRbnHqxrI3lD1Qshqw== X-Received: by 2002:a17:90a:1984:: with SMTP id 4mr31119195pji.241.1633355597382; Mon, 04 Oct 2021 06:53:17 -0700 (PDT) Received: from localhost.localdomain ([2406:7400:63:e8f0:c2a7:3579:5fe8:31d9]) by smtp.gmail.com with ESMTPSA id k17sm12209548pfu.82.2021.10.04.06.53.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Oct 2021 06:53:16 -0700 (PDT) From: Naveen Naidu To: bhelgaas@google.com, ruscur@russell.cc, oohall@gmail.com Subject: [PATCH 0/8] Fix long standing AER Error Handling Issues Date: Mon, 4 Oct 2021 19:22:35 +0530 Message-Id: X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Mailman-Approved-At: Tue, 05 Oct 2021 09:16:56 +1100 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Naveen Naidu , linuxppc-dev@lists.ozlabs.org, linux-kernel-mentees@lists.linuxfoundation.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" This patch series aims at fixing some of the AER error handling issues we have. Currently we have the following issues: - Confusing message in aer_print_error() - aer_err_info not being initialized completely in DPC path before we print the AER logs - A bug [1] in clearing of AER registers in the native AER path [1] https://lore.kernel.org/linux-pci/20151229155822.GA17321@localhost/ The primary aim of this patch series is to converge the APEI path and the native AER error handling paths. In our current code, we find that we have two different behaviours (especially when it comes to clearing of the AER registers) for the same functionality. This patch series, tries to bring the same semantics and hence more commonanlity between the APEI part of code and the native OS handling of AER errors. PATCH 1: - Fixes the first issue PATCH 2 - 4: - Fixes the second issue - "Patch 3/8" is dependent on "Patch 2/3" in the series PATCH 5 - 7 - Deals with converging the various paths and to bring more commonality between them - "Patch 6/8" depends on "Patch 1/8" PATCH 8: - Adds extra information in AER error logs. Thanks, Naveen Naidu Naveen Naidu (8): [PATCH 1/8] PCI/AER: Remove ID from aer_agent_string[] [PATCH 2/8] PCI: Cleanup struct aer_err_info [PATCH 3/8] PCI/DPC: Initialize info->id in dpc_process_error() [PATCH 4/8] PCI/DPC: Use pci_aer_clear_status() in dpc_process_error() [PATCH 5/8] PCI/DPC: Converge EDR and DPC Path of clearing AER registers [PATCH 6/8] PCI/AER: Clear error device AER registers in aer_irq() [PATCH 7/8] PCI/ERR: Remove redundant clearing of AER register in pcie_do_recovery() [PATCH 8/8] PCI/AER: Include DEVCTL in aer_print_error() drivers/pci/pci.h | 23 +++- drivers/pci/pcie/aer.c | 265 ++++++++++++++++++++++++++++------------- drivers/pci/pcie/dpc.c | 9 +- drivers/pci/pcie/err.c | 9 +- 4 files changed, 207 insertions(+), 99 deletions(-) -- 2.25.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27077C433EF for ; Mon, 4 Oct 2021 22:23:45 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A93F3613D5 for ; Mon, 4 Oct 2021 22:23:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A93F3613D5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4HNZxW0zTtz3cT1 for ; Tue, 5 Oct 2021 09:23:43 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=o/QK+Mjg; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::534; helo=mail-pg1-x534.google.com; envelope-from=naveennaidu479@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=o/QK+Mjg; dkim-atps=neutral Received: from mail-pg1-x534.google.com (mail-pg1-x534.google.com [IPv6:2607:f8b0:4864:20::534]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4HNMxq5r3Wz2xt5 for ; Tue, 5 Oct 2021 01:08:14 +1100 (AEDT) Received: by mail-pg1-x534.google.com with SMTP id e7so16657055pgk.2 for ; Mon, 04 Oct 2021 07:08:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=90VZotrStGy8mgssJr/W9iFiKQDvcfNAnl0DsJhkfs0=; b=o/QK+MjgwS+aEQuPx4irPsbCaHMW6sfXp8BaqM12h1M93plmbNOTRFIEVh1NBvMkEB ZUI/rsaRIpecJgpTBkNdVhjXxkwcmFdasoMV5ExX4poVBKt+rT6b3AXqoH8YrS1V9Cma yTLd30q8/soHf0V8eO5srZz85E1ywxMMQjSiHSXBQmm4FwKQnXqmnLibeVWcAbhZsPoG g7rBm1DWVZe9gEnb4fnGCjTY7cLC1uB+fjbWcPtPfaxV99JFomRFEybhCoXr3oNyDkpZ +zue++onjHrY646/5Vrk8fAzNswt0qpQPvj0GEqZcPrHvgmnxDwplbLQUFeXbAVc1+Wk 8g0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=90VZotrStGy8mgssJr/W9iFiKQDvcfNAnl0DsJhkfs0=; b=kQomRrzRjNEn8u2AKNrulu3NZDVTQ0xPH7uxx4RJIkLQNRlF7QT1qnt4mr+BPhD/9N DetPomVZ5erlcd94DmLipng5skdi2ToLXCuzIbgBDCpfpzNZbq6W65AlgUnjPU7uRMg9 DBIIzIDeJFlDX2LSqkpaH2LsqPidIBFPSS7mgNg1xNHTWWbdtfQQJwCEGwXvYvV9Jj0I SfdEa6WKhkaDB31+sF9UI2UHwAH83qzWhdXtON4B0QB639AeMuJVvh6V8uGfnGSu5p7A wM4M4PwM5s0qAeR/5UOV3KSZPN+KT9oX6fpcsvZCIKrNcU8KptXntZZOayOFjTIVauA5 KsGA== X-Gm-Message-State: AOAM532PsDE3yVDVbu3GDy8E9HLJC/XD7XBSn5EAKMJTkxnKlbCkIoOU +Zyo7DtLSIjb/G6b1XrzSWzXNSRpEzFL65Zi X-Google-Smtp-Source: ABdhPJxdmeh3wBzsACdJJKEbMJ6nFPRgGudEiYPsvM9XJ9KsMd2LE/efWBCTvow/NjbvzslzV8Q/lg== X-Received: by 2002:a63:63c5:: with SMTP id x188mr5138080pgb.391.1633356491815; Mon, 04 Oct 2021 07:08:11 -0700 (PDT) Received: from localhost.localdomain ([2406:7400:63:e8f0:c2a7:3579:5fe8:31d9]) by smtp.gmail.com with ESMTPSA id p2sm15274135pgd.84.2021.10.04.07.08.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Oct 2021 07:08:11 -0700 (PDT) From: Naveen Naidu To: bhelgaas@google.com, ruscur@russell.cc, oohall@gmail.com Subject: [PATCH v2 0/8] Fix long standing AER Error Handling Issues Date: Mon, 4 Oct 2021 19:36:26 +0530 Message-ID: X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Mailman-Approved-At: Tue, 05 Oct 2021 09:16:56 +1100 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Naveen Naidu , skhan@linuxfoundation.org, linuxppc-dev@lists.ozlabs.org, linux-kernel-mentees@lists.linuxfoundation.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Message-ID: <20211004140626.qfYT6vRwor02wdMnnEjx6syJdNj2DSh3pe2CWUnLB0M@z> This patch series aims at fixing some of the AER error handling issues we have. Currently we have the following issues: - Confusing message in aer_print_error() - aer_err_info not being initialized completely in DPC path before we print the AER logs - A bug [1] in clearing of AER registers in the native AER path [1] https://lore.kernel.org/linux-pci/20151229155822.GA17321@localhost/ The primary aim of this patch series is to converge the APEI path and the native AER error handling paths. In our current code, we find that we have two different behaviours (especially when it comes to clearing of the AER registers) for the same functionality. This patch series, tries to bring the same semantics and hence more commonanlity between the APEI part of code and the native OS handling of AER errors. PATCH 1: - Fixes the first issue PATCH 2 - 4: - Fixes the second issue - "Patch 3/8" is dependent on "Patch 2/3" in the series PATCH 5 - 7 - Deals with converging the various paths and to bring more commonality between them - "Patch 6/8" depends on "Patch 1/8" PATCH 8: - Adds extra information in AER error logs. Thanks, Naveen Naidu Changelog ========= v2: Apologies for the mistake, I forgot to cc the linux-pci mailing list. Resent the email with cc to linux-pci. Naveen Naidu (8): [PATCH v2 1/8] PCI/AER: Remove ID from aer_agent_string[] [PATCH v2 2/8] PCI: Cleanup struct aer_err_info [PATCH v2 3/8] PCI/DPC: Initialize info->id in dpc_process_error() [PATCH v2 4/8] PCI/DPC: Use pci_aer_clear_status() in dpc_process_error() [PATCH v2 5/8] PCI/DPC: Converge EDR and DPC Path of clearing AER registers [PATCH v2 6/8] PCI/AER: Clear error device AER registers in aer_irq() [PATCH v2 7/8] PCI/ERR: Remove redundant clearing of AER register in pcie_do_recovery() [PATCH v2 8/8] PCI/AER: Include DEVCTL in aer_print_error() drivers/pci/pci.h | 23 +++- drivers/pci/pcie/aer.c | 265 ++++++++++++++++++++++++++++------------- drivers/pci/pcie/dpc.c | 9 +- drivers/pci/pcie/err.c | 9 +- 4 files changed, 207 insertions(+), 99 deletions(-) -- 2.25.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 810FEC433EF for ; Mon, 4 Oct 2021 13:57:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 573E260FC3 for ; Mon, 4 Oct 2021 13:57:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235462AbhJDN7S (ORCPT ); Mon, 4 Oct 2021 09:59:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39590 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238817AbhJDN6N (ORCPT ); Mon, 4 Oct 2021 09:58:13 -0400 Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 00C60C06136A for ; Mon, 4 Oct 2021 06:53:18 -0700 (PDT) Received: by mail-pl1-x62e.google.com with SMTP id x4so11146220pln.5 for ; Mon, 04 Oct 2021 06:53:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=QehrCbnowDf1RKEEztwsvEnHuiWWf1+by9ueLaqBt5I=; b=HD1FAaEtufc7ayGdPFagvKFo4lY+o6I6/nQOa+nVkJHZWF4gn1Zd86f56QDiJmRERT cJ7/qKo40ISZ9l6pLFbm7BG+GvlqxekUCZucWtRLoGIZL0sAmMTGgGxEbo+89QGomMqk F06R/fZFslZqdzjDhsuFd6DM9UJxmwRmegojJHXlFwjzshrhgKufUcrnmWtk8oQOyKyV 48P036+d1eYmnHMqEMXCm084uNEGSg9txbxUXWiU69JjBsacmUsrPGih+ky85b/2QB3r lLSD1qhYF77rBR/NWuUVA4marCG9VaWVfBOoI9Rnw4dd1xAyB9uJHKQU04cUUSzm0j6p Zhuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=QehrCbnowDf1RKEEztwsvEnHuiWWf1+by9ueLaqBt5I=; b=QEHON0D16NOtj7ensvhXDzaDAgXu65RHuXm2ylfQ/LFCHDSkmt7lxkYv9tTiWOfDfK /Ae2mcbazucq3xEt7wldDJ33qKtlQ27zw/U52borL0pHdFqiXYRn3xqiQ727/GOr9G61 MlS/YuabSZQU9b8TUY+gx4RG9DuoMFodH6q5aO55bUVjmY++qNAzUokofdTrZI5QP3vC jwTkblwBbYEf9IPHnSCgFGrT6V5IzHKIjiNx3ud1B6KQgMATc3BbWGQicybDFHU/fnmn JDHsHFbRuVDsA/RiGj7jWJi07RmIsG3iVZnrebBezaMxH9aHt9xWw+HqUQc5VAA7tS8a ATCQ== X-Gm-Message-State: AOAM530mrBZ0m+nWhn0RjQPGiFyq6pe3SH0SD8JMu9JJDsA7ODDjbiG7 19HuBZXh47URFIlOZSa+ZKI= X-Google-Smtp-Source: ABdhPJyN7WK8TDIV07lY6Vw3BSCzWsRh8SxCdZyrqPzER9GZiXV7WlUHrJTVeRbnHqxrI3lD1Qshqw== X-Received: by 2002:a17:90a:1984:: with SMTP id 4mr31119195pji.241.1633355597382; Mon, 04 Oct 2021 06:53:17 -0700 (PDT) Received: from localhost.localdomain ([2406:7400:63:e8f0:c2a7:3579:5fe8:31d9]) by smtp.gmail.com with ESMTPSA id k17sm12209548pfu.82.2021.10.04.06.53.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Oct 2021 06:53:16 -0700 (PDT) From: Naveen Naidu To: bhelgaas@google.com, ruscur@russell.cc, oohall@gmail.com Cc: Naveen Naidu , linux-kernel-mentees@lists.linuxfoundation.org, skhan@linuxfoundation.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: [PATCH 0/8] Fix long standing AER Error Handling Issues Date: Mon, 4 Oct 2021 19:22:35 +0530 Message-Id: X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch series aims at fixing some of the AER error handling issues we have. Currently we have the following issues: - Confusing message in aer_print_error() - aer_err_info not being initialized completely in DPC path before we print the AER logs - A bug [1] in clearing of AER registers in the native AER path [1] https://lore.kernel.org/linux-pci/20151229155822.GA17321@localhost/ The primary aim of this patch series is to converge the APEI path and the native AER error handling paths. In our current code, we find that we have two different behaviours (especially when it comes to clearing of the AER registers) for the same functionality. This patch series, tries to bring the same semantics and hence more commonanlity between the APEI part of code and the native OS handling of AER errors. PATCH 1: - Fixes the first issue PATCH 2 - 4: - Fixes the second issue - "Patch 3/8" is dependent on "Patch 2/3" in the series PATCH 5 - 7 - Deals with converging the various paths and to bring more commonality between them - "Patch 6/8" depends on "Patch 1/8" PATCH 8: - Adds extra information in AER error logs. Thanks, Naveen Naidu Naveen Naidu (8): [PATCH 1/8] PCI/AER: Remove ID from aer_agent_string[] [PATCH 2/8] PCI: Cleanup struct aer_err_info [PATCH 3/8] PCI/DPC: Initialize info->id in dpc_process_error() [PATCH 4/8] PCI/DPC: Use pci_aer_clear_status() in dpc_process_error() [PATCH 5/8] PCI/DPC: Converge EDR and DPC Path of clearing AER registers [PATCH 6/8] PCI/AER: Clear error device AER registers in aer_irq() [PATCH 7/8] PCI/ERR: Remove redundant clearing of AER register in pcie_do_recovery() [PATCH 8/8] PCI/AER: Include DEVCTL in aer_print_error() drivers/pci/pci.h | 23 +++- drivers/pci/pcie/aer.c | 265 ++++++++++++++++++++++++++++------------- drivers/pci/pcie/dpc.c | 9 +- drivers/pci/pcie/err.c | 9 +- 4 files changed, 207 insertions(+), 99 deletions(-) -- 2.25.1