From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50136C433F5 for ; Mon, 4 Oct 2021 14:30:41 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 047D361360 for ; Mon, 4 Oct 2021 14:30:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 047D361360 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linuxfoundation.org Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id C224961B81; Mon, 4 Oct 2021 14:30:40 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UdEDnmaHzlBJ; Mon, 4 Oct 2021 14:30:40 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp3.osuosl.org (Postfix) with ESMTPS id EBC0461B79; Mon, 4 Oct 2021 14:30:39 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id C5994C000F; Mon, 4 Oct 2021 14:30:39 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 69432C000D for ; Mon, 4 Oct 2021 14:30:38 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 4B3B6415A3 for ; Mon, 4 Oct 2021 14:30:38 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp4.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PH2cAuJ9ACbt for ; Mon, 4 Oct 2021 14:30:37 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) by smtp4.osuosl.org (Postfix) with ESMTPS id 2394D414BA for ; Mon, 4 Oct 2021 14:30:37 +0000 (UTC) Received: by mail-pl1-x633.google.com with SMTP id b22so21613pls.1 for ; Mon, 04 Oct 2021 07:30:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=6rr106+TYNeK97taV8nJ/RZEy+nuSWL8bqPL/aoVjRQ=; b=dCrrsJvny+hB8TpVDzPJqM5XRNvg99gIyL7pccDv7Hg1idhKdsZXpuRzIqSm3k86wK 6EpxKp5R2n/dSTSd3atPrxHHsbxx+oe4QOD9qiSAZBylCjJ/UaJEVRxwhOYJgvYAEwCg 0CzNm2RlWEjNdGNgA4/UBYBB3yQNWWFADdfOlPRfJZb4Qwn7xV0cLfa/mnbiDSaE2V+A J145kLAi1Edyeub2jRxpLg3PP5yJ3pq/1p63zI+4MvIcFjEoGjPVtz07Vu1hRTxdft0L IhSYV9nXW/pt8qQRW7/qijuCW/9s3fZ74iEFxxUI/5U3H+UOjySRtoIH+mIODSuiBZhB G++Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=6rr106+TYNeK97taV8nJ/RZEy+nuSWL8bqPL/aoVjRQ=; b=j9EWXFCYVYmts7iEVyWpMKs+pkdJeqO6ugUgnkG9Nw4I4nvRGZxNreUVXMEftv1oL6 woFITgnl0LwUrYyo5XkqUnln8CwsDtCHvv48Mg/wBWLS4EKFKMMXVUwEgkioaC9tybVL YhXH6EX/8CoKX1Dt1tDVH3fKDRiRxQKZ2sXxNhThPangtsiVuPCDVtlLVQStQqeAwoDI eY4rctHBqpTlqnlT4SasRuJRp8i1w+12X7sdoyWP83qxyYKKf5eS/rZO/eJ6vhfvgFhM QhlNRUaifZ2gP7JRiwu7L4h+7UtQwK1pPXE7da4FSOUrkZKUfJoZPiFPtPmB+pyL6JdS BBnw== X-Gm-Message-State: AOAM533RIbYT/mnGi/pRFC67+VCENeJGm5uwYsf66UrW1Y312oorvtEJ hy1JEhZMKFThT90cvN0NCTc= X-Google-Smtp-Source: ABdhPJw6PldeGsjV/EL0pdYEviOaQ4rPP1DQowLQR2PYIHQgBZUm1Hnv61uEdepS0yhN1pwijPziZA== X-Received: by 2002:a17:902:9689:b0:138:d2ac:44f with SMTP id n9-20020a170902968900b00138d2ac044fmr23336055plp.85.1633357836449; Mon, 04 Oct 2021 07:30:36 -0700 (PDT) Received: from localhost.localdomain ([2406:7400:63:e8f0:c2a7:3579:5fe8:31d9]) by smtp.gmail.com with ESMTPSA id q3sm14489146pgf.18.2021.10.04.07.30.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Oct 2021 07:30:36 -0700 (PDT) From: Naveen Naidu To: bhelgaas@google.com, ruscur@russell.cc, oohall@gmail.com Subject: [PATCH v3 0/8] Fix long standing AER Error Handling Issues Date: Mon, 4 Oct 2021 19:59:56 +0530 Message-Id: X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel-mentees@lists.linuxfoundation.org X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" This patch series aims at fixing some of the AER error handling issues we have. Currently we have the following issues: - Confusing message in aer_print_error() - aer_err_info not being initialized completely in DPC path before we print the AER logs - A bug [1] in clearing of AER registers in the native AER path [1] https://lore.kernel.org/linux-pci/20151229155822.GA17321@localhost/ The primary aim of this patch series is to converge the APEI path and the native AER error handling paths. In our current code, we find that we have two different behaviours (especially when it comes to clearing of the AER registers) for the same functionality. This patch series, tries to bring the same semantics and hence more commonanlity between the APEI part of code and the native OS handling of AER errors. PATCH 1: - Fixes the first issue PATCH 2 - 4: - Fixes the second issue - "Patch 3/8" is dependent on "Patch 2/3" in the series PATCH 5 - 7 - Deals with converging the various paths and to bring more commonality between them - "Patch 6/8" depends on "Patch 1/8" PATCH 8: - Adds extra information in AER error logs. Thanks, Naveen Naidu Changelog ========= v3: - Fix up mail formatting and resend the patches again. Really sorry for all the spam. I messed up in the first try and instead of fixing it well in v2, I messed up again. I have fixed everything now. Apologies for the inconvenience caused. I'll make sure to not repeat it again. v2: - Apologies for the mistake, I forgot to cc the linux-pci mailing list.Resent the email with cc to linux-pci Naveen Naidu (8): [PATCH v3 1/8] PCI/AER: Remove ID from aer_agent_string[] [PATCH v3 2/8] PCI: Cleanup struct aer_err_info [PATCH v3 3/8] PCI/DPC: Initialize info->id in dpc_process_error() [PATCH v3 4/8] PCI/DPC: Use pci_aer_clear_status() in dpc_process_error() [PATCH v3 5/8] PCI/DPC: Converge EDR and DPC Path of clearing AER registers [PATCH v3 6/8] PCI/AER: Clear error device AER registers in aer_irq() [PATCH v3 7/8] PCI/ERR: Remove redundant clearing of AER register in pcie_do_recovery() [PATCH v3 8/8] PCI/AER: Include DEVCTL in aer_print_error() drivers/pci/pci.h | 23 +++- drivers/pci/pcie/aer.c | 265 ++++++++++++++++++++++++++++------------- drivers/pci/pcie/dpc.c | 9 +- drivers/pci/pcie/err.c | 9 +- 4 files changed, 207 insertions(+), 99 deletions(-) -- 2.25.1 _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74373C433EF for ; Mon, 4 Oct 2021 14:30:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5C1C061360 for ; Mon, 4 Oct 2021 14:30:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234078AbhJDOc0 (ORCPT ); Mon, 4 Oct 2021 10:32:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49388 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233516AbhJDOcZ (ORCPT ); Mon, 4 Oct 2021 10:32:25 -0400 Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0CB7CC061745; Mon, 4 Oct 2021 07:30:37 -0700 (PDT) Received: by mail-pj1-x1030.google.com with SMTP id qe4-20020a17090b4f8400b0019f663cfcd1so211955pjb.1; Mon, 04 Oct 2021 07:30:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=6rr106+TYNeK97taV8nJ/RZEy+nuSWL8bqPL/aoVjRQ=; b=dCrrsJvny+hB8TpVDzPJqM5XRNvg99gIyL7pccDv7Hg1idhKdsZXpuRzIqSm3k86wK 6EpxKp5R2n/dSTSd3atPrxHHsbxx+oe4QOD9qiSAZBylCjJ/UaJEVRxwhOYJgvYAEwCg 0CzNm2RlWEjNdGNgA4/UBYBB3yQNWWFADdfOlPRfJZb4Qwn7xV0cLfa/mnbiDSaE2V+A J145kLAi1Edyeub2jRxpLg3PP5yJ3pq/1p63zI+4MvIcFjEoGjPVtz07Vu1hRTxdft0L IhSYV9nXW/pt8qQRW7/qijuCW/9s3fZ74iEFxxUI/5U3H+UOjySRtoIH+mIODSuiBZhB G++Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=6rr106+TYNeK97taV8nJ/RZEy+nuSWL8bqPL/aoVjRQ=; b=w5Je2kRN3toooDz93EP8PXGub2DZX6+zElUZ50og4HtcT3Y0pq0iuElm0OyB7+5N0n ypn5n7fND3xicGBEnpVI6FMl3rOIk5OXhrVBzrQmQVgK/CiJbfHAtXBCZiuTmWrBOxd+ Sr9oJ9qP85qxcPJ/1KUWhmgKpH2ouUFLQlfn8vH+0bJJXwqQy8cT8dc5rAbvuf+jFQtK jgLKTTwRg3ihsEFpf1do88RuszpikndUcRRE6D8AVrkAOAAq7ntERU/7CJ9fFaU7y9F9 TzRRWDVqQz3SIoAnPV5Jow1/r+Pta2WQ9HkZ3QGkR/rQNk2kxl3VHAsv31v0HI74IzXz 9rSQ== X-Gm-Message-State: AOAM532o49X1d8MplLbI6sZ48C6KJ8mjnzUf2YdHGzF1LIjrjAT7ezl3 DEyC7Jm1NM+nk6ZCmq4Cn/4= X-Google-Smtp-Source: ABdhPJw6PldeGsjV/EL0pdYEviOaQ4rPP1DQowLQR2PYIHQgBZUm1Hnv61uEdepS0yhN1pwijPziZA== X-Received: by 2002:a17:902:9689:b0:138:d2ac:44f with SMTP id n9-20020a170902968900b00138d2ac044fmr23336055plp.85.1633357836449; Mon, 04 Oct 2021 07:30:36 -0700 (PDT) Received: from localhost.localdomain ([2406:7400:63:e8f0:c2a7:3579:5fe8:31d9]) by smtp.gmail.com with ESMTPSA id q3sm14489146pgf.18.2021.10.04.07.30.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Oct 2021 07:30:36 -0700 (PDT) From: Naveen Naidu To: bhelgaas@google.com, ruscur@russell.cc, oohall@gmail.com Cc: Naveen Naidu , linux-kernel-mentees@lists.linuxfoundation.org, skhan@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: [PATCH v3 0/8] Fix long standing AER Error Handling Issues Date: Mon, 4 Oct 2021 19:59:56 +0530 Message-Id: X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org This patch series aims at fixing some of the AER error handling issues we have. Currently we have the following issues: - Confusing message in aer_print_error() - aer_err_info not being initialized completely in DPC path before we print the AER logs - A bug [1] in clearing of AER registers in the native AER path [1] https://lore.kernel.org/linux-pci/20151229155822.GA17321@localhost/ The primary aim of this patch series is to converge the APEI path and the native AER error handling paths. In our current code, we find that we have two different behaviours (especially when it comes to clearing of the AER registers) for the same functionality. This patch series, tries to bring the same semantics and hence more commonanlity between the APEI part of code and the native OS handling of AER errors. PATCH 1: - Fixes the first issue PATCH 2 - 4: - Fixes the second issue - "Patch 3/8" is dependent on "Patch 2/3" in the series PATCH 5 - 7 - Deals with converging the various paths and to bring more commonality between them - "Patch 6/8" depends on "Patch 1/8" PATCH 8: - Adds extra information in AER error logs. Thanks, Naveen Naidu Changelog ========= v3: - Fix up mail formatting and resend the patches again. Really sorry for all the spam. I messed up in the first try and instead of fixing it well in v2, I messed up again. I have fixed everything now. Apologies for the inconvenience caused. I'll make sure to not repeat it again. v2: - Apologies for the mistake, I forgot to cc the linux-pci mailing list.Resent the email with cc to linux-pci Naveen Naidu (8): [PATCH v3 1/8] PCI/AER: Remove ID from aer_agent_string[] [PATCH v3 2/8] PCI: Cleanup struct aer_err_info [PATCH v3 3/8] PCI/DPC: Initialize info->id in dpc_process_error() [PATCH v3 4/8] PCI/DPC: Use pci_aer_clear_status() in dpc_process_error() [PATCH v3 5/8] PCI/DPC: Converge EDR and DPC Path of clearing AER registers [PATCH v3 6/8] PCI/AER: Clear error device AER registers in aer_irq() [PATCH v3 7/8] PCI/ERR: Remove redundant clearing of AER register in pcie_do_recovery() [PATCH v3 8/8] PCI/AER: Include DEVCTL in aer_print_error() drivers/pci/pci.h | 23 +++- drivers/pci/pcie/aer.c | 265 ++++++++++++++++++++++++++++------------- drivers/pci/pcie/dpc.c | 9 +- drivers/pci/pcie/err.c | 9 +- 4 files changed, 207 insertions(+), 99 deletions(-) -- 2.25.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4496BC433F5 for ; Mon, 4 Oct 2021 22:29:32 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D86486108F for ; Mon, 4 Oct 2021 22:29:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D86486108F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4HNb4B3gZ3z2yxV for ; Tue, 5 Oct 2021 09:29:30 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=dCrrsJvn; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::102c; helo=mail-pj1-x102c.google.com; envelope-from=naveennaidu479@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=dCrrsJvn; dkim-atps=neutral Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com [IPv6:2607:f8b0:4864:20::102c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4HNNRl3bhhz2yHt for ; Tue, 5 Oct 2021 01:30:41 +1100 (AEDT) Received: by mail-pj1-x102c.google.com with SMTP id k23so796623pji.0 for ; Mon, 04 Oct 2021 07:30:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=6rr106+TYNeK97taV8nJ/RZEy+nuSWL8bqPL/aoVjRQ=; b=dCrrsJvny+hB8TpVDzPJqM5XRNvg99gIyL7pccDv7Hg1idhKdsZXpuRzIqSm3k86wK 6EpxKp5R2n/dSTSd3atPrxHHsbxx+oe4QOD9qiSAZBylCjJ/UaJEVRxwhOYJgvYAEwCg 0CzNm2RlWEjNdGNgA4/UBYBB3yQNWWFADdfOlPRfJZb4Qwn7xV0cLfa/mnbiDSaE2V+A J145kLAi1Edyeub2jRxpLg3PP5yJ3pq/1p63zI+4MvIcFjEoGjPVtz07Vu1hRTxdft0L IhSYV9nXW/pt8qQRW7/qijuCW/9s3fZ74iEFxxUI/5U3H+UOjySRtoIH+mIODSuiBZhB G++Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=6rr106+TYNeK97taV8nJ/RZEy+nuSWL8bqPL/aoVjRQ=; b=ONhF3kXulkm48rOaCZqJ8RBLL/x0ECW0fIyCacRdmbJ47pW+apY1Nr2q1DyDGZeTcH oLbJBDT0tctjunROcQy0BS8PRi6n5ub+ipPz84mTZ5eTpf1ZLlCIO+GMYsBq+9YGZhw1 9simIl8Kx1JeF8ZLsqc8d+kMSAJk7g3zSwQvaUQMmd/CCLfCmKbhLCOzT3z4eC4eWn+d haL9Zx4qqjslSqaFeJn8s5OwwCj+8XJJJUKC3cvfuxhYSFCSj3SRAts/g8f3dDsfUsF1 +yuEXp7d+QYcT03xvkMX9NKVnPtrFdkMHVNr4dK38KiRUlIkAaKJGKP3/cid2OBcOZzJ ZshA== X-Gm-Message-State: AOAM5339Ro8SHdk4ntsODwGJgDfnJtUZyCjjEfWObvx4HSTA6lq6/vJq Wwe8j8PNxzSC0E2mOSDJpho= X-Google-Smtp-Source: ABdhPJw6PldeGsjV/EL0pdYEviOaQ4rPP1DQowLQR2PYIHQgBZUm1Hnv61uEdepS0yhN1pwijPziZA== X-Received: by 2002:a17:902:9689:b0:138:d2ac:44f with SMTP id n9-20020a170902968900b00138d2ac044fmr23336055plp.85.1633357836449; Mon, 04 Oct 2021 07:30:36 -0700 (PDT) Received: from localhost.localdomain ([2406:7400:63:e8f0:c2a7:3579:5fe8:31d9]) by smtp.gmail.com with ESMTPSA id q3sm14489146pgf.18.2021.10.04.07.30.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Oct 2021 07:30:36 -0700 (PDT) From: Naveen Naidu To: bhelgaas@google.com, ruscur@russell.cc, oohall@gmail.com Subject: [PATCH v3 0/8] Fix long standing AER Error Handling Issues Date: Mon, 4 Oct 2021 19:59:56 +0530 Message-Id: X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Mailman-Approved-At: Tue, 05 Oct 2021 09:16:56 +1100 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Naveen Naidu , skhan@linuxfoundation.org, linuxppc-dev@lists.ozlabs.org, linux-kernel-mentees@lists.linuxfoundation.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" This patch series aims at fixing some of the AER error handling issues we have. Currently we have the following issues: - Confusing message in aer_print_error() - aer_err_info not being initialized completely in DPC path before we print the AER logs - A bug [1] in clearing of AER registers in the native AER path [1] https://lore.kernel.org/linux-pci/20151229155822.GA17321@localhost/ The primary aim of this patch series is to converge the APEI path and the native AER error handling paths. In our current code, we find that we have two different behaviours (especially when it comes to clearing of the AER registers) for the same functionality. This patch series, tries to bring the same semantics and hence more commonanlity between the APEI part of code and the native OS handling of AER errors. PATCH 1: - Fixes the first issue PATCH 2 - 4: - Fixes the second issue - "Patch 3/8" is dependent on "Patch 2/3" in the series PATCH 5 - 7 - Deals with converging the various paths and to bring more commonality between them - "Patch 6/8" depends on "Patch 1/8" PATCH 8: - Adds extra information in AER error logs. Thanks, Naveen Naidu Changelog ========= v3: - Fix up mail formatting and resend the patches again. Really sorry for all the spam. I messed up in the first try and instead of fixing it well in v2, I messed up again. I have fixed everything now. Apologies for the inconvenience caused. I'll make sure to not repeat it again. v2: - Apologies for the mistake, I forgot to cc the linux-pci mailing list.Resent the email with cc to linux-pci Naveen Naidu (8): [PATCH v3 1/8] PCI/AER: Remove ID from aer_agent_string[] [PATCH v3 2/8] PCI: Cleanup struct aer_err_info [PATCH v3 3/8] PCI/DPC: Initialize info->id in dpc_process_error() [PATCH v3 4/8] PCI/DPC: Use pci_aer_clear_status() in dpc_process_error() [PATCH v3 5/8] PCI/DPC: Converge EDR and DPC Path of clearing AER registers [PATCH v3 6/8] PCI/AER: Clear error device AER registers in aer_irq() [PATCH v3 7/8] PCI/ERR: Remove redundant clearing of AER register in pcie_do_recovery() [PATCH v3 8/8] PCI/AER: Include DEVCTL in aer_print_error() drivers/pci/pci.h | 23 +++- drivers/pci/pcie/aer.c | 265 ++++++++++++++++++++++++++++------------- drivers/pci/pcie/dpc.c | 9 +- drivers/pci/pcie/err.c | 9 +- 4 files changed, 207 insertions(+), 99 deletions(-) -- 2.25.1