From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1mb7oA-0004Fl-5q for mharc-grub-devel@gnu.org; Thu, 14 Oct 2021 16:58:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36516) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mb7o8-0004DV-Od for grub-devel@gnu.org; Thu, 14 Oct 2021 16:58:32 -0400 Received: from mail-ot1-x336.google.com ([2607:f8b0:4864:20::336]:37680) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mb7o6-0000CP-R4 for grub-devel@gnu.org; Thu, 14 Oct 2021 16:58:32 -0400 Received: by mail-ot1-x336.google.com with SMTP id b4-20020a9d7544000000b00552ab826e3aso8230701otl.4 for ; Thu, 14 Oct 2021 13:58:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficientek-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=U9pHaELwuZOg7NxmdM/Q8D6Q0SlXxz2MyprWixqWvUI=; b=REMlhT/JZ7tIkC+Ljc08x8+UdFAp42C2OovEfOnEN3crdvWYDz8pn2SzGpOfd7MevU hLy2F2lUx0LFtDtQBJiSV4M75D96THLbylDuyhblL6idq+X0K8f8dZOGTO+vGRaB160G YduGRKG8F1V6O8mNoaN6SPf6ARUV75n63STlcnDOOJlGlucXlsVb6+oETgNw46yboMB3 dlfGLQki5REppEkNfTEW0Ew1P9ZnHqnPynv2HxyCnh++NmP9CJEWiGKiGbfW3QexoarT rhZr+o3F6fKEz1QQ//vJXvyY7qN0M1Um8lj+YC9sKUvdj7ZwSwavs0+Y79bpV//buWQy Ut3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=U9pHaELwuZOg7NxmdM/Q8D6Q0SlXxz2MyprWixqWvUI=; b=Pag7DNeca5FpUjUb24sJwr6i/wu78+4HI/6Ly1+oxfRRxD5b08QS2kNxLaDQYY0Vzr LJSZJRJwblwhz6kz4caV0w2Mw9/zT2iQlytFDghQjxlsEefp2MDhnGYf8WiTDEwnGSBH aCeu14zp4RRkYnyS9v/28BrnugA48tJFjzmSAhCiUf7qIigM57P/fYfHayonxfzfLAPR NLoFA5NvJamMyee5m/HenGnR5VZQpo1YFUPqARQARViJALSU6lFFxHUh/zCsbA53LwTp iTs8C356rk6Oz3paQIp8ywAJ11O8/XmtEga/XL1X3Vc/TT6xy4n7/r7pbiym8DcVZD+E I5sQ== X-Gm-Message-State: AOAM530N7+JLhcyX6vnY5FmdFvRe8fOEZ9ugkeHJVVl78+6q56ZtxX08 yPr3yDxNh8Ov7Io7/uFrRC+ubJnCt8h1HQ== X-Google-Smtp-Source: ABdhPJwCWyMJKsiHNZIwN+5NRqYqHVwMt0EFIaFiG8difcBcEkwcCgJUYQcaL8NoEH68m976aiuDhw== X-Received: by 2002:a05:6830:1ad5:: with SMTP id r21mr4751393otc.192.1634245108810; Thu, 14 Oct 2021 13:58:28 -0700 (PDT) Received: from localhost.localdomain ([37.218.244.251]) by smtp.gmail.com with ESMTPSA id e2sm648255ooa.20.2021.10.14.13.58.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Oct 2021 13:58:28 -0700 (PDT) From: Glenn Washburn To: grub-devel@gnu.org, Daniel Kiper Cc: Glenn Washburn Subject: [PATCH v2 0/2] More test fixes Date: Thu, 14 Oct 2021 15:58:06 -0500 Message-Id: X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::336; envelope-from=development@efficientek.com; helo=mail-ot1-x336.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Oct 2021 20:58:33 -0000 Updates since v1: * Rebase onto latest master The first patch changes the test exit status from skipped to hard error, for tests which fail due to missing dependencies in the environment. The second is a trivial patch to parameterize all uses of parted in the partmap_test. Glenn Glenn Washburn (2): tests: Test aborts due to missing requirements should be marked as error instead of skipped tests: In partmap_test, use ${parted} variable when checking for binary tests/btrfs_test.in | 4 ++-- tests/cpio_test.in | 2 +- tests/exfat_test.in | 4 ++-- tests/ext234_test.in | 8 ++++---- tests/f2fs_test.in | 4 ++-- tests/fat_test.in | 4 ++-- tests/gzcompress_test.in | 2 +- tests/hfs_test.in | 6 +++--- tests/hfsplus_test.in | 4 ++-- tests/iso9660_test.in | 2 +- tests/jfs_test.in | 4 ++-- tests/lzocompress_test.in | 2 +- tests/minixfs_test.in | 8 ++++---- tests/nilfs2_test.in | 4 ++-- tests/ntfs_test.in | 6 +++--- tests/partmap_test.in | 6 +++--- tests/reiserfs_test.in | 4 ++-- tests/romfs_test.in | 2 +- tests/squashfs_test.in | 2 +- tests/tar_test.in | 2 +- tests/udf_test.in | 4 ++-- tests/xfs_test.in | 4 ++-- tests/xzcompress_test.in | 2 +- tests/zfs_test.in | 4 ++-- 24 files changed, 47 insertions(+), 47 deletions(-) Range-diff against v1: 1: e2f9f26f2 ! 1: 6234f860a tests: Test aborts due to missing requirements should be marked as error instead of skipped @@ tests/gzcompress_test.in: grubshell=@builddir@/grub-shell + exit 99 fi - if [ "$(echo hello | "${grubshell}" --mkrescue-arg=--compress=gz)" != "Hello World" ]; then + v=$(echo hello | "${grubshell}" --mkrescue-arg=--compress=gz) ## tests/hfs_test.in ## @@ tests/hfs_test.in: if [ "x$EUID" = "x" ] ; then @@ tests/lzocompress_test.in: grubshell=@builddir@/grub-shell + exit 99 fi - if [ "$(echo hello | "${grubshell}" --mkrescue-arg=--compress=lzo)" != "Hello World" ]; then + v=$(echo hello | "${grubshell}" --mkrescue-arg=--compress=lzo) ## tests/minixfs_test.in ## @@ tests/minixfs_test.in: if [ "x$EUID" = "x" ] ; then @@ tests/xzcompress_test.in: grubshell=@builddir@/grub-shell + exit 99 fi - if [ "$(echo hello | "${grubshell}" --mkrescue-arg=--compress=xz)" != "Hello World" ]; then + v=$(echo hello | "${grubshell}" --mkrescue-arg=--compress=xz) ## tests/zfs_test.in ## @@ tests/zfs_test.in: if [ "x$EUID" = "x" ] ; then 2: e35d3bb81 = 2: d1aefde55 tests: In partmap_test, use ${parted} variable when checking for binary -- 2.27.0