From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1mfOYD-0002n7-J0 for mharc-grub-devel@gnu.org; Tue, 26 Oct 2021 11:39:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51926) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mfOYB-0002jN-PJ for grub-devel@gnu.org; Tue, 26 Oct 2021 11:39:43 -0400 Received: from mx0a-00069f02.pphosted.com ([205.220.165.32]:42048) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mfOY9-0001rD-18 for grub-devel@gnu.org; Tue, 26 Oct 2021 11:39:43 -0400 Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19QEoZWA001959 for ; Tue, 26 Oct 2021 15:39:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : content-transfer-encoding : content-type : mime-version; s=corp-2021-07-09; bh=t7gsgutld/Dq+M6qy+Q09XNuq3Ia+k0KgmtWMId6tLc=; b=uYIOt4E5tM/K3y46MFdQ1lJPhm3GKUvU6a/OBVvtRU2epYoLOhxsKq5WPYX3uf1H7Yvx P4wQ7pudbj88nooDoA10Wmeil5xORq0tJBkdha5M770PdXXrUWspOnG8u7QfTwXMjJ// IMz3bB2y4Q8ziiOkT/d2/4wied/Y8hwxUhb2sGCLbhdQ3yjf/Lt8CTeuUTVigexchyJQ G8MqhYmSt/1IfVfO+ogMbEYDnPKKg4coKeGWuHx4qhT2mvyELK4khFE0OQSKfxQoDOJ0 E1yXaDtWukLNF4YE2o7CbHvDTWYwnf7Tqvl+nice7BthXqXNm9Jtl5mP10wt+A/+GwZ3 IA== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by mx0b-00069f02.pphosted.com with ESMTP id 3bx4fycykw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 26 Oct 2021 15:39:38 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 19QEjWPQ047707 for ; Tue, 26 Oct 2021 15:03:14 GMT Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2109.outbound.protection.outlook.com [104.47.55.109]) by aserp3020.oracle.com with ESMTP id 3bx4gb4sm9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 26 Oct 2021 15:03:13 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MLvw5m4ShSMnaM8a4DxCu/JsnpkT1x3qUfarXepe/9rnfMJB5bm9eVeihVhtshoPoHPJW0WUN1J23+vM0O87OMfYHeBSLFM76sK6cAyUaQPmjq71tiKqyygfSG0dW66Fup/C5RrugOfw3wkCMuknYt6K/MKC80LxArLIZ3L+bNd2kuIjzFPJwDGIWWpAyhY5HDGCFh8gU9wNG7U+Hi7bWzULPJ3VQm80hyoQdKfJfYPaGj7AvqWSj6fRYaMx8mfWCkw1mYzdcahBQsNqfaDCfoyw9Pd09w/Hrm212X/GzXKPcNeAgVKNM2v05CYT27S8KBzoSIl3oveTuzKbMKkALg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=t7gsgutld/Dq+M6qy+Q09XNuq3Ia+k0KgmtWMId6tLc=; b=OEeypjRChLgOVZX1J9awEL07oTm8XY4JzAY8TZ2yj1mDIkXrQDBLiZGhGV98hy6OueG2zCTZHdqkrQTENc4wXTJ7n9sr/FPSqcUULsQ3ddbGn6cyR2Fz1q/nbZfexPK7CkS6bctvnM7vMcLtZvtl8V4Os2VykhSkD3u7zvtd+Ds32s9NYjerpCa7gYcWeDyiu0G+gl+lQQYSHdJe+fZXDwRU1N002d5lcDqbui3+LwHSOvrxZnU5LcU80cIxlrDRmX/ICwq7heYYeElt1RyttaaPtXlDS2DA/yIX9rRNhFxNhr0m7IKHkQ+KPfbhZtGi69dakl1fi5EFt+bUSt+ZLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=t7gsgutld/Dq+M6qy+Q09XNuq3Ia+k0KgmtWMId6tLc=; b=yZ8Kn6pVWVc6ix0xzxtYt8Kobktv9cRaPww1EXSuW5sjNRBKjaLORZKJbx+nVp3ncBB4YzQ2Ym4K5ZNTnuL3BCTzSWqOnbhLhFOBHs9aaJ3jUIcTxlYEmgNBo+Zr++jKe6HyKA+G6KV0G9FCHpDRGEpC6y7bpIp/Nh485nQm0dI= Authentication-Results: gnu.org; dkim=none (message not signed) header.d=none;gnu.org; dmarc=none action=none header.from=oracle.com; Received: from BLAPR10MB5138.namprd10.prod.outlook.com (2603:10b6:208:322::8) by BLAPR10MB5234.namprd10.prod.outlook.com (2603:10b6:208:30c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14; Tue, 26 Oct 2021 15:03:09 +0000 Received: from BLAPR10MB5138.namprd10.prod.outlook.com ([fe80::9418:7fcf:86ec:e0f4]) by BLAPR10MB5138.namprd10.prod.outlook.com ([fe80::9418:7fcf:86ec:e0f4%6]) with mapi id 15.20.4628.020; Tue, 26 Oct 2021 15:03:09 +0000 From: Darren Kenny To: grub-devel@gnu.org Cc: daniel.kiper@oracle.com, darren.kenny@oracle.com Subject: [PATCH 0/6] Fix some Coverity low-hanging bugs Date: Tue, 26 Oct 2021 15:02:34 +0000 Message-Id: X-Mailer: git-send-email 2.27.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: SA0PR11CA0195.namprd11.prod.outlook.com (2603:10b6:806:1bc::20) To BLAPR10MB5138.namprd10.prod.outlook.com (2603:10b6:208:322::8) MIME-Version: 1.0 Received: from darrenk-20210928-1216.osdevelopm1lhr.oraclevcn.com (141.143.213.44) by SA0PR11CA0195.namprd11.prod.outlook.com (2603:10b6:806:1bc::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.13 via Frontend Transport; Tue, 26 Oct 2021 15:03:08 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6e258be1-ab3a-4f09-a194-08d99891b8f2 X-MS-TrafficTypeDiagnostic: BLAPR10MB5234: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2RT0Sk7/hok8JdW2d1Gk3vPx+8MZQG6jrntNzEyfe/cmPJMae4UhsSA1oiK8BmTfms2E2obsx9RgWy5+Rbtg0JyDSil9qx1cWE87PTxuRoaUg0DgMTjRCTsgUa1L2Qx5t0UWcWo/xvbiB+Q9TKgShwaUDpMLhhn/v/dHJAoVgjrdmC+JwBvpfL1LAOv/o/Oy4hWEo7GCWRz4CYnnuK+x+kxrILX3mYxI9fmPk7hDFgwrfuvoCFuJFhIihrjUf04cPNfox83FGFAWTH7NDHs9TJ0HSm8bWn/g57KcmekCiHyZiWe5HM5D736dQPsgqSOt16EARfIEf+eIaHJW7JWo3O9W7EU/cozMHAFslTo4iAs5QAJckq9CWtn9+DRM4uu0KZ4WHDffi28f2Uir+r7VjGFXAEFTaFpYASLzmzjtnu9zG7SGzeJYU1hIi/TkTbulpHPr23xK7xzIYkN0L8zUryrWIR1LNQoQ0qXY6dkg/fBnR6EY/cct+/XOk1G8SSuruJk3VXMsdUnn6SeSBz+z4F5D1eC7L0tXETcGZ4Ng4J7MklepY4Tqc7rGhITmb/CkuM5SaAdynQb6GOj+YyUTUtIhy0o23phsaLtaDWinvYyIbC9HrUD4bLplaGX5EUPhb9TWMNwVbWiioni9v0J1RUm6GglsvIm7oM6uFibUrCGXsc3tB3qtLCS6nliqGNaQ2o8MJLzkbf1U5tMzl37cag== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BLAPR10MB5138.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(36756003)(2906002)(6666004)(83380400001)(52116002)(26005)(956004)(6506007)(2616005)(86362001)(44832011)(316002)(6512007)(6916009)(186003)(66946007)(66476007)(66556008)(38100700002)(4326008)(8936002)(107886003)(6486002)(8676002)(5660300002)(508600001)(38350700002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?QAY9QiODJFkQNT8qmLs0ohy0G0j/svMNo+BOMkR7G8lzXqcHrMqxXLWYFVVu?= =?us-ascii?Q?oOeQ5c7Hr1Wfuc03fP1lRvqSLUBWKbeiKuS/rnIYYBv0bm/9AaHfWcbFIcJF?= =?us-ascii?Q?SZ5KKxbjXMtQ2f1OScR6cFHATMa3ePEU+xtuhfOimXGvDXMmofk3AVu8HLRh?= =?us-ascii?Q?1WoeFOW+uWOwekIKQ2w/7BP4wfBLV5nX1foBO3AT8pAbEuBpNTf5SVmRfLLW?= =?us-ascii?Q?n2650FV0GX8GgPtQ8Z1TJgiTM8vfvWCkcwCmQOc0EaSCI2dQnzuA1Tq+B7QH?= =?us-ascii?Q?6Z4bD/gviAIqa4lzSdJZLdPIInqr9ns4AwkRog3nUZsDumQ6ymw4n4zHUrle?= =?us-ascii?Q?SW56W81ykBqTSTZkYWfgozooobnAfTXSJm6niujatk2Sr1v8tMEJ6DrDNJ5z?= =?us-ascii?Q?SE0zylnKqIPmirjWcHOK4F98m6oCc9GeP5ZU/A8unblDWN1zAEDbHSRD0zNV?= =?us-ascii?Q?/jLmIuG9nhC9rWiEgv9nMvtqXTdtJ6Pstu5te0zEsDaHdkbj5mfoSuYI5teR?= =?us-ascii?Q?CYVx1cYIgRX6eIvRE5crd5yGiEErk3A6MCBa4KH60+Q9COqksqziYN/xKTBy?= =?us-ascii?Q?OYAmBFxslt0SyZsR84oUSg7H8IR85AFto5BwbqzFW3BMACjBCHBaypktuuPU?= =?us-ascii?Q?VJ2LewMth/IhdoF3OEs8YJlMSB93zeSJnDdGwG+gRxV3rkOoLe0RVh6zA4Zk?= =?us-ascii?Q?zCHUMw6WgvR0N+EGxWQCJIfuNHToHdWZVFTNRQB7//F+/BtneeM+5UMGduCj?= =?us-ascii?Q?NL7UvnMxn1epJtNbMb0CZ+p1gED8NZCfzaX9yhsMyjsO1Q2oZrN2Z7d3c/to?= =?us-ascii?Q?tnDvKP7bHZNUSQBUtI7BeQSNbcBgQO45R3mBqwBkt+1mB3MI7EUEutZ31E23?= =?us-ascii?Q?+cK7RS+RfLrbR/Uwl5ZN304lSzDqr209W5rHToCRSbViz/0vEkoyzWUTUyBs?= =?us-ascii?Q?822uw5uSRrxmb1XO0tN4fOw81S16//7piiAT8a20PqKnLb8w4BJViT8FAFdB?= =?us-ascii?Q?tO3NaUbGmv15v94hpZeQqFaj+jP69SPjaT1snHuXUFMcISbgTTZfY6JdRe/W?= =?us-ascii?Q?m85F9JlDEIJD3rhhbzfxuL4WB17K1wHKUxAL7fHDSqkmOfDHXztDg/rNgXUh?= =?us-ascii?Q?AtEIF+XXTVEPASA61b1bchIWXo6/invlEmi92BEwQlF3asqGcn30bi/Jc7jK?= =?us-ascii?Q?q24Gc/0sTmdiVo2cqlMRpYDcDtJJOQt0TA2O50/Jb7KacxGMnT/3Awi7sDbg?= =?us-ascii?Q?/+s47B4dyJ2j6XJYhToSx2090iahfmS4OFd2NP7MZsByTuSOrL+8AD3IWqBJ?= =?us-ascii?Q?pqofLPqu/LwTij1UrNntIxcpbOdbJMfHFAuEOzo4jPCCMqL0T6ZavyyNuCeO?= =?us-ascii?Q?e+2P0VkiZ08GQ5FU3rxNiTKO60D+lkGV8ED1Kw99vpmTzt6TiP52+d67M/kT?= =?us-ascii?Q?bWiB8aKBEC7i7LWkoY9Na82WWyGXdvB0hvMb417osKt1YL4rZPws5DQbDGE5?= =?us-ascii?Q?s1xeyPg+TpGwp6yVX7Oa3Eh0Pal4ipVrUdHM97vgrCmVuiSZTwOtJdvthW3W?= =?us-ascii?Q?5g7mruEkebpsuVKmPbCU7pU87/lt5neW1y8RXFAlJYOP4JISbN0hg5qbmlwG?= =?us-ascii?Q?oUriJLsYXPYC3E9yYeAnBTY=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6e258be1-ab3a-4f09-a194-08d99891b8f2 X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5138.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2021 15:03:09.2633 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8oLBECfQStk/rgOykUzbz5uFLFSCH2i8XQ5KU/RNRo4C5DU5IEzUWK2MvixCf5BGpf1KKg6Q7GTnIy8d52rlKA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5234 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10149 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxlogscore=999 bulkscore=0 phishscore=0 mlxscore=0 spamscore=0 adultscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2110260085 X-Proofpoint-GUID: O1uBf9yxHaE2v4UUwCgxuUwpQlsIbBro X-Proofpoint-ORIG-GUID: O1uBf9yxHaE2v4UUwCgxuUwpQlsIbBro Received-SPF: pass client-ip=205.220.165.32; envelope-from=darren.kenny@oracle.com; helo=mx0a-00069f02.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Oct 2021 15:39:44 -0000 Coverity has flagged a number of small issues that should be fixed to help in cleaning up the code - these here are primarily memory leaks or uninitialized variables. In theory leaked memory is significant, but for short-lived processes it is minor. Similarly for unitinialized variables - some compilers will do the right thing and zero out the value allocated on the stack, but some won't. So it is better to be sure of the content that leave it open for possible misuse. Darren Kenny (6): grub-install-common: Fix memory leak in copy_all() grub-mkrescue: Fix memory leak in write_part() grub-fstest: Fix resource leaks in cmd_cmp() grub-mkfont: Fix memory leak in write_font_pf2() zfs: Fix possible insecure use of chunk size in zap_leaf_array_get() gzio: Fix possible use of uninitialized variable in huft_build() grub-core/fs/zfs/zfs.c | 3 ++- grub-core/io/gzio.c | 2 +- util/grub-fstest.c | 7 ++++++- util/grub-install-common.c | 4 +++- util/grub-mkfont.c | 1 + util/grub-mkrescue.c | 1 + 6 files changed, 14 insertions(+), 4 deletions(-) -- 2.27.0