From: Paolo Abeni <pabeni@redhat.com>
To: netdev@vger.kernel.org
Cc: mptcp@lists.linux.dev, Eric Dumazet <edumazet@google.com>
Subject: [PATCH net 0/2] mptcp: fix 3rd ack rtx timer
Date: Fri, 19 Nov 2021 15:27:53 +0100 [thread overview]
Message-ID: <cover.1637331462.git.pabeni@redhat.com> (raw)
Eric noted that the MPTCP code do the wrong thing to schedule
the MPJ 3rd ack timer. He also provided a patch to address the
issues (patch 1/2).
To fix for good the MPJ 3rd ack retransmission timer, we additionally
need to set it after the current ack is transmitted (patch 2/2)
Note that the bug went unnotice so far because all the related
tests required some running data transfer, and that causes
MPTCP-level ack even on the opening MPJ subflow. We now have
explicit packet drill coverage for this code path.
Eric Dumazet (1):
mptcp: fix delack timer
Paolo Abeni (1):
mptcp: use delegate action to schedule 3rd ack retrans
net/mptcp/options.c | 32 ++++++++-------------------
net/mptcp/protocol.c | 51 ++++++++++++++++++++++++++++++++++++--------
net/mptcp/protocol.h | 17 ++++++++-------
3 files changed, 60 insertions(+), 40 deletions(-)
--
2.33.1
next reply other threads:[~2021-11-19 14:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-19 14:27 Paolo Abeni [this message]
2021-11-19 14:27 ` [PATCH net 1/2] mptcp: fix delack timer Paolo Abeni
2021-11-19 14:27 ` [PATCH net 2/2] mptcp: use delegate action to schedule 3rd ack retrans Paolo Abeni
2021-11-19 15:46 ` [PATCH net 0/2] mptcp: fix 3rd ack rtx timer David Miller
2021-11-20 14:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1637331462.git.pabeni@redhat.com \
--to=pabeni@redhat.com \
--cc=edumazet@google.com \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.