From: Glenn Washburn <development@efficientek.com>
To: Daniel Kiper <dkiper@net-space.pl>, grub-devel@gnu.org
Cc: Glenn Washburn <development@efficientek.com>
Subject: [PATCH 0/2] Fix a couple issues in moddep parsing
Date: Wed, 12 Jan 2022 20:54:59 -0600 [thread overview]
Message-ID: <cover.1642042033.git.development@efficientek.com> (raw)
The first patch fixes an OOB read bug and the second outputs a less confusing
error to the user when the moddep.lst line is too long. Really it would be
better to support lines of unlimited length, but I'm not motivated to add that.
The condition under which these issues are triggered should never really happen
because no module (currently) has enough dependencies to generate such long
lines in moddep.lst. I was triggering this under some odd conditions where
the all_video module dependency line contained all grub modules. So I think
having a max length for moddep.lst lines is reasonable at this point.
Glenn
Glenn Washburn (2):
util/resolve.c: Do not read past the end of the array in read_dep_list
util/resolve.c: Bail with error if moddep lst file line is too long
util/resolve.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
--
2.27.0
next reply other threads:[~2022-01-13 2:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-13 2:54 Glenn Washburn [this message]
2022-01-13 2:55 ` [PATCH 1/2] util/resolve.c: Do not read past the end of the array in read_dep_list Glenn Washburn
2022-01-13 2:55 ` [PATCH 2/2] util/resolve.c: Bail with error if moddep lst file line is too long Glenn Washburn
2022-02-08 16:07 ` Daniel Kiper
2022-01-14 15:06 ` [PATCH 0/2] Fix a couple issues in moddep parsing Daniel Kiper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1642042033.git.development@efficientek.com \
--to=development@efficientek.com \
--cc=dkiper@net-space.pl \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.