From: Ritesh Harjani <riteshh@linux.ibm.com>
To: linux-ext4@vger.kernel.org
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Jan Kara <jack@suse.com>,
Andreas Dilger <adilger.kernel@dilger.ca>,
tytso@mit.edu, Eric Whitney <enwlinux@gmail.com>,
Ritesh Harjani <riteshh@linux.ibm.com>
Subject: [PATCHv2 0/5] ext4/jbd2: inline_data fixes and minor cleanups
Date: Mon, 17 Jan 2022 17:41:46 +0530 [thread overview]
Message-ID: <cover.1642416995.git.riteshh@linux.ibm.com> (raw)
Hello,
Please find v2 of the inline_data fixes and some minor cleanups found during
code review.
I have dropped patch-6 in v2 which was removing use of t_handle_lock (spinlock)
from within jbd2_journal_wait_updates(). Based on Jan comments, I feel we can
push that as killing of t_handle_lock into a separate series (which will be on
top of this).
v1 -> v2
========
1. Added Jan's Reviewed-by tag & addressed one of his comment on no need to make
jbd2_journal_wait_updates() function inline.
2. Dropped patch-6 as described above.
Description
============
Patch[1]: fixes BUG_ON with inline_data which was reported [1] with generic/475.
Patch[2]: is mostly cleanup found during code review of inline_data code.
Patch[3]: is a possible memory corruption fix in case of krealloc failure.
Patch[4-5]: Cleanups.
[v1]: https://lore.kernel.org/linux-ext4/cover.1642044249.git.riteshh@linux.ibm.com/T/
Ritesh Harjani (5):
ext4: Fix error handling in ext4_restore_inline_data()
ext4: Remove redundant max inline_size check in ext4_da_write_inline_data_begin()
ext4: Fix error handling in ext4_fc_record_modified_inode()
jbd2: Cleanup unused functions declarations from jbd2.h
jbd2: Refactor wait logic for transaction updates into a common function
fs/ext4/fast_commit.c | 64 ++++++++++++++++++++-----------------------
fs/ext4/inline.c | 23 +++++++++-------
fs/jbd2/commit.c | 19 ++-----------
fs/jbd2/transaction.c | 53 +++++++++++++++++++++--------------
include/linux/jbd2.h | 11 ++------
5 files changed, 80 insertions(+), 90 deletions(-)
--
2.31.1
next reply other threads:[~2022-01-17 12:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-17 12:11 Ritesh Harjani [this message]
2022-01-17 12:11 ` [PATCHv2 1/5] ext4: Fix error handling in ext4_restore_inline_data() Ritesh Harjani
2022-01-17 12:11 ` [PATCHv2 2/5] ext4: Remove redundant max inline_size check in ext4_da_write_inline_data_begin() Ritesh Harjani
2022-01-17 12:11 ` [PATCHv2 3/5] ext4: Fix error handling in ext4_fc_record_modified_inode() Ritesh Harjani
2022-01-17 12:11 ` [PATCHv2 4/5] jbd2: Cleanup unused functions declarations from jbd2.h Ritesh Harjani
2022-01-17 12:11 ` [PATCHv2 5/5] jbd2: Refactor wait logic for transaction updates into a common function Ritesh Harjani
2022-01-20 15:58 ` [PATCHv2 0/5] ext4/jbd2: inline_data fixes and minor cleanups Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1642416995.git.riteshh@linux.ibm.com \
--to=riteshh@linux.ibm.com \
--cc=adilger.kernel@dilger.ca \
--cc=enwlinux@gmail.com \
--cc=jack@suse.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.