From: Geliang Tang <geliang.tang@suse.com>
To: mptcp@lists.linux.dev
Cc: Geliang Tang <geliang.tang@suse.com>
Subject: [PATCH mptcp-next 0/4] reflect mptcp_pm_add_addr_signal
Date: Tue, 8 Feb 2022 19:16:04 +0800 [thread overview]
Message-ID: <cover.1644318561.git.geliang.tang@suse.com> (raw)
mptcp_pm_add_addr_signal() has too many parameters right now. This issue
was introduced by me and I promised to fix it last year:
https://patchwork.kernel.org/project/mptcp/patch/f0920ba1126ff81aa1acbff47e805e5573c64abc.1626158123.git.geliangtang@gmail.com/
This patch set reflected this function and dropped the port and echo
parameters.
As defined in $3.4.1:
1 2 3
0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1
+---------------+---------------+-------+-------+---------------+
| Kind | Length |Subtype|(rsv)|E| Address ID |
+---------------+---------------+-------+-------+---------------+
| Address (IPv4: 4 octets / IPv6: 16 octets) |
+-------------------------------+-------------------------------+
| Port (2 octets, optional) | |
+-------------------------------+ |
| Truncated HMAC (8 octets, if E=0) |
| +-------------------------------+
| |
+-------------------------------+
The echo bit is one of the important properties of a MPTCP address. It
makes sense to put it into struct mptcp_addr_info with others properties
like the address family, the id number and the port number too. So patch
2 added the echo bit in struct mptcp_addr_info. With this change, we can
drop the echo parameter of mptcp_pm_announce_addr too, or even drop the
addr_signal status MPTCP_ADD_ADDR_ECHO later (not finish yet).
Geliang Tang (4):
mptcp: drop port parameter of mptcp_pm_add_addr_signal
mptcp: add echo bit in mptcp_addr_info
mptcp: drop echo parameter of mptcp_pm_add_addr_signal
mptcp: drop echo parameter of mptcp_pm_announce_addr
include/net/mptcp.h | 3 ++-
net/mptcp/options.c | 26 +++++++++++++-------------
net/mptcp/pm.c | 29 +++++++++++++++--------------
net/mptcp/pm_netlink.c | 6 +++---
net/mptcp/protocol.h | 8 +++-----
5 files changed, 36 insertions(+), 36 deletions(-)
--
2.34.1
next reply other threads:[~2022-02-08 11:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-08 11:16 Geliang Tang [this message]
2022-02-08 11:16 ` [PATCH mptcp-next 1/4] mptcp: drop port parameter of mptcp_pm_add_addr_signal Geliang Tang
2022-02-09 1:20 ` Mat Martineau
2022-02-09 11:38 ` Matthieu Baerts
2022-02-08 11:16 ` [PATCH mptcp-next 2/4] mptcp: add echo bit in mptcp_addr_info Geliang Tang
2022-02-09 1:24 ` Mat Martineau
2022-02-08 11:16 ` [PATCH mptcp-next 3/4] mptcp: drop echo parameter of mptcp_pm_add_addr_signal Geliang Tang
2022-02-08 11:16 ` [PATCH mptcp-next 4/4] mptcp: drop echo parameter of mptcp_pm_announce_addr Geliang Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1644318561.git.geliang.tang@suse.com \
--to=geliang.tang@suse.com \
--cc=mptcp@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.