From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5491C2F25 for ; Wed, 9 Feb 2022 09:47:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1644400061; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Swfv2++8vXMnskIm0NSkTMkW/0JaaP+Usk+gMwJvmd0=; b=bI+4SObhFWLma3IFp0dgl7z+wQEzn7cWKKZ1jpKQSeSlO0CTenyF7dV5h1p5Vpb/TXAuUq 7nRG/DCoGJ1eVb92czSIYa0hdtXorZ0dF1pwA2Xvjh6I3XMJHR7qmm53NP0cQVvG2TxO/d Q1Zd4e0O3i9nohRrj2oqZa59b7ZBfdo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-392-eYWliLqbO82AOfqZND8xWg-1; Wed, 09 Feb 2022 04:47:38 -0500 X-MC-Unique: eYWliLqbO82AOfqZND8xWg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 908FC5AB6 for ; Wed, 9 Feb 2022 09:47:37 +0000 (UTC) Received: from gerbillo.redhat.com (unknown [10.39.193.181]) by smtp.corp.redhat.com (Postfix) with ESMTP id 00763E2C6 for ; Wed, 9 Feb 2022 09:47:36 +0000 (UTC) From: Paolo Abeni To: mptcp@lists.linux.dev Subject: [PATCH mptcp-net v3 0/4] mptcp: fix races in add_addr handling Date: Wed, 9 Feb 2022 10:47:29 +0100 Message-Id: Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pabeni@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" the patches 1 && 2 fix actual races, even if the race addressed by 2/4 is not exposed by the self-tests, afaics. patch 3 introduces some mibs to detect critical scenarios we can't fix without major rework patch 4 updates the self-test to be graceful in above cases. Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/254 Note: I did not attach the above tag to a specific patch, as all of them will be needed to fix the issue v2 -> v3: - fix missing init in patch 2/4 Paolo Abeni (4): mptcp: fix race in overlapping signal events mptcp: fix race in incoming ADD_ADDR option processing. mptcp: add mibs counter for ignored incoming options selftests: mptcp: more robust signal race test net/mptcp/mib.c | 2 ++ net/mptcp/mib.h | 2 ++ net/mptcp/pm.c | 8 +++-- net/mptcp/pm_netlink.c | 29 +++++++++++++++---- .../testing/selftests/net/mptcp/mptcp_join.sh | 16 ++++++++-- 5 files changed, 47 insertions(+), 10 deletions(-) -- 2.34.1