From: Glenn Washburn <development@efficientek.com>
To: grub-devel@gnu.org, Daniel Kiper <dkiper@net-space.pl>
Cc: Glenn Washburn <development@efficientek.com>
Subject: [PATCH 0/4] Miscellaneous fixes/improvements
Date: Wed, 11 May 2022 22:19:43 -0500 [thread overview]
Message-ID: <cover.1652325160.git.development@efficientek.com> (raw)
Patch #1: When the HFS UUID test fails it shows two GRUB generated outputs.
There should be one GRUB output and one host system output, like the other
filesystems output. In this case it should show the host generated HFS UUID
which is not matching with the GRUB generated one.
Patch #2: If tests are run as non-root user, /sbin and /usr/sbin are usually
not in the path, which will cause the partmap test to fail because it can
not find parted (in /usr/sbin on Debian). However, this test does not require
root privileges to run successfully, so add those paths to the PATH to allow
partmap to successfully run as a non-root user.
Patch #3: I believe the policy is that invocations of the N_ macro should
have no whitespace before the '('. This fixes that in a couple invocations.
Patch #4: The crypto and cryptodisk headers are not needed by the probe user
space utility (maybe they were at one time?). So remove them.
Glenn
Glenn Washburn (4):
tests: Show host determined fs UUID when hfs UUID test fails
tests: Add /sbin and /usr/sbin to path in partmap test
formatting: Remove whitespace between N_ macro and open parenthesis
util/probe.c: Remove unused header includes
grub-core/commands/macbless.c | 6 ++----
tests/partmap_test.in | 2 ++
tests/util/grub-fs-tester.in | 2 +-
util/probe.c | 2 --
4 files changed, 5 insertions(+), 7 deletions(-)
--
2.34.1
next reply other threads:[~2022-05-12 3:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-12 3:19 Glenn Washburn [this message]
2022-05-12 3:19 ` [PATCH 1/4] tests: Show host determined fs UUID when hfs UUID test fails Glenn Washburn
2022-05-27 14:16 ` Daniel Kiper
2022-05-27 18:39 ` Glenn Washburn
2022-05-27 21:42 ` Daniel Kiper
2022-05-12 3:19 ` [PATCH 2/4] tests: Add /sbin and /usr/sbin to path in partmap test Glenn Washburn
2022-05-12 3:19 ` [PATCH 3/4] formatting: Remove whitespace between N_ macro and open parenthesis Glenn Washburn
2022-05-12 3:19 ` [PATCH 4/4] util/probe.c: Remove unused header includes Glenn Washburn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1652325160.git.development@efficientek.com \
--to=development@efficientek.com \
--cc=dkiper@net-space.pl \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.