From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 506117E for ; Mon, 6 Jun 2022 19:36:52 +0000 (UTC) Received: by mail-lf1-f50.google.com with SMTP id a2so24928961lfc.2 for ; Mon, 06 Jun 2022 12:36:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ocE4xdI2Ps5J5GJU8d4YixiKjR69pIIldx4ffv9ni2c=; b=dSgm0J+kU8mOPlOycUV4NGLJBqwoFt1vRSHeQmhgpBNK2dFapFO7pjvXtv3708T7zn 0dx8XJFjcHy2H8tYq0aB/f49XzmWbEkCABFK4GqxnSxs4fRx3NRufQiU5VW1YIOKiX/H 9imtXgzpzHAGMm6+n3uhhWvFDDAVfRJfpVzubECh8u1BIg2KayMX8SWrTtqaEJOviJy4 XkmOl7bJ24r7OmrisaRblYC+PHBgPgPgqmrCq8yp41mze3qLSu6kDQyVSCWLSU2eXpl2 JKhZaKJ7T993IKlQ2ryNqGxSU05rG4V56rW8SmkFHc+ai/AtsJv3Tz0aaWN8dRbl4/zk UpCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ocE4xdI2Ps5J5GJU8d4YixiKjR69pIIldx4ffv9ni2c=; b=aEIxCWm7Xrx5acla+4g7cMtrQM5PU+Sapw/DJP1AM66cozIW27ToWmboFpi33+fbSV oC76r6qAJ+yg4H8oWNqL0skcpXkU6dgHuCphOT7nEXbDv1kdCDE2j+99EDnbJpV31Q2z W8TBSaaFM0q4gZwCTmvj3KTIDV4BeUfqGcEiHFqC/ILpNPblduLVfxhrDhCB1FU7EGsS FnrmOYgICMbupPwR8qn+7s9bcw/5Z0VErrQjbvJgIOeK7rIFLyJtOmuLT7+eXh1g7GF4 28MjTxvwYSW2W5T8FT6R30XOVk8KbM/3RAp3j42lql66uH9sClrZw4cRO0Yd406ihE0R J3eg== X-Gm-Message-State: AOAM531z4k16xwRgyxUFoFRWaQ980D15zfFqGaNaMf2t+pY3nPgGDvlv U2dqoG0fEAyNUDxcQWrDduc= X-Google-Smtp-Source: ABdhPJxCSp/6uMa99wsCN0iUq6WWebYMaS87eW+3AfWRWIRd4tPDAvfHnLN4enGA4KhzlO/FAFt/KA== X-Received: by 2002:a05:6512:c07:b0:479:2e0f:9a06 with SMTP id z7-20020a0565120c0700b004792e0f9a06mr7626550lfu.687.1654544210301; Mon, 06 Jun 2022 12:36:50 -0700 (PDT) Received: from localhost.localdomain ([94.103.229.27]) by smtp.gmail.com with ESMTPSA id l10-20020a056512110a00b004791c4858e0sm1656662lfg.114.2022.06.06.12.36.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jun 2022 12:36:49 -0700 (PDT) From: Pavel Skripkin To: gregkh@linuxfoundation.org, Larry.Finger@lwfinger.net, phil@philpotter.co.uk, straube.linux@gmail.com, dan.carpenter@oracle.com Cc: linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, Pavel Skripkin Subject: [PATCH v3 0/4] staging: r8188eu: add error handling of usb read errors Date: Mon, 6 Jun 2022 22:36:46 +0300 Message-Id: X-Mailer: git-send-email 2.36.1 Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi, it's reincarnation of my old series for adding sane error handling in r8818eu. *Problem* Old code was returning just stack variable in case of read error. It's not the best approach, since passing around stack data might cause device misconfiguration or even kernel data leakage To solve this I've changed rtw_read{8,16,32} prototypes to return an error via return value and data via passed pointer. Some work should be done to propogate an error down to calltrace, but it's good way to at least start doing sane I/O error handling Tested locally on qemu with TP-Link TL-WN722N v2/v3 [Realtek RTL8188EUS] device. More testing is welcomed, of course :) _NOTE_ Series is based on top of staging-testing branch. Changes since v2: get rid of `(void)res` and return an error from function instead of hiding it Changes since v1: addresses issues found by Dan and self review. Mostly related to returning _FAIL instead of -errno, since callers expect _FAIL/_SUCCESS v1: https://lore.kernel.org/linux-staging/cover.1652911343.git.paskripkin@gmail.com/ v2: https://lore.kernel.org/linux-staging/cover.1652994483.git.paskripkin@gmail.com/ Pavel Skripkin (4): staging: r8188eu: add error handling of rtw_read8 staging: r8188eu: add error handling of rtw_read16 staging: r8188eu: add error handling of rtw_read32 MAINTAINERS: add myself as r8188eu reviewer MAINTAINERS | 1 + drivers/staging/r8188eu/core/rtw_cmd.c | 15 +- drivers/staging/r8188eu/core/rtw_efuse.c | 33 ++- drivers/staging/r8188eu/core/rtw_fw.c | 72 +++-- drivers/staging/r8188eu/core/rtw_led.c | 16 +- drivers/staging/r8188eu/core/rtw_mlme_ext.c | 62 ++++- drivers/staging/r8188eu/core/rtw_pwrctrl.c | 9 +- drivers/staging/r8188eu/core/rtw_wlan_util.c | 20 +- .../r8188eu/hal/Hal8188ERateAdaptive.c | 21 +- drivers/staging/r8188eu/hal/HalPhyRf_8188e.c | 21 +- drivers/staging/r8188eu/hal/HalPwrSeqCmd.c | 9 +- drivers/staging/r8188eu/hal/hal_com.c | 27 +- drivers/staging/r8188eu/hal/rtl8188e_cmd.c | 37 ++- drivers/staging/r8188eu/hal/rtl8188e_dm.c | 6 +- .../staging/r8188eu/hal/rtl8188e_hal_init.c | 136 +++++++--- drivers/staging/r8188eu/hal/rtl8188e_phycfg.c | 30 ++- drivers/staging/r8188eu/hal/usb_halinit.c | 251 +++++++++++++++--- drivers/staging/r8188eu/hal/usb_ops_linux.c | 33 ++- drivers/staging/r8188eu/include/rtw_io.h | 6 +- drivers/staging/r8188eu/os_dep/ioctl_linux.c | 47 +++- drivers/staging/r8188eu/os_dep/os_intfs.c | 19 +- 21 files changed, 693 insertions(+), 178 deletions(-) -- 2.36.1