All of lore.kernel.org
 help / color / mirror / Atom feed
From: Darren Kenny <darren.kenny@oracle.com>
To: grub-devel@gnu.org
Cc: daniel.kiper@oracle.com, darren.kenny@oracle.com
Subject: [PATCH 0/1] Fix clang build, partially
Date: Tue, 14 Jun 2022 13:35:43 +0000	[thread overview]
Message-ID: <cover.1655213266.git.darren.kenny@oracle.com> (raw)

To fix the build with clang, there are 2 parts needed, the first is to get a
fix back into gnulib to ensure that the regex code can build, that has been
submitted upstream and can be pulled in later since there is now a preference
not to have patches held in GRUB's own sources but fix upstream.

But even with that fix, GRUB won't build, and that is because Clang replaces
the 'abort()' call with '__builtin_trap', but the abort call is surrounded by
an EXPORT_FUNC(), which is valid for GCC.

The core of the issue is that the gensymlist script should be filtering out
any call starting with '__builtin_', so this patch will add that filter.

Thanks,

Darren.

Darren Kenny (1):
  gensymlist: fix clang build with exporting of __builtin_trap

 grub-core/gensymlist.sh | 1 +
 1 file changed, 1 insertion(+)

-- 
2.31.1



             reply	other threads:[~2022-06-14 13:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-14 13:35 Darren Kenny [this message]
2022-06-14 13:35 ` [PATCH 1/1] gensymlist: fix clang build with exporting of __builtin_trap Darren Kenny
2022-06-14 16:24   ` Vladimir 'phcoder' Serbinenko
2022-06-14 16:55   ` Vladimir 'phcoder' Serbinenko
2022-06-14 18:18     ` Glenn Washburn
2022-07-28 14:29       ` Darren Kenny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1655213266.git.darren.kenny@oracle.com \
    --to=darren.kenny@oracle.com \
    --cc=daniel.kiper@oracle.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.