From: Josef Bacik <josef@toxicpanda.com>
To: linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: [PATCH 0/5] btrfs: block group cleanups
Date: Wed, 13 Jul 2022 20:34:04 -0400 [thread overview]
Message-ID: <cover.1657758678.git.josef@toxicpanda.com> (raw)
I'm reworking our relocation and delete unused block group workqueues which
require some cleanups of how we deal with flags on the block group. We've had a
bit field for various flags on the block group for a while, but there's a subtle
gotcha with this bitfield in that you have to protect every modification with
bg->lock in order to not mess with the values, and there were a few places that
we weren't holding the lock.
Rework these to be normal flags, and then go behind this conversion and cleanup
some of the usage of the different flags. Additionally there's a cleanup around
when to break out of the background workers. Thanks,
Josef
Josef Bacik (5):
btrfs: use btrfs_fs_closing for background bg work
btrfs: convert block group bit field to use bit helpers
btrfs: remove block_group->lock protection for TO_COPY
btrfs: simplify btrfs_put_block_group_cache
btrfs: remove BLOCK_GROUP_FLAG_HAS_CACHING_CTL
fs/btrfs/block-group.c | 95 ++++++++++++++++---------------------
fs/btrfs/block-group.h | 19 ++++----
fs/btrfs/dev-replace.c | 11 ++---
fs/btrfs/extent-tree.c | 7 ++-
fs/btrfs/free-space-cache.c | 18 +++----
fs/btrfs/scrub.c | 16 +++----
fs/btrfs/volumes.c | 13 +++--
fs/btrfs/zoned.c | 30 ++++++++----
8 files changed, 103 insertions(+), 106 deletions(-)
--
2.26.3
next reply other threads:[~2022-07-14 0:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-14 0:34 Josef Bacik [this message]
2022-07-14 0:34 ` [PATCH 1/5] btrfs: use btrfs_fs_closing for background bg work Josef Bacik
2022-07-14 7:18 ` Johannes Thumshirn
2022-07-14 0:34 ` [PATCH 2/5] btrfs: convert block group bit field to use bit helpers Josef Bacik
2022-07-14 7:21 ` Johannes Thumshirn
2022-07-14 22:40 ` kernel test robot
2022-07-14 0:34 ` [PATCH 3/5] btrfs: remove block_group->lock protection for TO_COPY Josef Bacik
2022-07-14 7:23 ` Johannes Thumshirn
2022-07-14 0:34 ` [PATCH 4/5] btrfs: simplify btrfs_put_block_group_cache Josef Bacik
2022-07-14 9:04 ` Johannes Thumshirn
2022-07-14 0:34 ` [PATCH 5/5] btrfs: remove BLOCK_GROUP_FLAG_HAS_CACHING_CTL Josef Bacik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1657758678.git.josef@toxicpanda.com \
--to=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.