All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kangjie Xu <kangjie.xu@linux.alibaba.com>
To: qemu-devel@nongnu.org
Cc: mst@redhat.com, jasowang@redhat.com, arei.gonglei@huawei.com,
	hengqi@linux.alibaba.com, xuanzhuo@linux.alibaba.com
Subject: [PATCH 0/8] Support VIRTIO_F_RING_RESET for vhost-user in virtio pci-modern
Date: Fri, 26 Aug 2022 18:56:12 +0800	[thread overview]
Message-ID: <cover.1661510725.git.kangjie.xu@linux.alibaba.com> (raw)

This patch set is based on the patch set that supports VIRTIO_F_RING_RESET for vhost-kernel:
    https://lore.kernel.org/qemu-devel/cover.1661414345.git.kangjie.xu@linux.alibaba.com/T/

The virtio queue reset function has already been defined in the virtio spec 1.2.
The relevant virtio spec information is here:

    https://github.com/oasis-tcs/virtio-spec/issues/124
    https://github.com/oasis-tcs/virtio-spec/issues/139

This patch set is to support this function for vhost-user in QEMU. It consists of several parts:
Patch 1: docs about vhost-user message VHOST_USER_RESET_VRING.
Patch 2: rename vhost_set_vring_enable to vhost_set_dev_enable.
Patches 3-4: support in vhost-user module.
Patches 5-6: support in vhost-net module.
Patch 7: support in virtio-net module.
Patch 8: add feature negotitation support.

The process of virtqueue reset can be concluded as:
1. The virtqueue is disabled when VIRTIO_PCI_COMMON_Q_RESET is written.
2. Then the virtqueue can be optionally restarted(re-enabled).

The detailed process is listed below:
1. VIRTIO_PCI_COMMON_Q_RESET is written [virtio-pci]
    -> virtio_queue_reset() [virtio]
        -> virtio_net_queue_reset() [virtio-net]
            -> vhost_net_virtqueue_reset() [vhost-net]
                -> vhost_user_reset_vring() [vhost-user]
                    -> send VHOST_USER_RESET_VRING to the device
                -> vhost_virtqueue_unmap()
        -> __virtio_queue_reset()
2. VIRTIO_PCI_COMMON_Q_ENABLE is written [virtio-pci]
    -> virtio_queue_enable() [virtio]
        -> virtio_net_queue_enable() [virtio-net]
            -> vhost_net_virtqueue_restart() [vhost-net]
                -> vhost_virtqueue_start()
                -> vhost_user_set_vring_enable [vhost-user]
                    -> send VHOST_USER_SET_VRING_ENABLE to the device
    -> set enabled, reset status of vq.

Test environment:
    Qemu: QEMU emulator version 7.0.50
    Guest: 5.19.0-rc3 (With vq reset support)
    DPDK: 22.07-rc1 (With vq reset support)
    Test Cmd: ethtool -g eth1; ethtool -G eth1 rx $1 tx $2; ethtool -g eth1;

    The drvier can resize the virtio queue, then virtio queue reset function should
    be triggered.

    The default is split mode, modify Qemu virtio-net to add PACKED feature to 
    test packed mode.

Guest Kernel Patch:
    https://lore.kernel.org/bpf/20220801063902.129329-1-xuanzhuo@linux.alibaba.com/

DPDK Patch:
    https://github.com/middaywords/dpdk/compare/72206323a5dd3182b13f61b25a64abdddfee595c...eabadfac7953da66bc10ffb8284b490d09bb7ec7

changelog:(based the series https://lore.kernel.org/qemu-devel/cover.1658141552.git.kangjie.xu@linux.alibaba.com/T/#t)
1. rename vhost_set_vring_enable to vhost_set_dev_enable.
2. add vhost-user message VHOST_USER_RESET_VRING
3. remove restart/reset functions of virtqueue in vhost module.

Kangjie Xu (8):
  docs: vhost-user: add VHOST_USER_RESET_VRING message
  net: virtio: rename vhost_set_vring_enable to vhost_set_dev_enable
  vhost-user: add op to enable or disable a single vring
  vhost-user: introduce vhost_reset_vring() interface
  vhost-net: vhost-user: update vhost_net_virtqueue_reset()
  vhost-net: vhost-user: update vhost_net_virtqueue_restart()
  virtio-net: vhost-user: update queue_reset and queue_enable
  vhost: vhost-user: enable vq reset feature

 backends/cryptodev-vhost.c        | 12 +++---
 docs/interop/vhost-user.rst       | 10 +++++
 hw/net/vhost_net-stub.c           |  2 +-
 hw/net/vhost_net.c                | 34 +++++++++++++---
 hw/net/virtio-net.c               | 10 +++--
 hw/virtio/vhost-user.c            | 68 +++++++++++++++++++++++++++----
 include/hw/virtio/vhost-backend.h |  8 +++-
 include/net/vhost_net.h           |  2 +-
 8 files changed, 119 insertions(+), 27 deletions(-)

-- 
2.32.0



             reply	other threads:[~2022-08-26 10:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-26 10:56 Kangjie Xu [this message]
2022-08-26 10:56 ` [PATCH 1/8] docs: vhost-user: add VHOST_USER_RESET_VRING message Kangjie Xu
2022-08-26 10:56 ` [PATCH 2/8] net: virtio: rename vhost_set_vring_enable to vhost_set_dev_enable Kangjie Xu
2022-08-26 10:56 ` [PATCH 3/8] vhost-user: add op to enable or disable a single vring Kangjie Xu
2022-08-26 10:56 ` [PATCH 4/8] vhost-user: introduce vhost_reset_vring() interface Kangjie Xu
2022-08-26 10:56 ` [PATCH 5/8] vhost-net: vhost-user: update vhost_net_virtqueue_reset() Kangjie Xu
2022-08-26 10:56 ` [PATCH 6/8] vhost-net: vhost-user: update vhost_net_virtqueue_restart() Kangjie Xu
2022-08-26 10:56 ` [PATCH 7/8] virtio-net: vhost-user: update queue_reset and queue_enable Kangjie Xu
2022-08-26 10:56 ` [PATCH 8/8] vhost: vhost-user: enable vq reset feature Kangjie Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1661510725.git.kangjie.xu@linux.alibaba.com \
    --to=kangjie.xu@linux.alibaba.com \
    --cc=arei.gonglei@huawei.com \
    --cc=hengqi@linux.alibaba.com \
    --cc=jasowang@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=xuanzhuo@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.