All of lore.kernel.org
 help / color / mirror / Atom feed
From: Qu Wenruo <wqu@suse.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH v2 0/3] btrfs: optimize the argument list for submit_extent_page()
Date: Tue, 13 Sep 2022 13:31:11 +0800	[thread overview]
Message-ID: <cover.1663046855.git.wqu@suse.com> (raw)

[Changelog]
v2:
- Add a patch to remove stale argument from the comments of
  submit_extent_page()

- Update the comment of submit_extent_page() to reflect the new arugment
  list

The argument list of submit_extent_page() is already a little long.

Although we have things like page, pg_len, pg_off which can not be saved
anyway, we can still improve the situation by:

- Update the stale comment of submit_extent_page()
  Done by the first patch.

- Make sure @page, @pg_len, @pg_off are always batched together
  Just like bio_add_page().

  This is done by the second page, just switching the position between
  @page and @disk_bytenr.

- Move @end_io_func arugment into btrfs_bio_ctrl structure.

Qu Wenruo (3):
  btrfs: update the comment for submit_extent_page()
  btrfs: switch the page and disk_bytenr argument position for
    submit_extent_page()
  btrfs: move end_io_func argument to btrfs_bio_ctrl structure

 fs/btrfs/extent_io.c | 66 +++++++++++++++++++++++++-------------------
 1 file changed, 37 insertions(+), 29 deletions(-)

-- 
2.37.3


             reply	other threads:[~2022-09-13  5:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-13  5:31 Qu Wenruo [this message]
2022-09-13  5:31 ` [PATCH v2 1/3] btrfs: update the comment for submit_extent_page() Qu Wenruo
2022-09-13  6:01   ` Anand Jain
2022-09-13  5:31 ` [PATCH v2 2/3] btrfs: switch the page and disk_bytenr argument position " Qu Wenruo
2022-09-13  5:31 ` [PATCH v2 3/3] btrfs: move end_io_func argument to btrfs_bio_ctrl structure Qu Wenruo
2022-09-21  9:18 ` [PATCH v2 0/3] btrfs: optimize the argument list for submit_extent_page() David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1663046855.git.wqu@suse.com \
    --to=wqu@suse.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.