All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Metzmacher <metze@samba.org>
To: linux-cifs@vger.kernel.org
Cc: Stefan Metzmacher <metze@samba.org>
Subject: [PATCH 0/2] cifs: don't send uninitialized memory to sock_{send,recv}msg()
Date: Wed, 14 Sep 2022 05:25:45 +0200	[thread overview]
Message-ID: <cover.1663125352.git.metze@samba.org> (raw)

Passing just half initialized struct msghdr variables down to
sock_{send,recv}msg() means we're waiting for a disater to happen...

I added the removal of passing the destination address to
tcp as a separate patch in order to explain it separately.

Stefan Metzmacher (2):
  cifs: don't send down the destination address to sendmsg for a
    SOCK_STREAM
  cifs: always initialize struct msghdr smb_msg completely

 fs/cifs/connect.c   | 11 +++--------
 fs/cifs/transport.c |  6 +-----
 2 files changed, 4 insertions(+), 13 deletions(-)

-- 
2.34.1


             reply	other threads:[~2022-09-14  3:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-14  3:25 Stefan Metzmacher [this message]
2022-09-14  3:25 ` [PATCH 1/2] cifs: don't send down the destination address to sendmsg for a SOCK_STREAM Stefan Metzmacher
2022-09-14  3:25 ` [PATCH 2/2] cifs: always initialize struct msghdr smb_msg completely Stefan Metzmacher
2022-09-14  3:46 ` [PATCH 0/2] cifs: don't send uninitialized memory to sock_{send,recv}msg() ronnie sahlberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1663125352.git.metze@samba.org \
    --to=metze@samba.org \
    --cc=linux-cifs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.