From: Matheus Tavares Bernardino <quic_mathbern@quicinc.com>
To: qemu-devel@nongnu.org
Cc: bcain@quicinc.com, alex.bennee@linaro.org, f4bug@amsat.org,
peter.maydell@linaro.org
Subject: [PATCH v3 0/3] gdbstub: avoid untimely stop-reply msgs
Date: Tue, 20 Sep 2022 09:47:00 -0300 [thread overview]
Message-ID: <cover.1663677789.git.quic_mathbern@quicinc.com> (raw)
This series limits gdbstub to send stop-reply packets only as a reply to
commands that accept them, following the RSP specification.
Changes since v2[1]:
- Replaced char buffer with boolean at struct GDBState.
- Covered other functions that might send stop-reply packets.
- Added test.
Note: I was able to run the added test previously I make sure it passes
after the change, but after rebasing onto master, `make check-tcg` is
giving me the following error (this also happens at the tip of master in
my machine):
qemu: could not load PC BIOS 'bios-256k.bin'
Perhaps I'm doing something wrong at compilation/testing?
[1]: https://lore.kernel.org/qemu-devel/ba99db564c3aeb1812bdfbc9116849092334482f.1661362557.git.quic_mathbern@quicinc.com/
Matheus Tavares Bernardino (3):
configure: make sure tcg tests can see HAVE_GDB_BIN
gdbstub: only send stop-reply packets when allowed to
gdbstub: add test for untimely stop-reply packets
configure | 13 ++--
gdbstub.c | 64 ++++++++++++++-----
meson.build | 6 +-
tests/guest-debug/run-test.py | 16 +++--
.../multiarch/system/Makefile.softmmu-target | 16 ++++-
5 files changed, 83 insertions(+), 32 deletions(-)
--
2.37.2
next reply other threads:[~2022-09-20 15:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-20 12:47 Matheus Tavares Bernardino [this message]
2022-09-20 12:47 ` [PATCH v3 1/3] configure: make sure tcg tests can see HAVE_GDB_BIN Matheus Tavares Bernardino
2022-09-20 12:47 ` [PATCH v3 2/3] gdbstub: only send stop-reply packets when allowed to Matheus Tavares Bernardino
2022-09-20 12:47 ` [PATCH v3 3/3] gdbstub: add test for untimely stop-reply packets Matheus Tavares Bernardino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1663677789.git.quic_mathbern@quicinc.com \
--to=quic_mathbern@quicinc.com \
--cc=alex.bennee@linaro.org \
--cc=bcain@quicinc.com \
--cc=f4bug@amsat.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.