From: Nam Cao <namcaov@gmail.com>
To: forest@alittletooquiet.net, gregkh@linuxfoundation.org,
dan.carpenter@oracle.com
Cc: namcaov@gmail.com, philipp.g.hortmann@gmail.com,
linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev
Subject: [RFC PATCH v2 0/4] staging: vt6655: Implement allocation failure handling
Date: Wed, 28 Sep 2022 19:21:46 +0200 [thread overview]
Message-ID: <cover.1664384503.git.namcaov@gmail.com> (raw)
This driver does not handle allocation failure when receiving data very
well. This patchset implements better handling in the case of allocation
failure.
Also do some necessary clean-up to implement this.
v2:
- squash 3 commits that were doing a single thing
- add new commit which removes a redundant assignment
- take device_init_rx_desc() out of unnecessary else condition.
- remove return statement at the end of void function
- add a missing rd = rd->next statement in device_rx_srv(): because
we already drop the current buffer, we should move on to the next
buffer in the ring where new data will be written to.
Nam Cao (4):
staging: vt6655: remove redundant if condition
staging: vt6655: change vnt_receive_frame return type to void
staging: vt6655: remove redundant assignment
staging: vt6655: implement allocation failure handling
drivers/staging/vt6655/device_main.c | 40 +++++++++++++++++-----------
drivers/staging/vt6655/dpc.c | 8 +++---
drivers/staging/vt6655/dpc.h | 2 +-
3 files changed, 28 insertions(+), 22 deletions(-)
--
2.25.1
next reply other threads:[~2022-09-28 17:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 17:21 Nam Cao [this message]
2022-09-28 17:21 ` [RFC PATCH v2 1/4] staging: vt6655: remove redundant if condition Nam Cao
2022-09-28 17:21 ` [RFC PATCH v2 2/4] staging: vt6655: change vnt_receive_frame return type to void Nam Cao
2022-09-28 17:21 ` [RFC PATCH v2 3/4] staging: vt6655: remove redundant assignment Nam Cao
2022-09-28 17:21 ` [RFC PATCH v2 4/4] staging: vt6655: implement allocation failure handling Nam Cao
2022-09-29 20:30 ` [RFC PATCH v2 0/4] staging: vt6655: Implement " Philipp Hortmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1664384503.git.namcaov@gmail.com \
--to=namcaov@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=forest@alittletooquiet.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=philipp.g.hortmann@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.