From: Qu Wenruo <wqu@suse.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH 0/2] btrfs-progs: mkfs: --rootdir related fixes
Date: Tue, 4 Oct 2022 15:43:37 +0800 [thread overview]
Message-ID: <cover.1664869157.git.wqu@suse.com> (raw)
I don't know if it's recent kernel tmpfs change or something else, but
I'm consistently get ino number smaller than 256 from my /tmp directory.
This behavior change exposed a new problem in mkfs.btrfs --rootdir, that
if some ino number (in the source directory, not in btrfs) is smaller
than 256, it can screw up the backref code.
As backref code is utilizing @owner to determine if a backref is data or
metadata.
And inode number smaller than 256 will make backref code to treat a data
backref as tree backref, and cause corruption.
Thankfully this should not happen that easily, only when --rootdir
points to a newly created fs.
Qu Wenruo (2):
btrfs-progs: properly initialized extent generation for
__btrfs_record_file_extent()
btrfs-progs: avoid fs corruption if rootdir contains ino smaller than
BTRFS_FIRST_FREE_OBJECTID
kernel-shared/extent-tree.c | 8 +++++++-
mkfs/rootdir.c | 8 +++++++-
2 files changed, 14 insertions(+), 2 deletions(-)
--
2.37.3
next reply other threads:[~2022-10-04 7:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-04 7:43 Qu Wenruo [this message]
2022-10-04 7:43 ` [PATCH 1/2] btrfs-progs: properly initialized extent generation for __btrfs_record_file_extent() Qu Wenruo
2022-10-05 9:39 ` Anand Jain
2022-10-05 14:31 ` David Sterba
2022-10-04 7:43 ` [PATCH 2/2] btrfs-progs: avoid fs corruption if rootdir contains ino smaller than BTRFS_FIRST_FREE_OBJECTID Qu Wenruo
2022-10-04 9:04 ` [PATCH 0/2] btrfs-progs: mkfs: --rootdir related fixes David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1664869157.git.wqu@suse.com \
--to=wqu@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.