From: Pavel Begunkov <asml.silence@gmail.com>
To: Jens Axboe <axboe@kernel.dk>, Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
"David S . Miller" <davem@davemloft.net>
Cc: io-uring@vger.kernel.org, asml.silence@gmail.com,
netdev@vger.kernel.org, Stefan Metzmacher <metze@samba.org>
Subject: [PATCH for-6.1 0/3] fail io_uring zc with sockets not supporting it
Date: Fri, 21 Oct 2022 11:16:38 +0100 [thread overview]
Message-ID: <cover.1666346426.git.asml.silence@gmail.com> (raw)
Some sockets don't care about msghdr::ubuf_info and would execute the
request by copying data. Such fallback behaviour was always a pain in
my experience, so we'd rather want to fail such requests and have a more
robust api in the future.
Mark struct socket that support it with a new SOCK_SUPPORT_ZC flag.
I'm not entirely sure it's the best place for the flag but at least
we don't have to do a bunch of extra dereferences in the hot path.
P.S. patches 2 and 3 are not combined for backporting purposes.
Pavel Begunkov (3):
net: flag sockets supporting msghdr originated zerocopy
io_uring/net: fail zc send when unsupported by socket
io_uring/net: fail zc sendmsg when unsupported by socket
include/linux/net.h | 1 +
io_uring/net.c | 4 ++++
net/ipv4/tcp.c | 1 +
net/ipv4/udp.c | 1 +
4 files changed, 7 insertions(+)
--
2.38.0
next reply other threads:[~2022-10-21 10:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-21 10:16 Pavel Begunkov [this message]
2022-10-21 10:16 ` [PATCH for-6.1 1/3] net: flag sockets supporting msghdr originated zerocopy Pavel Begunkov
2022-10-21 16:14 ` Jakub Kicinski
2022-10-22 15:57 ` Pavel Begunkov
2022-10-22 16:07 ` Jens Axboe
2022-10-24 12:49 ` Stefan Metzmacher
2022-10-24 14:12 ` Stefan Metzmacher
2022-10-24 17:00 ` Pavel Begunkov
2022-10-24 17:45 ` Stefan Metzmacher
2022-10-21 10:16 ` [PATCH for-6.1 2/3] io_uring/net: fail zc send when unsupported by socket Pavel Begunkov
2022-10-21 10:16 ` [PATCH for-6.1 3/3] io_uring/net: fail zc sendmsg " Pavel Begunkov
2022-10-21 10:27 ` [PATCH for-6.1 0/3] fail io_uring zc with sockets not supporting it Stefan Metzmacher
2022-10-21 10:42 ` Pavel Begunkov
2022-10-21 12:49 ` Stefan Metzmacher
2022-10-24 20:40 ` patchwork-bot+netdevbpf
2022-10-24 21:15 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1666346426.git.asml.silence@gmail.com \
--to=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=davem@davemloft.net \
--cc=io-uring@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=metze@samba.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.