From: Binbin Zhou <zhoubinbin@loongson.cn>
To: Wolfram Sang <wsa@kernel.org>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
linux-i2c@vger.kernel.org
Cc: loongarch@lists.linux.dev, devicetree@vger.kernel.org,
Huacai Chen <chenhuacai@loongson.cn>,
WANG Xuerui <kernel@xen0n.name>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Arnd Bergmann <arnd@arndb.de>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Jianmin Lv <lvjianmin@loongson.cn>,
Binbin Zhou <zhoubinbin@loongson.cn>
Subject: [PATCH V5 0/4] i2c: ls2x: Add support for the Loongson-2K/LS7A I2C controller
Date: Tue, 6 Dec 2022 11:16:53 +0800 [thread overview]
Message-ID: <cover.1670293176.git.zhoubinbin@loongson.cn> (raw)
Hi all:
This patch series adds support for the I2C module found on various
Loongson systems with the Loongson-2K SoC or the Loongson LS7A bridge chip.
For now, the I2C driver is suitable for DT-based or ACPI-based systems.
I have tested on Loongson-3A5000LA+LS7A1000/LS7A2000, Loongson-2K1000LA
and Loongson-2K0500.
Thanks.
Changes since V4:
- patch (1/4)
- Drop unneeded headers: of.h;
- xxx_props -> xxx_properties.
- patch (2/4)
- Add interrupt headers to fix syntax error found by Rob.
- patch (3/4)
- Drop atmoic loop in ls2x_i2c_master_xfer(), The continuous I2C
read/write test passes on the corresponding machine;
- Define the corresponding bits in I2C_LS2X_CTR to avoid magic
numbers;
- dev_get_drvdata() is used to get ls2x_i2c_priv() in
ls2x_i2c_suspend();
- i2c_add_adapter() -> devm_i2c_add_adapter();
- SET_SYSTEM_SLEEP_PM_OPS() -> DEFINE_RUNTIME_DEV_PM_OPS();
- Code formatting, such as alignment.
Details: https://lore.kernel.org/all/Y4e%2F6KewuHjAluSZ@smile.fi.intel.com/
Changes since V3:
- Addressed all review comments from v3
- Change the changelog text to make it clearer (1/5);
- Fix some minor bugs, such as formatting issues (2/5);
- Fix some formatting issues (3/5);
- Deep refactoring of code for clarity (4/5).
Details: https://lore.kernel.org/all/Y4S2cnlAm3YYvZ8E@smile.fi.intel.com/
Thanks to all for their suggestions.
Changes since V2:
- Addressed all review comments from v2
- Drop of_match_ptr() in i2c-gpio to avoid potential unused warnings
(1/5);
- Introduce i2c_gpio_get_props() function as the generic interface
to get i2c-gpio props from DT or ACPI table (2/5);
- Refact ls2x i2c code, similar to removing excessive goto tags (4/5).
Thanks to Andy and Mika for their suggestions.
Changes since V1:
- Remove the function of getting the static i2c bus number from ACPI "_UID";
- Fix build warning from kernel test robot.
Binbin Zhou (4):
i2c: gpio: Add support on ACPI-based system
dt-bindings: i2c: add Loongson LS2X I2C controller
i2c: ls2x: Add driver for Loongson-2K/LS7A I2C controller
LoongArch: Enable LS2X I2C in loongson3_defconfig
.../bindings/i2c/loongson,ls2x-i2c.yaml | 51 +++
arch/loongarch/configs/loongson3_defconfig | 1 +
drivers/i2c/busses/Kconfig | 11 +
drivers/i2c/busses/Makefile | 1 +
drivers/i2c/busses/i2c-gpio.c | 27 +-
drivers/i2c/busses/i2c-ls2x.c | 379 ++++++++++++++++++
6 files changed, 460 insertions(+), 10 deletions(-)
create mode 100644 Documentation/devicetree/bindings/i2c/loongson,ls2x-i2c.yaml
create mode 100644 drivers/i2c/busses/i2c-ls2x.c
--
2.31.1
next reply other threads:[~2022-12-06 3:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-06 3:16 Binbin Zhou [this message]
2022-12-06 3:16 ` [PATCH V5 1/4] i2c: gpio: Add support on ACPI-based system Binbin Zhou
2022-12-06 15:13 ` Andy Shevchenko
2022-12-07 7:10 ` Binbin Zhou
2022-12-12 9:40 ` Andy Shevchenko
2022-12-06 3:16 ` [PATCH V5 2/4] dt-bindings: i2c: add Loongson LS2X I2C controller Binbin Zhou
2022-12-06 3:16 ` [PATCH V5 3/4] i2c: ls2x: Add driver for Loongson-2K/LS7A " Binbin Zhou
2022-12-06 3:17 ` Binbin Zhou
2022-12-06 15:23 ` Andy Shevchenko
2022-12-08 8:55 ` Binbin Zhou
2022-12-12 9:47 ` Andy Shevchenko
2022-12-12 12:41 ` Binbin Zhou
2022-12-06 3:17 ` [PATCH V5 4/4] LoongArch: Enable LS2X I2C in loongson3_defconfig Binbin Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1670293176.git.zhoubinbin@loongson.cn \
--to=zhoubinbin@loongson.cn \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=chenhuacai@loongson.cn \
--cc=devicetree@vger.kernel.org \
--cc=kernel@xen0n.name \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=lvjianmin@loongson.cn \
--cc=mika.westerberg@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=wsa+renesas@sang-engineering.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.