All of lore.kernel.org
 help / color / mirror / Atom feed
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: xen-devel@lists.xenproject.org
Cc: "Demi Marie Obenour" <demi@invisiblethingslab.com>,
	"Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>,
	"Jan Beulich" <jbeulich@suse.com>,
	"Andrew Cooper" <andrew.cooper3@citrix.com>,
	"Roger Pau Monné" <roger.pau@citrix.com>, "Wei Liu" <wl@xen.org>,
	"George Dunlap" <george.dunlap@citrix.com>,
	"Tim Deegan" <tim@xen.org>
Subject: [PATCH 0/8] Make PAT handling less brittle
Date: Mon,  5 Dec 2022 23:33:29 -0500	[thread overview]
Message-ID: <cover.1670300446.git.demi@invisiblethingslab.com> (raw)

While working on Qubes OS Marek found out that there were some PAT hacks
in the Linux i915 driver.  I decided to make Xen use Linux’s PAT to see
if it solved the graphics glitches that were observed; it did.  This
required a substantial amount of preliminary work that is useful even
without using Linux’s PAT.

Patches 1 through 7 are the preliminary work and I would like them to be
accepted into upstream Xen.  Patch 7 does technically break ABI by
rejecting the unused PAT entries in debug builds, but as release builds
are not impacted I suspect it is not a serious concern.  Patch 8
actually switches to Linux’s PAT and is NOT intended to be merged (at
least for now) as it would at a minimum break migration of PV guests
from hosts that do not have the patch.

Demi Marie Obenour (8):
  x86/mm: Avoid hard-coding PAT in get_page_from_l1e()
  p2m-pt: Avoid hard-coding Xen's PAT
  x86/mm/shadow: avoid assuming a specific Xen PAT
  efi: Avoid hard-coding the various PAT constants
  x86/mm/shadow: do not open-code PAGE_CACHE_ATTRS
  x86: Derive XEN_MSR_PAT from its individual entries
  x86/mm: make code robust to future PAT changes
  Use Linux's PAT

 xen/arch/x86/include/asm/page.h      |  4 +-
 xen/arch/x86/include/asm/processor.h | 22 +++++++++-
 xen/arch/x86/mm.c                    | 65 ++++++++++++++++++++++++----
 xen/arch/x86/mm/p2m-pt.c             |  6 +--
 xen/arch/x86/mm/shadow/multi.c       |  8 ++--
 xen/common/efi/boot.c                | 10 ++---
 6 files changed, 91 insertions(+), 24 deletions(-)

-- 
Sincerely,
Demi Marie Obenour (she/her/hers)
Invisible Things Lab


             reply	other threads:[~2022-12-06  4:34 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-06  4:33 Demi Marie Obenour [this message]
2022-12-06  4:33 ` [PATCH 1/8] x86/mm: Avoid hard-coding PAT in get_page_from_l1e() Demi Marie Obenour
2022-12-06 10:42   ` Andrew Cooper
2022-12-06 11:07     ` Jan Beulich
2022-12-06 11:05   ` Jan Beulich
2022-12-06  4:33 ` [PATCH 2/8] p2m-pt: Avoid hard-coding Xen's PAT Demi Marie Obenour
2022-12-06 10:59   ` Andrew Cooper
2022-12-06 11:10     ` Jan Beulich
2022-12-06  4:33 ` [PATCH 3/8] x86/mm/shadow: avoid assuming a specific Xen PAT Demi Marie Obenour
2022-12-06 11:00   ` Andrew Cooper
2022-12-06  4:33 ` [PATCH 4/8] efi: Avoid hard-coding the various PAT constants Demi Marie Obenour
2022-12-06 11:15   ` Jan Beulich
2022-12-06 11:17   ` Andrew Cooper
2022-12-06 11:40     ` Jan Beulich
2022-12-06 17:38     ` Demi Marie Obenour
2022-12-06  4:33 ` [PATCH 5/8] x86/mm/shadow: do not open-code PAGE_CACHE_ATTRS Demi Marie Obenour
2022-12-06 11:17   ` Jan Beulich
2022-12-06  4:33 ` [PATCH 6/8] x86: Derive XEN_MSR_PAT from its individual entries Demi Marie Obenour
2022-12-06 11:32   ` Andrew Cooper
2022-12-06 11:43     ` Jan Beulich
2022-12-06 17:44     ` Demi Marie Obenour
2022-12-06 22:51     ` Demi Marie Obenour
2022-12-06 11:35   ` Jan Beulich
2022-12-06  4:33 ` [PATCH 7/8] x86/mm: make code robust to future PAT changes Demi Marie Obenour
2022-12-06 12:01   ` Jan Beulich
2022-12-06 12:06   ` Andrew Cooper
2022-12-06 17:55     ` Demi Marie Obenour
2022-12-07  9:41       ` Jan Beulich
2022-12-07 12:14         ` Andrew Cooper
2022-12-06  4:33 ` [RFC PATCH 8/8] Use Linux's PAT Demi Marie Obenour
2022-12-06 11:38   ` Andrew Cooper
2022-12-06 18:01     ` Demi Marie Obenour
2022-12-06 18:12       ` Marek Marczykowski-Górecki
2022-12-06 19:47         ` Demi Marie Obenour
2022-12-06 20:53           ` Marek Marczykowski-Górecki
2022-12-13  1:31         ` Demi Marie Obenour

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1670300446.git.demi@invisiblethingslab.com \
    --to=demi@invisiblethingslab.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=george.dunlap@citrix.com \
    --cc=jbeulich@suse.com \
    --cc=marmarek@invisiblethingslab.com \
    --cc=roger.pau@citrix.com \
    --cc=tim@xen.org \
    --cc=wl@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.