From: Paolo Abeni <pabeni@redhat.com>
To: mptcp@lists.linux.dev
Subject: [PATCH mptcp-next v2 00/13] mptcp: refactor first subflow init
Date: Tue, 17 Jan 2023 08:36:20 +0100 [thread overview]
Message-ID: <cover.1673940640.git.pabeni@redhat.com> (raw)
This is the needed refactor for the selinux fixes, as discussed on
the ML.
Patch the first 2 patches address old, currently not so relevant bugs
which will become more serious once the refactor is applied.
Patches 3-7 are pre-reqs for the bulk changes, but also IMHO nice to
have even stand-alone.
The main change, introduced by patch 8, consists in moving the first
subflow initialization from the msk init callback into the mptcp
syscall needing such data (namely: bind, listen, connect).
Patches 9, 10, 11 are not strictly needed, but are some nice to have
follow-up, cleaning-up the related code.
Specifically patch 10 closes issues/290
Finally patches 12 && 13 address the LSM issue. They really target the
LSM subtree, and are added here just to allow verify the fix in our
tree before the LSM submission.
Sharing after little testing to get feedback and let the bot massage
the new code: a couple of patches can have subtle effect, I would like to
have syzkaller digest them for a while.
Paolo Abeni (13):
mptcp: fix locking for setsockopt corner-case
mptcp: fix locking for in-kernel listener creation.
mptcp: refactor passive socket initialization.
mptcp: drop unneeded argument
mptcp: drop legacy code.
mptcp: avoid unneeded __mptcp_nmpc_socket() usage
mptcp: move fastopen subflow check inside mptcp_sendmsg_fastopen()
mptcp: move first subflow allocation at mpc access time
mptcp: do not keep around the first subflow after disconnect.
mptcp: fastclose msk when cleaning unaccepted sockets
mptcp: refactor mptcp_stream_accept()
security, lsm: Introduce security_mptcp_add_subflow()
selinux: Implement mptcp_add_subflow hook
include/linux/lsm_hook_defs.h | 1 +
include/linux/lsm_hooks.h | 9 ++
include/linux/security.h | 6 ++
net/mptcp/options.c | 9 +-
net/mptcp/pm.c | 4 +-
net/mptcp/pm_netlink.c | 14 +--
net/mptcp/protocol.c | 163 ++++++++++++++++++----------------
net/mptcp/protocol.h | 4 +-
net/mptcp/sockopt.c | 29 +++---
net/mptcp/subflow.c | 48 +++++++---
security/security.c | 5 ++
security/selinux/hooks.c | 16 ++++
security/selinux/netlabel.c | 8 +-
13 files changed, 198 insertions(+), 118 deletions(-)
--
2.39.0
next reply other threads:[~2023-01-17 7:37 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 7:36 Paolo Abeni [this message]
2023-01-17 7:36 ` [PATCH mptcp-next v2 01/13] mptcp: fix locking for setsockopt corner-case Paolo Abeni
2023-01-17 7:36 ` [PATCH mptcp-next v2 02/13] mptcp: fix locking for in-kernel listener creation Paolo Abeni
2023-01-17 7:36 ` [PATCH mptcp-next v2 03/13] mptcp: refactor passive socket initialization Paolo Abeni
2023-01-17 7:36 ` [PATCH mptcp-next v2 04/13] mptcp: drop unneeded argument Paolo Abeni
2023-01-17 7:36 ` [PATCH mptcp-next v2 05/13] mptcp: drop legacy code Paolo Abeni
2023-01-17 7:36 ` [PATCH mptcp-next v2 06/13] mptcp: avoid unneeded __mptcp_nmpc_socket() usage Paolo Abeni
2023-01-17 7:36 ` [PATCH mptcp-next v2 07/13] mptcp: move fastopen subflow check inside mptcp_sendmsg_fastopen() Paolo Abeni
2023-01-17 7:36 ` [PATCH mptcp-next v2 08/13] mptcp: move first subflow allocation at mpc access time Paolo Abeni
2023-01-24 16:31 ` Matthieu Baerts
2023-01-26 17:49 ` Paolo Abeni
2023-01-26 18:19 ` Matthieu Baerts
2023-01-17 7:36 ` [PATCH mptcp-next v2 09/13] mptcp: do not keep around the first subflow after disconnect Paolo Abeni
2023-01-17 7:36 ` [PATCH mptcp-next v2 10/13] mptcp: fastclose msk when cleaning unaccepted sockets Paolo Abeni
2023-01-25 17:47 ` Matthieu Baerts
2023-01-17 7:36 ` [PATCH mptcp-next v2 11/13] mptcp: refactor mptcp_stream_accept() Paolo Abeni
2023-01-25 17:47 ` Matthieu Baerts
2023-01-26 17:53 ` Paolo Abeni
2023-01-26 18:27 ` Matthieu Baerts
2023-01-26 18:36 ` Paolo Abeni
2023-01-25 17:47 ` Matthieu Baerts
2023-01-17 7:36 ` [PATCH mptcp-next v2 12/13] security, lsm: Introduce security_mptcp_add_subflow() Paolo Abeni
2023-01-17 7:36 ` [PATCH mptcp-next v2 13/13] selinux: Implement mptcp_add_subflow hook Paolo Abeni
2023-01-17 9:09 ` selinux: Implement mptcp_add_subflow hook: Tests Results MPTCP CI
2023-01-17 15:17 ` Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1673940640.git.pabeni@redhat.com \
--to=pabeni@redhat.com \
--cc=mptcp@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.