From: William Breathitt Gray <william.gray@linaro.org>
To: Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
William Breathitt Gray <william.gray@linaro.org>
Subject: [PATCH v3 0/2] Migrate STX104 to the regmap API
Date: Sun, 26 Mar 2023 18:05:56 -0400 [thread overview]
Message-ID: <cover.1679867815.git.william.gray@linaro.org> (raw)
Changes in v3:
- Add STX104_ prefixes to defines to avoid potential name classes
- Rename SAME_CHANNEL() to STX104_SINGLE_CHANNEL() to convey intention
better
- Utilize u8_encode_bits() to define STX104_SOFTWARE_TRIGGER
- Adjust to utilize reg_base members in regmap_config structures
- Fix off-by-one errors in aio_data_wr_ranges[], aio_data_rd_ranges[],
and aio_data_regmap_config max_register
- Inline gpio_config initialization to avoid zeroing it at declaration
- Add blank lines between register map init blocks for clarity
- Utilize regmap_read_poll_timeout() for ADC conversion status poll
Changes in v2:
- Relocate struct stx104_iio for the sake of a clearer patch diff
- Replace FIELD_PREP() and FIELD_GET() with u8_encode_bits() and
u8_get_bits()
The regmap API supports IO port accessors so we can take advantage of
regmap abstractions rather than handling access to the device registers
directly in the driver.
A patch to utilize regmap_read_poll_timeout() for polling the ADC
conversion status is included as follow-up to make the git history
clearer for this change.
William Breathitt Gray (2):
iio: addac: stx104: Migrate to the regmap API
iio: addac: stx104: Use regmap_read_poll_timeout() for conversion poll
drivers/iio/addac/Kconfig | 2 +
drivers/iio/addac/stx104.c | 434 +++++++++++++++++++++----------------
2 files changed, 244 insertions(+), 192 deletions(-)
base-commit: 46e33707fe95a21aa9896bded0be97285b779509
--
2.39.2
next reply other threads:[~2023-03-26 22:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-26 22:05 William Breathitt Gray [this message]
2023-03-26 22:05 ` [PATCH v3 1/2] iio: addac: stx104: Migrate to the regmap API William Breathitt Gray
2023-03-27 11:42 ` Andy Shevchenko
2023-04-01 13:49 ` Jonathan Cameron
2023-04-01 13:51 ` Jonathan Cameron
2023-04-01 13:43 ` William Breathitt Gray
2023-04-01 14:06 ` William Breathitt Gray
2023-04-02 16:46 ` Jonathan Cameron
2023-04-02 14:51 ` William Breathitt Gray
2023-03-26 22:05 ` [PATCH v3 2/2] iio: addac: stx104: Use regmap_read_poll_timeout() for conversion poll William Breathitt Gray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1679867815.git.william.gray@linaro.org \
--to=william.gray@linaro.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.