All of lore.kernel.org
 help / color / mirror / Atom feed
From: Han Xin <hanxin.hx@bytedance.com>
To: git@vger.kernel.org
Cc: Han Xin <hanxin.hx@bytedance.com>,
	xingxin.xx@bytedance.com, jonathantanmy@google.com,
	derrickstolee@github.com, Junio C Hamano <gitster@pobox.com>
Subject: [PATCH v2 0/2] negotiator/default: avoid stack overflow
Date: Wed, 26 Apr 2023 12:05:21 +0800	[thread overview]
Message-ID: <cover.1682473718.git.hanxin.hx@bytedance.com> (raw)
In-Reply-To: <20230424022318.80469-1-hanxin.hx@bytedance.com>

This series avoid stack overflow in negotiator/default.c and memory leak
in negotiator/skipping.c.

Changes since v1:
* Add duplicate protection in negotiator/default.c and
  negotiator/skipping.c.
* Split the memory leak cleanup in negotiator/skipping.c into its own
  change and fix some other problems sugguested by Derrick Stolee.
* Minor grammar/comment etc. fixes throughout.

Han Xin (2):
  negotiator/default: avoid stack overflow
  negotiator/skipping: fix some problems in mark_common()

 negotiator/default.c  | 39 +++++++++++++++++++++++++++++----------
 negotiator/skipping.c | 10 ++++++----
 2 files changed, 35 insertions(+), 14 deletions(-)

Range-diff against v1:
1:  a0a1473f5e < -:  ---------- negotiator/default.c: avoid stack overflow
-:  ---------- > 1:  935be72eb9 negotiator/default: avoid stack overflow
-:  ---------- > 2:  abbb1bc0b3 negotiator/skipping: fix some problems in mark_common()
-- 
2.40.0


  parent reply	other threads:[~2023-04-26  4:06 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-24  2:23 [PATCH v1] negotiator/default.c: avoid stack overflow Han Xin
2023-04-24 14:44 ` Derrick Stolee
2023-04-25  3:02   ` [External] " Han Xin
2023-04-25 13:34     ` Derrick Stolee
2023-04-26  4:05 ` Han Xin [this message]
2023-04-26  4:05   ` [PATCH v2 1/2] negotiator/default: " Han Xin
2023-04-26 11:13     ` Derrick Stolee
2023-04-26 11:40       ` [External] " Han Xin
2023-04-26  4:05   ` [PATCH v2 2/2] negotiator/skipping: fix some problems in mark_common() Han Xin
2023-04-26 11:08     ` Derrick Stolee
2023-04-26 11:55       ` [External] " Han Xin
2023-04-26 13:15   ` [PATCH v2 0/2] negotiator/default: avoid stack overflow Han Xin
2023-04-26 13:15     ` [PATCH v3 1/2] " Han Xin
2023-04-26 17:14       ` Junio C Hamano
2023-04-26 17:30         ` Derrick Stolee
2023-04-26 17:38           ` Junio C Hamano
2023-04-26 13:15     ` [PATCH v3 2/2] negotiator/skipping: fix some problems in mark_common() Han Xin
2023-05-01 22:11     ` [PATCH v2 0/2] negotiator/default: avoid stack overflow Junio C Hamano
2023-05-02  1:49       ` Derrick Stolee
2023-05-02 15:51         ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1682473718.git.hanxin.hx@bytedance.com \
    --to=hanxin.hx@bytedance.com \
    --cc=derrickstolee@github.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jonathantanmy@google.com \
    --cc=xingxin.xx@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.