All of lore.kernel.org
 help / color / mirror / Atom feed
From: Qu Wenruo <wqu@suse.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH v2 0/7] btrfs-progs: fix -Wmissing-prototypes warnings and enable that warning option
Date: Wed,  3 May 2023 14:03:36 +0800	[thread overview]
Message-ID: <cover.1683093416.git.wqu@suse.com> (raw)

We have at least one case that some function is exported but never got
utilized in the first place.

Let's prevent this problem from happening again by enable
-Wmissing-prototypes to debug builds at least.

Fixes for  the existing warnings are split into several patches:

- Remove unused functions
  Two patches, the first is to remove a function that never got
  utilized from the introduction.

  The second is to remove a very old feature (only for <3.12 kernels)
  in libbtrfs.
  In fact this functionality for fs without an UUID tree is already
  broken during previous cleanups.
  (Need to export subvol_uuid_search_add() and
   subvol_uuid_search_finit(), as it's callers' responsibility to
   search for the target subvolume by themselves)

  And since no one is complaining ever since, there is really no need
  to maintain such an old and deprecated feature in libbtrfs.

- Fixes for crypto related function
  Two patches, one for each csum algo (blake2 and sha256).
  Involves extra declarations in the headers.

- Trivial fixes
  Mostly unexport and add needed headers.

Qu Wenruo (7):
  btrfs-progs: remove function btrfs_check_allocatable_zones()
  btrfs-progs: libbtrfs: remove the support for fs without uuid tree
  btrfs-progs: crypto/blake2: remove blake2 simple API
  btrfs-progs: crypto/blake2: move optimized declarations to blake2b.h
  btrfs-progs: crypto/sha: declare the x86 optimized implementation
  btrfs-progs: fix -Wmissing-prototypes warnings
  btrfs-progs: Makefile: enable -Wmissing-prototypes

 Makefile              |   3 +-
 cmds/qgroup.c         |   2 +-
 cmds/reflink.c        |   2 +-
 cmds/subvolume-list.c |   2 +-
 common/device-utils.c |   2 +-
 common/utils.c        |   2 +-
 crypto/blake2.h       |   5 +
 crypto/blake2b-ref.c  |   8 -
 crypto/sha.h          |   3 +
 crypto/sha256-x86.c   |   2 +
 kernel-shared/ulist.c |   2 +-
 kernel-shared/zoned.c |  60 +------
 libbtrfs/send-utils.c | 396 ------------------------------------------
 libbtrfs/send-utils.h |  20 ---
 tune/change-csum.c    |   1 +
 tune/change-uuid.c    |   1 +
 tune/convert-bgt.c    |   1 +
 tune/seeding.c        |   1 +
 tune/tune.h           |   2 +
 19 files changed, 25 insertions(+), 490 deletions(-)

-- 
2.39.2


             reply	other threads:[~2023-05-03  6:04 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-03  6:03 Qu Wenruo [this message]
2023-05-03  6:03 ` [PATCH v2 1/7] btrfs-progs: remove function btrfs_check_allocatable_zones() Qu Wenruo
2023-05-04  8:46   ` Anand Jain
2023-05-03  6:03 ` [PATCH v2 2/7] btrfs-progs: libbtrfs: remove the support for fs without uuid tree Qu Wenruo
2023-05-03 18:35   ` David Sterba
2023-05-03 23:23     ` Qu Wenruo
2023-05-24 19:32   ` David Sterba
2023-05-03  6:03 ` [PATCH v2 3/7] btrfs-progs: crypto/blake2: remove blake2 simple API Qu Wenruo
2023-05-04  9:08   ` Anand Jain
2023-05-04 22:05     ` David Sterba
2023-05-05  7:05     ` Qu Wenruo
2023-05-03  6:03 ` [PATCH v2 4/7] btrfs-progs: crypto/blake2: move optimized declarations to blake2b.h Qu Wenruo
2023-05-03  6:03 ` [PATCH v2 5/7] btrfs-progs: crypto/sha: declare the x86 optimized implementation Qu Wenruo
2023-05-03  6:03 ` [PATCH v2 6/7] btrfs-progs: fix -Wmissing-prototypes warnings Qu Wenruo
2023-05-03  6:03 ` [PATCH v2 7/7] btrfs-progs: Makefile: enable -Wmissing-prototypes Qu Wenruo
2023-05-04 22:18 ` [PATCH v2 0/7] btrfs-progs: fix -Wmissing-prototypes warnings and enable that warning option David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1683093416.git.wqu@suse.com \
    --to=wqu@suse.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.