All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrea Claudi <aclaudi@redhat.com>
To: mptcp@lists.linux.dev
Cc: Matthieu Baerts <matthieu.baerts@tessares.net>,
	Mat Martineau <martineau@kernel.org>
Subject: [PATCH mptcp-next v2 0/2] selftests: fix mptcp_join test
Date: Thu, 27 Jul 2023 13:08:53 +0200	[thread overview]
Message-ID: <cover.1690454072.git.aclaudi@redhat.com> (raw)

This series fixes two mptcp_join testcases when using ip mptcp:
- 'implicit EP' fails because of:
  - missing iproute support for mptcp 'implicit' flag, fixed with
    iproute2-next commit 3a2535a41854 ("mptcp: add support for implicit
    flag")
  - pm_nl_check_endpoint expecting two ip addresses, while only one is
    present in the iproute output;
- 'delete and re-add' fails because the endpoint delete command
  provide both id and ip address, while address should be provided only
  if id is 0.

Changelog:

v1 -> v2
- Clearly state test fails only when using ip mptcp, i.e.
  ./mptcp_join.sh -i
- Remove test numbers from commit messages
- On endpoint delete, continue to provide $addr when id is 0.

Andrea Claudi (2):
  selftests: mptcp: join: fix 'delete and re-add' test
  selftests: mptcp: join: fix 'implicit EP' test

 tools/testing/selftests/net/mptcp/mptcp_join.sh | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

-- 
2.41.0


             reply	other threads:[~2023-07-27 11:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-27 11:08 Andrea Claudi [this message]
2023-07-27 11:08 ` [PATCH mptcp-next v2 1/2] selftests: mptcp: join: fix 'delete and re-add' test Andrea Claudi
2023-07-27 11:08 ` [PATCH mptcp-next v2 2/2] selftests: mptcp: join: fix 'implicit EP' test Andrea Claudi
2023-07-27 12:29   ` selftests: mptcp: join: fix 'implicit EP' test: Tests Results MPTCP CI
2023-07-27 16:52   ` [PATCH mptcp-next v2 2/2] selftests: mptcp: join: fix 'implicit EP' test Matthieu Baerts
2023-07-27 17:19     ` Andrea Claudi
2023-07-27 18:39   ` selftests: mptcp: join: fix 'implicit EP' test: Tests Results MPTCP CI
2023-07-27 16:52 ` [PATCH mptcp-next v2 0/2] selftests: fix mptcp_join test Matthieu Baerts
2023-07-27 17:20   ` Andrea Claudi
2023-07-28 10:29 ` Matthieu Baerts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1690454072.git.aclaudi@redhat.com \
    --to=aclaudi@redhat.com \
    --cc=martineau@kernel.org \
    --cc=matthieu.baerts@tessares.net \
    --cc=mptcp@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.