From: "Gergő Köteles" <soyer@irl.hu>
To: Mauro Carvalho Chehab <mchehab@kernel.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
"Gergő Köteles" <soyer@irl.hu>
Subject: [RFC PATCH 0/2] media: v4l2: map UVC_CT_ROLL_ABSOLUTE_CONTROL
Date: Thu, 3 Aug 2023 23:28:56 +0200 [thread overview]
Message-ID: <cover.1691096157.git.soyer@irl.hu> (raw)
Hi,
Logitech Streamcam can be mounted in 'portrait mode' as well.
It reports the current roll (-90, 0, 90, 180) with
UVC_CT_ROLL_ABSOLUTE_CONTROL.
This RFC defines V4L2_CID_ROLL_ABSOLUTE, and maps
UVC_CT_ROLL_ABSOLUTE_CONTROL to make it available to
userspace.
Then, the userspace can rotate the stream based on the roll.
Is it better to use V4L2_CID_CAMERA_SENSOR_ROTATION for this?
The value set matches that control.
If yes, is it worth mapping UVC_CT_ROLL_ABSOLUTE_CONTROL to
V4L2_CID_CAMERA_SENSOR_ROTATION for this camera only?
Any feedback is greately appreciated.
Gergő Köteles (2):
media: v4l2: ctrls: Add ROLL_ABSOLUTE control
media: v4l2: map UVC_CT_ROLL_ABSOLUTE_CONTROL
.../userspace-api/media/v4l/ext-ctrls-camera.rst | 5 +++++
drivers/media/usb/uvc/uvc_ctrl.c | 9 +++++++++
drivers/media/v4l2-core/v4l2-ctrls-defs.c | 1 +
include/uapi/linux/v4l2-controls.h | 2 ++
4 files changed, 17 insertions(+)
base-commit: 06c2afb862f9da8dc5efa4b6076a0e48c3fbaaa5
--
2.41.0
next reply other threads:[~2023-08-03 21:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-03 21:28 Gergő Köteles [this message]
2023-08-03 21:28 ` [RFC PATCH 1/2] media: v4l2: ctrls: Add ROLL_ABSOLUTE control Gergő Köteles
2023-08-03 21:28 ` [RFC PATCH 2/2] media: v4l2: map UVC_CT_ROLL_ABSOLUTE_CONTROL Gergő Köteles
2023-08-04 18:45 ` [RFC PATCH 0/2] " Michael Riesch
2023-08-04 21:33 ` Gergő Köteles
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1691096157.git.soyer@irl.hu \
--to=soyer@irl.hu \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.