From: Nicola Vetrini <nicola.vetrini@bugseng.com>
To: xen-devel@lists.xenproject.org
Cc: sstabellini@kernel.org, michal.orzel@amd.com,
xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com,
consulting@bugseng.com,
"Nicola Vetrini" <nicola.vetrini@bugseng.com>,
"Julien Grall" <julien@xen.org>,
"Bertrand Marquis" <bertrand.marquis@arm.com>,
"Volodymyr Babchuk" <Volodymyr_Babchuk@epam.com>,
"Tamas K Lengyel" <tamas@tklengyel.com>,
"Alexandru Isaila" <aisaila@bitdefender.com>,
"Petre Pircalabu" <ppircalabu@bitdefender.com>,
"Jan Beulich" <jbeulich@suse.com>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Roger Pau Monné" <roger.pau@citrix.com>, "Wei Liu" <wl@xen.org>,
"George Dunlap" <george.dunlap@citrix.com>
Subject: [XEN PATCH v2 0/3] xen: fix inclusions and static storage duration
Date: Thu, 17 Aug 2023 14:39:25 +0200 [thread overview]
Message-ID: <cover.1692275359.git.nicola.vetrini@bugseng.com> (raw)
The files touched by this series contain function or variable definitions with
no prior declaration visible, because it's inside an header that is not included
or it's not present anywhere. This is a risk in itself, but also violates
MISRA C:2012 Rule 8.4, which states the following:
"A compatible declaration shall be visible when an object or function with
external linkage is defined".
The resolution strategies are as follows:
1. make the functions/variables static
2. include the header that contains the compatible declaration
No functional change.
Additional notes:
- This series is a continuation of the work done here [1], so the same additional
notes apply.
[1] https://lore.kernel.org/xen-devel/cover.1691655814.git.nicola.vetrini@bugseng.com/T/#m28da1b5ef8d9a7683937bfc345765e3438b89977
Changes in v2:
- Addressed review comments on the leftover patches
- Patches 1,2,4 from the previous version have already been committed
Nicola Vetrini (3):
vm_event: rework inclusions to use arch-indipendent header
vpci/msix: make 'get_slot' static
drivers/video: make declarations of defined functions available
xen/arch/arm/include/asm/vm_event.h | 1 -
xen/arch/arm/vm_event.c | 2 +-
xen/arch/x86/include/asm/setup.h | 6 ------
xen/arch/x86/platform_hypercall.c | 2 +-
xen/arch/x86/pv/dom0_build.c | 2 +-
xen/arch/x86/vm_event.c | 2 +-
xen/drivers/video/vga.c | 8 --------
xen/drivers/vpci/msix.c | 2 +-
xen/include/xen/console.h | 2 --
xen/include/xen/vga.h | 16 ++++++++++++++++
xen/include/xen/vm_event.h | 1 +
11 files changed, 22 insertions(+), 22 deletions(-)
--
2.34.1
next reply other threads:[~2023-08-17 12:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-17 12:39 Nicola Vetrini [this message]
2023-08-17 12:39 ` [XEN PATCH v2 1/3] vm_event: rework inclusions to use arch-indipendent header Nicola Vetrini
2023-08-17 18:00 ` Stefano Stabellini
2023-08-17 12:39 ` [XEN PATCH v2 2/3] vpci/msix: make 'get_slot' static Nicola Vetrini
2023-08-23 14:09 ` Nicola Vetrini
2023-08-23 14:14 ` Roger Pau Monné
2023-08-17 12:39 ` [XEN PATCH v2 3/3] drivers/video: make declarations of defined functions available Nicola Vetrini
2023-08-17 13:28 ` Jan Beulich
2023-08-17 14:52 ` Nicola Vetrini
2023-08-17 15:02 ` Jan Beulich
2023-08-17 16:04 ` Nicola Vetrini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1692275359.git.nicola.vetrini@bugseng.com \
--to=nicola.vetrini@bugseng.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=aisaila@bitdefender.com \
--cc=andrew.cooper3@citrix.com \
--cc=ayan.kumar.halder@amd.com \
--cc=bertrand.marquis@arm.com \
--cc=consulting@bugseng.com \
--cc=george.dunlap@citrix.com \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=michal.orzel@amd.com \
--cc=ppircalabu@bitdefender.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=tamas@tklengyel.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
--cc=xenia.ragiadakou@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.