From: Taylor Blau <me@ttaylorr.com>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>, Jeff King <peff@peff.net>,
Derrick Stolee <derrickstolee@github.com>
Subject: [PATCH v3 0/4] commit-graph: fsck zero/non-zero generation number fixes
Date: Mon, 21 Aug 2023 17:34:32 -0400 [thread overview]
Message-ID: <cover.1692653671.git.me@ttaylorr.com> (raw)
In-Reply-To: <ZNUiEXF5CP6WMk9A@nand.local>
Here's a(nother) small reroll of a series that I sent which expanded on
a patch that Peff sent earlier in the thread to remove a section of
unreachable code that was noticed by Coverity in the
`verify_one_commit_graph()` function.
The first few patches are the same, but the fourth (now final) patch is
modified to track a single example of a commit with zero and non-zero
generation to only emit the warning once at the end of processing.
Thanks as always for your review!
Jeff King (1):
commit-graph: verify swapped zero/non-zero generation cases
Taylor Blau (3):
commit-graph: introduce `commit_graph_generation_from_graph()`
t/t5318-commit-graph.sh: test generation zero transitions during fsck
commit-graph: commit-graph: avoid repeated mixed generation number
warnings
commit-graph.c | 38 ++++++++++++++++++++++++--------------
t/t5318-commit-graph.sh | 18 ++++++++++++------
2 files changed, 36 insertions(+), 20 deletions(-)
Range-diff against v2:
1: a1cc22297e = 1: c88f945a54 commit-graph: introduce `commit_graph_generation_from_graph()`
2: 38b8cd5e9f = 2: 8f8e0b6644 commit-graph: verify swapped zero/non-zero generation cases
3: d14f3ca840 = 3: 34a505dd4b t/t5318-commit-graph.sh: test generation zero transitions during fsck
4: e378fd6f93 < -: ---------- commit-graph: invert negated conditional, extract to function
5: 23bcb7d270 < -: ---------- commit-graph: avoid repeated mixed generation number warnings
-: ---------- > 4: 52b49bb434 commit-graph: commit-graph: avoid repeated mixed generation number warnings
--
2.42.0.4.g52b49bb434
next prev parent reply other threads:[~2023-08-21 21:34 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-08 19:15 [RFC/PATCH] commit-graph: verify swapped zero/non-zero generation cases Jeff King
2023-08-10 16:00 ` Taylor Blau
2023-08-10 17:44 ` Taylor Blau
2023-08-10 20:37 ` [PATCH 0/4] commit-graph: fsck zero/non-zero generation number fixes Taylor Blau
2023-08-10 20:37 ` [PATCH 1/4] commit-graph: introduce `commit_graph_generation_from_graph()` Taylor Blau
2023-08-10 20:37 ` [PATCH 2/4] commit-graph: verify swapped zero/non-zero generation cases Taylor Blau
2023-08-10 21:36 ` Junio C Hamano
2023-08-11 15:01 ` Jeff King
2023-08-11 17:08 ` Taylor Blau
2023-08-10 20:37 ` [PATCH 3/4] t/t5318-commit-graph.sh: test generation zero transitions during fsck Taylor Blau
2023-08-10 20:37 ` [PATCH 4/4] commit-graph: invert negated conditional Taylor Blau
2023-08-11 15:02 ` [PATCH 0/4] commit-graph: fsck zero/non-zero generation number fixes Jeff King
2023-08-11 17:05 ` [PATCH v2 0/5] " Taylor Blau
2023-08-11 17:05 ` [PATCH v2 1/5] commit-graph: introduce `commit_graph_generation_from_graph()` Taylor Blau
2023-08-11 17:05 ` [PATCH v2 2/5] commit-graph: verify swapped zero/non-zero generation cases Taylor Blau
2023-08-11 17:05 ` [PATCH v2 3/5] t/t5318-commit-graph.sh: test generation zero transitions during fsck Taylor Blau
2023-08-11 17:05 ` [PATCH v2 4/5] commit-graph: invert negated conditional, extract to function Taylor Blau
2023-08-11 17:05 ` [PATCH v2 5/5] commit-graph: avoid repeated mixed generation number warnings Taylor Blau
2023-08-11 17:58 ` [PATCH v2 0/5] commit-graph: fsck zero/non-zero generation number fixes Jeff King
2023-08-11 19:28 ` Junio C Hamano
2023-08-17 19:51 ` Jeff King
2023-08-21 21:25 ` Taylor Blau
2023-08-21 21:34 ` Taylor Blau [this message]
2023-08-21 21:34 ` [PATCH v3 1/4] commit-graph: introduce `commit_graph_generation_from_graph()` Taylor Blau
2023-08-21 21:34 ` [PATCH v3 2/4] commit-graph: verify swapped zero/non-zero generation cases Taylor Blau
2023-08-21 21:34 ` [PATCH v3 3/4] t/t5318-commit-graph.sh: test generation zero transitions during fsck Taylor Blau
2023-08-21 21:34 ` [PATCH v3 4/4] commit-graph: commit-graph: avoid repeated mixed generation number warnings Taylor Blau
2023-08-21 21:55 ` [PATCH v3 0/4] commit-graph: fsck zero/non-zero generation number fixes Jeff King
2023-08-21 23:22 ` Junio C Hamano
2023-08-23 19:59 ` Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1692653671.git.me@ttaylorr.com \
--to=me@ttaylorr.com \
--cc=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.