All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni@redhat.com>
To: mptcp@lists.linux.dev
Subject: [PATCH mptcp-net v5 0/2] mptcp: fix another close hang-up
Date: Wed,  6 Sep 2023 10:30:26 +0200	[thread overview]
Message-ID: <cover.1693988314.git.pabeni@redhat.com> (raw)

If the TCP subflows close silently due to timeouts, the msk socket
can hang-up indefinitely.

Implement an additional close timeout triggered with the last subflow
close event and move the msk to TCP_CLOSE when it fires.

Should address issues/430 and issues/431.

v4 -> v5:
 - let the tout always expire for dead socks (Mat)
 - fix comment type (Mat)
 - targeting net, added fixes tag

v3 -> v4:
 - fix off-by-one in timer update/check (sigh, trival math is too
   hard:/)

v2 -> v3:
 - fix int overlflow in patch 2/2

v1 -> v2:
 - fix timeout timer scheduling in patch 2/2 (timeout never fired on v1)

Paolo Abeni (2):
  mptcp: rename timer related helper to less confusing names
  mptcp: fix dangling connection hang-up

 net/mptcp/protocol.c | 124 +++++++++++++++++++++----------------------
 net/mptcp/protocol.h |  26 ++++++++-
 net/mptcp/subflow.c  |   3 +-
 3 files changed, 88 insertions(+), 65 deletions(-)

-- 
2.41.0


             reply	other threads:[~2023-09-06  8:30 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-06  8:30 Paolo Abeni [this message]
2023-09-06  8:30 ` [PATCH mptcp-net v5 1/2] mptcp: rename timer related helper to less confusing names Paolo Abeni
2023-09-06  8:30 ` [PATCH mptcp-net v5 2/2] mptcp: fix dangling connection hang-up Paolo Abeni
2023-09-06  9:42   ` mptcp: fix dangling connection hang-up: Tests Results MPTCP CI
2023-09-09 15:50   ` [PATCH mptcp-net v5 2/2] mptcp: fix dangling connection hang-up Matthieu Baerts
2023-09-11  6:13     ` Paolo Abeni
2023-09-11  8:42       ` Matthieu Baerts
2023-09-11 10:12         ` Paolo Abeni
2023-09-11 11:34           ` Matthieu Baerts
2023-09-12 13:15             ` Paolo Abeni
2023-09-09 16:03   ` Matthieu Baerts
2023-09-09 16:12 ` [PATCH mptcp-net v5 0/2] mptcp: fix another close hang-up Matthieu Baerts
2023-09-11 20:16   ` Mat Martineau
2023-09-13  7:49     ` Matthieu Baerts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1693988314.git.pabeni@redhat.com \
    --to=pabeni@redhat.com \
    --cc=mptcp@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.