All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans Verkuil <hverkuil-cisco@xs4all.nl>
To: linux-media@vger.kernel.org
Cc: "Dr . David Alan Gilbert" <dave@treblig.org>,
	Deborah Brouwer <deborah.brouwer@collabora.com>
Subject: [PATCH 0/3] media: bttv: three post-vb2 fixes
Date: Thu, 30 Nov 2023 13:58:09 +0100	[thread overview]
Message-ID: <cover.1701349092.git.hverkuil-cisco@xs4all.nl> (raw)

Dave, thank you for your detailed bttv bug report:

https://lore.kernel.org/linux-media/ZVK_3UmvmOaCv1tc@gallifrey/

It was very helpful and I managed to reproduce these issues.

This patch series fixes them.

The first patch is unrelated, just something I noticed while
debugging this.

The second patch adds back the old bttv behavior of storing the
frame counter in the last 4 bytes of the vbi payload when using
read().

The final patch fixes the vbi read() behavior where it was
alternating between valid data and a zeroed buffer.

I'd appreciate it if you can test this before Dec 11 since I
plan to merge on Dec 11 if I don't hear anything.

Regards,

	Hans

Hans Verkuil (3):
  media: bttv: start_streaming should return a proper error code
  media: bttv: add back vbi hack
  media: videobuf2: request more buffers for vb2_read

 .../media/common/videobuf2/videobuf2-core.c   |  9 +++++--
 drivers/media/pci/bt8xx/bttv-driver.c         | 27 ++++++++++++++++---
 drivers/media/pci/bt8xx/bttv-vbi.c            |  8 +++---
 3 files changed, 33 insertions(+), 11 deletions(-)

-- 
2.42.0


             reply	other threads:[~2023-11-30 13:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-30 12:58 Hans Verkuil [this message]
2023-11-30 12:58 ` [PATCH 1/3] media: bttv: start_streaming should return a proper error code Hans Verkuil
2023-11-30 12:58 ` [PATCH 2/3] media: bttv: add back vbi hack Hans Verkuil
2023-12-03 16:17   ` Dr. David Alan Gilbert
2023-11-30 12:58 ` [PATCH 3/3] media: videobuf2: request more buffers for vb2_read Hans Verkuil
2023-12-03 16:46   ` Dr. David Alan Gilbert
2023-12-04  8:48     ` Hans Verkuil
2023-11-30 14:26 ` [PATCH 0/3] media: bttv: three post-vb2 fixes Dr. David Alan Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1701349092.git.hverkuil-cisco@xs4all.nl \
    --to=hverkuil-cisco@xs4all.nl \
    --cc=dave@treblig.org \
    --cc=deborah.brouwer@collabora.com \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.