From: Qu Wenruo <wqu@suse.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH v2 0/2] btrfs-progs: fix the return value of "btrfs subvolume create"
Date: Wed, 10 Jan 2024 19:06:32 +1030 [thread overview]
Message-ID: <cover.1704875723.git.wqu@suse.com> (raw)
[CHANGELOG]
v2:
- Fix the missing "f" for the subject of the first patch
- Add the missing unmount of the test case
There is a bug report ("https://github.com/kdave/btrfs-progs/issues/730")
that after commit 5aa959fb3440 ("btrfs-progs: subvolume create: accept
multiple arguments"), "btrfs subvolume create" no longer properly return
1 for error cases.
It turns out that the offending commit changed how we determine the
return code, thus for several error cases, we still return 0 for
create_one_subvolume().
Fix it and add a test case for it.
Qu Wenruo (2):
btrfs-progs: cmd/subvolume: fix return value when the target exists
btrfs-progs: cli-tests: add test case for return value of "btrfs
subvlume create"
cmds/subvolume.c | 11 ++++++-
.../025-subvolume-create-failures/test.sh | 32 +++++++++++++++++++
2 files changed, 42 insertions(+), 1 deletion(-)
create mode 100755 tests/cli-tests/025-subvolume-create-failures/test.sh
--
2.43.0
next reply other threads:[~2024-01-10 8:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-10 8:36 Qu Wenruo [this message]
2024-01-10 8:36 ` [PATCH v2 1/2] btrfs-progs: cmd/subvolume: fix return value when the target exists Qu Wenruo
2024-01-10 8:36 ` [PATCH v2 2/2] btrfs-progs: cli-tests: add test case for return value of "btrfs subvlume create" Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1704875723.git.wqu@suse.com \
--to=wqu@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.