From: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Marc-André Lureau" <marcandre.lureau@gmail.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Gurchetan Singh" <gurchetansingh@chromium.org>,
"Alyssa Ross" <hi@alyssa.is>
Subject: [PATCH v2 0/3] Fix resource freeing bugs in virtio-gpu-rutabaga
Date: Mon, 29 Jan 2024 17:45:22 +0200 [thread overview]
Message-ID: <cover.1706542958.git.manos.pitsidianakis@linaro.org> (raw)
While testing the rutabaga gpu device, we noticed that if the device is
reset, it stops working and complains about missing resource ids. A
quick investigation discovered that the generic VirtIOGPU implementation
frees all resources, but for Rutabaga, they are tied with rutabaga
objects that need to be destroyed as well.
This series adds a resource_destroy class method that the Rutabaga
device can override and do its own bookkeeping.
v1 -> v2 differences:
- addressed review comments re: using the Error API for the
resource_destroy method.
Manos Pitsidianakis (3):
hw/display/virtio-gpu.c: use reset_bh class method
virtio-gpu.c: add resource_destroy class method
virtio-gpu-rutabaga.c: override resource_destroy method
include/hw/virtio/virtio-gpu.h | 3 ++
hw/display/virtio-gpu-rutabaga.c | 51 ++++++++++++++++++++++++--------
hw/display/virtio-gpu.c | 27 ++++++++++++++---
3 files changed, 65 insertions(+), 16 deletions(-)
base-commit: 7a1dc45af581d2b643cdbf33c01fd96271616fbd
--
γαῖα πυρί μιχθήτω
next reply other threads:[~2024-01-29 15:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-29 15:45 Manos Pitsidianakis [this message]
2024-01-29 15:45 ` [PATCH v2 1/3] hw/display/virtio-gpu.c: use reset_bh class method Manos Pitsidianakis
2024-01-29 15:45 ` [PATCH v2 2/3] virtio-gpu.c: add resource_destroy " Manos Pitsidianakis
2024-01-30 12:46 ` Marc-André Lureau
2024-01-29 15:45 ` [PATCH v2 3/3] virtio-gpu-rutabaga.c: override resource_destroy method Manos Pitsidianakis
2024-01-30 1:26 ` Gurchetan Singh
2024-01-30 6:53 ` Manos Pitsidianakis
2024-01-30 12:50 ` Marc-André Lureau
2024-01-30 13:01 ` Manos Pitsidianakis
2024-01-30 13:09 ` Marc-André Lureau
2024-01-30 13:50 ` Manos Pitsidianakis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1706542958.git.manos.pitsidianakis@linaro.org \
--to=manos.pitsidianakis@linaro.org \
--cc=gurchetansingh@chromium.org \
--cc=hi@alyssa.is \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=mst@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.