All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni@redhat.com>
To: mptcp@lists.linux.dev
Subject: [PATCH mptcp-net 0/4] mptcp: fix duplicate subflow creation
Date: Mon,  5 Feb 2024 16:51:38 +0100	[thread overview]
Message-ID: <cover.1707144963.git.pabeni@redhat.com> (raw)

As reported by Mat, the in kernel PM can, in some edge scenarios,
unexpectedly create multiple subflows with the same local and remote
address.

The real fix is implemented by patch 4/4 with some more accurate check
at subflow creation time.

Patches 1-3 are roughly optional pre-requisities, added to avoid
introducing more data-races with the actual fix. Patch 1/4 is a bit
debatable, as it changes the existing ULP API, but I could not find a
better solution and there is some similar prior art:
commit 0df48c26d841 ("tcp: add tcpi_bytes_acked to tcp_info")

Paolo Abeni (4):
  mptcp: fix lockless access in subflow ULP diag
  mptcp: fix data races on local_id
  mptcp: fix data races on remote_id
  mptcp: fix duplicate subflow creation

 include/net/tcp.h      |  2 +-
 net/mptcp/diag.c       |  6 +++++-
 net/mptcp/pm_netlink.c | 43 ++++++++++++++++++++++--------------------
 net/mptcp/protocol.c   |  2 +-
 net/mptcp/protocol.h   | 15 ++++++++++++---
 net/mptcp/subflow.c    | 15 ++++++++-------
 net/tls/tls_main.c     |  2 +-
 7 files changed, 51 insertions(+), 34 deletions(-)

-- 
2.43.0


             reply	other threads:[~2024-02-05 15:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-05 15:51 Paolo Abeni [this message]
2024-02-05 15:51 ` [PATCH mptcp-net 1/4] mptcp: fix lockless access in subflow ULP diag Paolo Abeni
2024-02-05 15:51 ` [PATCH mptcp-net 2/4] mptcp: fix data races on local_id Paolo Abeni
2024-02-07  3:30   ` Mat Martineau
2024-02-05 15:51 ` [PATCH mptcp-net 3/4] mptcp: fix data races on remote_id Paolo Abeni
2024-02-07  3:33   ` Mat Martineau
2024-02-05 15:51 ` [PATCH mptcp-net 4/4] mptcp: fix duplicate subflow creation Paolo Abeni
2024-02-05 16:50   ` mptcp: fix duplicate subflow creation: Tests Results MPTCP CI
2024-02-05 17:08   ` MPTCP CI
2024-02-07  3:35   ` [PATCH mptcp-net 4/4] mptcp: fix duplicate subflow creation Mat Martineau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1707144963.git.pabeni@redhat.com \
    --to=pabeni@redhat.com \
    --cc=mptcp@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.