From: Dirk Gouders <dirk@gouders.net>
To: git@vger.kernel.org
Cc: Dirk Gouders <dirk@gouders.net>,
Junio C Hamano <gitster@pobox.com>,
Emily Shaffer <emilyshaffer@google.com>,
Kyle Lippincott <spectral@google.com>
Subject: [PATCH v5 0/5] Fixes for Documentation/MyFirstObjectWalk.txt
Date: Wed, 27 Mar 2024 12:22:11 +0100 [thread overview]
Message-ID: <cover.1711537370.git.dirk@gouders.net> (raw)
In-Reply-To: <20240326130902.7111-1-dirk@gouders.net>
The fifth round with the correction that a list itself cannot have
performance implications -- asking for one may have.
---
Changes in v5:
* Rephrase implications that asking for an `omitted` list
may have in [4/5]
Changes in v4:
* Used the proper `git show` for references in [1/5] and [3/5]
* Another attempt to write clear speach in [4/5]
Changes in v3:
* Reword the description in [4/5]
* Add a missing slash in [5/5]
Changes in v2:
* Added Emily to Cc in the hope for a review
* Remove superfluous tags from [1/5] and [3/5]
* Replace bashism `|&` by `2>&1 |` in [5/5]
---
Dirk Gouders (5):
MyFirstObjectWalk: use additional arg in config_fn_t
MyFirstObjectWalk: fix misspelled "builtins/"
MyFirstObjectWalk: fix filtered object walk
MyFirstObjectWalk: fix description for counting omitted objects
MyFirstObjectWalk: add stderr to pipe processing
Documentation/MyFirstObjectWalk.txt | 37 ++++++++++++++++-------------
1 file changed, 21 insertions(+), 16 deletions(-)
Range-diff against v4:
1: 2501fea789 = 1: 292ae67548 MyFirstObjectWalk: use additional arg in config_fn_t
2: 6b336e15d6 = 2: 99284db8c1 MyFirstObjectWalk: fix misspelled "builtins/"
3: 83034594e2 = 3: e1b4a4c996 MyFirstObjectWalk: fix filtered object walk
4: f23ff9fd1b ! 4: e6030f1c0a MyFirstObjectWalk: fix description for counting omitted objects
@@ Documentation/MyFirstObjectWalk.txt: points to the same tree object as its grand
-reachable objects are walked in order to populate the list.
+filter, like with `git log --filter=<spec> --filter-print-omitted`. To do this,
+change `traverse_commit_list()` to `traverse_commit_list_filtered()`, which is
-+able to populate an `omitted` list. This list of filtered objects may have
-+performance implications, however, because despite filtering objects, the possibly
-+much larger set of all reachable objects must be processed in order to
-+populate that list.
++able to populate an `omitted` list. Asking for this list of filtered objects
++may cause performance degradations, however, because in this case, despite
++filtering objects, the possibly much larger set of all reachable objects must
++be processed in order to populate that list.
First, add the `struct oidset` and related items we will use to iterate it:
5: 582cb7d44a = 5: 0a3dbd1452 MyFirstObjectWalk: add stderr to pipe processing
--
2.43.0
next prev parent reply other threads:[~2024-03-27 11:22 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-11 21:36 [PATCH 0/5] Fixes for Documentation/MyFirstObjectWalk.txt Dirk Gouders
2024-03-11 10:11 ` [PATCH 1/5] MyFirstObjectWalk: use additional arg in config_fn_t Dirk Gouders
2024-03-12 0:18 ` Junio C Hamano
2024-03-11 10:26 ` [PATCH 2/5] MyFirstObjectWalk: fix misspelled "builtins/" Dirk Gouders
2024-03-11 12:47 ` [PATCH 3/5] MyFirstObjectWalk: fix filtered object walk Dirk Gouders
2024-03-11 13:29 ` [PATCH 4/5] MyFirstObjectWalk: fix description for counting omitted objects Dirk Gouders
2024-03-11 21:00 ` [PATCH 5/5] MyFirstObjectWalk: add stderr to pipe processing Dirk Gouders
2024-03-12 0:13 ` Junio C Hamano
2024-03-12 14:27 ` Dirk Gouders
2024-03-12 19:29 ` Junio C Hamano
2024-03-12 0:15 ` [PATCH 0/5] Fixes for Documentation/MyFirstObjectWalk.txt Junio C Hamano
2024-03-19 11:23 ` [PATCH v2 " Dirk Gouders
2024-03-19 11:23 ` [PATCH v2 1/5] MyFirstObjectWalk: use additional arg in config_fn_t Dirk Gouders
2024-03-23 19:28 ` Kyle Lippincott
2024-03-19 11:23 ` [PATCH v2 2/5] MyFirstObjectWalk: fix misspelled "builtins/" Dirk Gouders
2024-03-19 11:23 ` [PATCH v2 3/5] MyFirstObjectWalk: fix filtered object walk Dirk Gouders
2024-03-19 11:23 ` [PATCH v2 4/5] MyFirstObjectWalk: fix description for counting omitted objects Dirk Gouders
2024-03-23 21:59 ` Kyle Lippincott
2024-03-23 22:46 ` Dirk Gouders
2024-03-19 11:23 ` [PATCH v2 5/5] MyFirstObjectWalk: add stderr to pipe processing Dirk Gouders
2024-03-23 19:48 ` Kyle Lippincott
2024-03-23 20:16 ` Dirk Gouders
2024-03-23 22:00 ` [PATCH v2 0/5] Fixes for Documentation/MyFirstObjectWalk.txt Kyle Lippincott
2024-03-23 23:06 ` Dirk Gouders
2024-03-24 2:20 ` Junio C Hamano
2024-03-25 12:33 ` [PATCH v3 " Dirk Gouders
2024-03-25 12:33 ` [PATCH v3 1/5] MyFirstObjectWalk: use additional arg in config_fn_t Dirk Gouders
2024-03-25 17:16 ` Junio C Hamano
2024-03-25 19:50 ` Dirk Gouders
2024-03-25 12:33 ` [PATCH v3 2/5] MyFirstObjectWalk: fix misspelled "builtins/" Dirk Gouders
2024-03-25 12:33 ` [PATCH v3 3/5] MyFirstObjectWalk: fix filtered object walk Dirk Gouders
2024-03-25 12:33 ` [PATCH v3 4/5] MyFirstObjectWalk: fix description for counting omitted objects Dirk Gouders
2024-03-25 17:25 ` Junio C Hamano
2024-03-25 20:07 ` Dirk Gouders
2024-03-25 21:25 ` Junio C Hamano
2024-03-25 20:59 ` Kyle Lippincott
2024-03-25 12:33 ` [PATCH v3 5/5] MyFirstObjectWalk: add stderr to pipe processing Dirk Gouders
2024-03-25 17:05 ` [PATCH v3 0/5] Fixes for Documentation/MyFirstObjectWalk.txt Kyle Lippincott
2024-03-25 20:07 ` Dirk Gouders
2024-03-25 17:50 ` Junio C Hamano
2024-03-25 18:01 ` Kyle Lippincott
2024-03-25 20:22 ` Dirk Gouders
2024-03-26 13:08 ` [PATCH v4 " Dirk Gouders
2024-03-27 1:04 ` Kyle Lippincott
2024-03-27 6:25 ` Dirk Gouders
2024-03-27 11:22 ` Dirk Gouders [this message]
2024-03-27 11:22 ` [PATCH v5 1/5] MyFirstObjectWalk: use additional arg in config_fn_t Dirk Gouders
2024-03-27 11:22 ` [PATCH v5 2/5] MyFirstObjectWalk: fix misspelled "builtins/" Dirk Gouders
2024-03-27 11:22 ` [PATCH v5 3/5] MyFirstObjectWalk: fix filtered object walk Dirk Gouders
2024-03-27 11:22 ` [PATCH v5 4/5] MyFirstObjectWalk: fix description for counting omitted objects Dirk Gouders
2024-03-27 11:22 ` [PATCH v5 5/5] MyFirstObjectWalk: add stderr to pipe processing Dirk Gouders
2024-03-26 13:08 ` [PATCH v4 1/5] MyFirstObjectWalk: use additional arg in config_fn_t Dirk Gouders
2024-03-26 13:08 ` [PATCH v4 2/5] MyFirstObjectWalk: fix misspelled "builtins/" Dirk Gouders
2024-03-26 13:08 ` [PATCH v4 3/5] MyFirstObjectWalk: fix filtered object walk Dirk Gouders
2024-03-26 13:08 ` [PATCH v4 4/5] MyFirstObjectWalk: fix description for counting omitted objects Dirk Gouders
2024-03-26 17:00 ` Junio C Hamano
2024-03-26 20:09 ` Dirk Gouders
2024-03-26 20:24 ` Junio C Hamano
2024-03-27 6:30 ` Dirk Gouders
2024-03-26 13:08 ` [PATCH v4 5/5] MyFirstObjectWalk: add stderr to pipe processing Dirk Gouders
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1711537370.git.dirk@gouders.net \
--to=dirk@gouders.net \
--cc=emilyshaffer@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=spectral@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.