All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: jani.nikula@intel.com, lucas.demarchi@intel.com, rodrigo.vivi@intel.com
Subject: [PATCH 0/5] drm/i915/dmc: firmware path handling changes
Date: Thu, 18 Apr 2024 17:39:49 +0300	[thread overview]
Message-ID: <cover.1713450693.git.jani.nikula@intel.com> (raw)

We tried moving the dmc_firmware_path param from i915 to display params
before, so it would be present in xe as well as i915. This was commit
0d82a0d6f556 ("drm/i915/display: move dmc_firmware_path to display
params"). That failed, so I tried a quick fix, but that failed too
[1]. Revert followed in commit 318e82583ca9 ("Revert "drm/i915/display:
move dmc_firmware_path to display params"").

Do some refactoring and prep work first, with the most significant
change being the removal of special handling of
i915.dmc_firmware_path="" to disable DMC. This will now lead to the
platform default firmware being used.

To disable DMC and runtime PM, you'll need to specify a non-existent
file instead. There's no "magic" name specified for that.

BR,
Jani.



[1] https://lore.kernel.org/r/87h6gieuud.fsf@intel.com

Jani Nikula (5):
  drm/i915/dmc: handle request_firmware() errors separately
  drm/i915/dmc: improve firmware parse failure propagation
  drm/i915/dmc: split out per-platform firmware path selection
  drm/i915/dmc: change meaning of dmc_firmware_path="" module param
  drm/i915/display: move dmc_firmware_path to display params

 .../drm/i915/display/intel_display_params.c   |   4 +
 .../drm/i915/display/intel_display_params.h   |   1 +
 drivers/gpu/drm/i915/display/intel_dmc.c      | 162 ++++++++++--------
 drivers/gpu/drm/i915/i915_params.c            |   3 -
 drivers/gpu/drm/i915/i915_params.h            |   1 -
 drivers/gpu/drm/xe/xe_device_types.h          |   3 -
 6 files changed, 98 insertions(+), 76 deletions(-)

-- 
2.39.2


             reply	other threads:[~2024-04-18 14:40 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-18 14:39 Jani Nikula [this message]
2024-04-18 14:39 ` [PATCH 1/5] drm/i915/dmc: handle request_firmware() errors separately Jani Nikula
2024-04-18 18:30   ` Gustavo Sousa
2024-04-18 19:56     ` Jani Nikula
2024-04-18 19:59       ` Gustavo Sousa
2024-04-18 14:39 ` [PATCH 2/5] drm/i915/dmc: improve firmware parse failure propagation Jani Nikula
2024-04-18 18:53   ` Gustavo Sousa
2024-04-18 20:03     ` Jani Nikula
2024-04-18 20:40       ` Gustavo Sousa
2024-04-18 14:39 ` [PATCH 3/5] drm/i915/dmc: split out per-platform firmware path selection Jani Nikula
2024-04-18 19:00   ` Gustavo Sousa
2024-04-18 14:39 ` [PATCH 4/5] drm/i915/dmc: change meaning of dmc_firmware_path="" module param Jani Nikula
2024-04-18 19:19   ` Gustavo Sousa
2024-04-18 20:09     ` Jani Nikula
2024-04-18 20:44       ` Gustavo Sousa
2024-04-18 20:49         ` Lucas De Marchi
2024-04-18 14:39 ` [PATCH 5/5] drm/i915/display: move dmc_firmware_path to display params Jani Nikula
2024-04-18 19:43   ` Gustavo Sousa
2024-04-18 15:55 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dmc: firmware path handling changes Patchwork
2024-04-18 15:55 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-04-18 16:08 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-04-18 16:54 ` ✓ CI.Patch_applied: success " Patchwork
2024-04-18 16:54 ` ✗ CI.checkpatch: warning " Patchwork
2024-04-18 16:55 ` ✓ CI.KUnit: success " Patchwork
2024-04-18 17:15 ` ✓ CI.Build: " Patchwork
2024-04-18 17:17 ` ✓ CI.Hooks: " Patchwork
2024-04-18 17:25 ` ✗ CI.checksparse: warning " Patchwork
2024-04-18 18:01 ` ✓ CI.BAT: success " Patchwork
2024-04-20  8:00 ` ✗ CI.FULL: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1713450693.git.jani.nikula@intel.com \
    --to=jani.nikula@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=lucas.demarchi@intel.com \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.