All of lore.kernel.org
 help / color / mirror / Atom feed
From: Qu Wenruo <wqu@suse.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH 0/2] btrfs: basic header cleanups
Date: Tue, 28 May 2024 15:03:46 +0930	[thread overview]
Message-ID: <cover.1716874214.git.wqu@suse.com> (raw)

While reading headers, clangd would do a lot of extra checks, from the
very basic like including the header itself, to missing type definition
inside the header's include chain.

There are 2 very basic fixes can be done immediately:

- Do not do recursive include

- Do not include rwlock_types.h
  As it already mentioned to include spinlock_types.h instead.

Qu Wenruo (2):
  btrfs: cleanup recursive include of the same header
  btrfs: do not directly rwlock_types.h

 fs/btrfs/btrfs_inode.h | 1 -
 fs/btrfs/extent_map.h  | 3 +--
 fs/btrfs/fs.h          | 1 -
 fs/btrfs/locking.h     | 1 -
 fs/btrfs/lru_cache.h   | 1 -
 5 files changed, 1 insertion(+), 6 deletions(-)

-- 
2.45.1


             reply	other threads:[~2024-05-28  5:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-28  5:33 Qu Wenruo [this message]
2024-05-28  5:33 ` [PATCH 1/2] btrfs: cleanup recursive include of the same header Qu Wenruo
2024-05-28 10:20   ` Filipe Manana
2024-05-28 21:10     ` David Sterba
2024-05-28  5:33 ` [PATCH 2/2] btrfs: do not directly rwlock_types.h Qu Wenruo
2024-05-28 10:22   ` Filipe Manana
2024-05-28 15:33 ` [PATCH 0/2] btrfs: basic header cleanups David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1716874214.git.wqu@suse.com \
    --to=wqu@suse.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.