From: Qu Wenruo <wqu@suse.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH 0/3] btrfs: remove __GFP_NOFAIL usage for debug builds
Date: Fri, 5 Jul 2024 15:45:37 +0930 [thread overview]
Message-ID: <cover.1720159494.git.wqu@suse.com> (raw)
This patchset removes all __GFP_NOFAIL flags usage inside btrfs for
DEBUG builds.
There are 3 call sites utilizing __GFP_NOFAIL:
- __alloc_extent_buffer()
It's for the extent_buffer structure allocation.
All callers are already handling the errors.
- attach_eb_folio_to_filemap()
It's for the filemap_add_folio() call, the flag is also passed to mem
cgroup, which I suspect is not handling larger folio and __GFP_NOFAIL
correctly, as I'm hitting soft lockups when testing larger folios
New error handling is added.
- btrfs_alloc_folio_array()
This is for page allocation for extent buffers.
All callers are already handling the errors.
Furthermore, to enable more testing while not affecting end users, the
change is only implemented for DEBUG builds.
Qu Wenruo (3):
btrfs: do not use __GFP_NOFAIL flag for __alloc_extent_buffer()
btrfs: do not use __GFP_NOFAIL flag for attach_eb_folio_to_filemap()
btrfs: do not use __GFP_NOFAIL flag for btrfs_alloc_folio_array()
fs/btrfs/extent_io.c | 18 +++++++++++++++---
1 file changed, 15 insertions(+), 3 deletions(-)
--
2.45.2
next reply other threads:[~2024-07-05 6:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-05 6:15 Qu Wenruo [this message]
2024-07-05 6:15 ` [PATCH 1/3] btrfs: do not use __GFP_NOFAIL flag for __alloc_extent_buffer() Qu Wenruo
2024-07-05 6:15 ` [PATCH 2/3] btrfs: do not use __GFP_NOFAIL flag for attach_eb_folio_to_filemap() Qu Wenruo
2024-07-05 6:15 ` [PATCH 3/3] btrfs: do not use __GFP_NOFAIL flag for btrfs_alloc_folio_array() Qu Wenruo
2024-07-05 14:55 ` [PATCH 0/3] btrfs: remove __GFP_NOFAIL usage for debug builds Josef Bacik
2024-07-05 22:40 ` Qu Wenruo
2024-07-30 13:55 ` David Sterba
2024-07-30 22:17 ` Qu Wenruo
2024-07-31 17:13 ` David Sterba
2024-08-04 9:22 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1720159494.git.wqu@suse.com \
--to=wqu@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.