All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boris Burkov <boris@bur.io>
To: linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: [PATCH 0/2] btrfs: fixes for buffered write qgroup rsv leaks
Date: Tue, 23 Jul 2024 15:55:55 -0700	[thread overview]
Message-ID: <cover.1721775142.git.boris@bur.io> (raw)

generic/475 exposes qgroup rsv leaks under EIO errors. These are fixes
for two classes of buffered write errors we are still hitting:
1. dirty pages leaked during an aborted transaction
2. dirty pages getting un-dirtied and leaked by cow_file_range when it
   doesn't make an ordered extent for a range.

After these two fixes, I was able to run generic/475 with squota enabled
at mkfs 100 times in a row without an error, and a modified generic/475
that always sleeps for 0 seconds 500 times.

Boris Burkov (2):
  btrfs: implement launder_folio for clearing dirty page rsv
  btrfs: fix qgroup rsv leaks in cow_file_range

 fs/btrfs/inode.c | 9 +++++++++
 1 file changed, 9 insertions(+)

-- 
2.45.2


             reply	other threads:[~2024-07-23 22:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-23 22:55 Boris Burkov [this message]
2024-07-23 22:55 ` [PATCH 1/2] btrfs: implement launder_folio for clearing dirty page rsv Boris Burkov
2024-07-23 23:20   ` Qu Wenruo
2024-07-23 22:55 ` [PATCH 2/2] btrfs: fix qgroup rsv leaks in cow_file_range Boris Burkov
2024-07-23 23:24   ` Qu Wenruo
2024-07-30 13:45 ` [PATCH 0/2] btrfs: fixes for buffered write qgroup rsv leaks David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1721775142.git.boris@bur.io \
    --to=boris@bur.io \
    --cc=kernel-team@fb.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.